[JBoss JIRA] (ROASTER-34) Add a method MethodSource.removeParameter(Class<?> aClass, String s)
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/ROASTER-34?page=com.atlassian.jira.plugin... ]
George Gastaldi closed ROASTER-34.
----------------------------------
Assignee: George Gastaldi
Fix Version/s: 2.7.2.Final
(was: 2.x Future)
Resolution: Done
> Add a method MethodSource.removeParameter(Class<?> aClass, String s)
> --------------------------------------------------------------------
>
> Key: ROASTER-34
> URL: https://issues.jboss.org/browse/ROASTER-34
> Project: Roaster
> Issue Type: Feature Request
> Components: API
> Affects Versions: 2.7.1.Final
> Reporter: Antonio Goncalves
> Assignee: George Gastaldi
> Fix For: 2.7.2.Final
>
>
> At the moment it's easy to add a parameter to a method knowing its name and type :
> {code}
> property.getMutator().addParameter(LocalDate.class, "myDate");
> {code}
> It would be good to have the same facility to remove a parameter given a type and a name. Something like :
> {code}
> property.getMutator().removeParameter(LocalDate.class, "myDate");
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
9 years, 9 months
[JBoss JIRA] (ROASTER-34) Add a method MethodSource.removeParameter(Class<?> aClass, String s)
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/ROASTER-34?page=com.atlassian.jira.plugin... ]
George Gastaldi commented on ROASTER-34:
----------------------------------------
Although I believe it's safer to use the beforementioned method to remove parameters, I believe it may be easier having such facility
> Add a method MethodSource.removeParameter(Class<?> aClass, String s)
> --------------------------------------------------------------------
>
> Key: ROASTER-34
> URL: https://issues.jboss.org/browse/ROASTER-34
> Project: Roaster
> Issue Type: Feature Request
> Components: API
> Affects Versions: 2.7.1.Final
> Reporter: Antonio Goncalves
> Fix For: 2.x Future
>
>
> At the moment it's easy to add a parameter to a method knowing its name and type :
> {code}
> property.getMutator().addParameter(LocalDate.class, "myDate");
> {code}
> It would be good to have the same facility to remove a parameter given a type and a name. Something like :
> {code}
> property.getMutator().removeParameter(LocalDate.class, "myDate");
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
9 years, 9 months
[JBoss JIRA] (ROASTER-34) Add a method MethodSource.removeParameter(Class<?> aClass, String s)
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/ROASTER-34?page=com.atlassian.jira.plugin... ]
George Gastaldi commented on ROASTER-34:
----------------------------------------
What is wrong with {{org.jboss.forge.roaster.model.source.MethodSource.removeParameter(ParameterSource<O>)}} ?
> Add a method MethodSource.removeParameter(Class<?> aClass, String s)
> --------------------------------------------------------------------
>
> Key: ROASTER-34
> URL: https://issues.jboss.org/browse/ROASTER-34
> Project: Roaster
> Issue Type: Feature Request
> Components: API
> Affects Versions: 2.7.1.Final
> Reporter: Antonio Goncalves
> Fix For: 2.x Future
>
>
> At the moment it's easy to add a parameter to a method knowing its name and type :
> {code}
> property.getMutator().addParameter(LocalDate.class, "myDate");
> {code}
> It would be good to have the same facility to remove a parameter given a type and a name. Something like :
> {code}
> property.getMutator().removeParameter(LocalDate.class, "myDate");
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
9 years, 9 months
[JBoss JIRA] (ROASTER-33) Accessor of type boolean starting with 'is' are not considered accessor
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/ROASTER-33?page=com.atlassian.jira.plugin... ]
George Gastaldi closed ROASTER-33.
----------------------------------
Fix Version/s: (was: 2.x Future)
Resolution: Won't Fix
The {{is}} prefix is used only in boolean primitives, not {{java.lang.Boolean}}, therefore the behavior is correct
> Accessor of type boolean starting with 'is' are not considered accessor
> -----------------------------------------------------------------------
>
> Key: ROASTER-33
> URL: https://issues.jboss.org/browse/ROASTER-33
> Project: Roaster
> Issue Type: Bug
> Affects Versions: 2.7.1.Final
> Reporter: Antonio Goncalves
> Attachments: IsTest.java
>
>
> If I parse a class with a boolean attribute with {{is/set}} instead of {{get/set}}, the accessor is not recognized. I think it's because of the {{AbstractJavaSourceMemberHolder.extractPropertyName}} method :
> {code}
> private String extractPropertyName(Method<O, ?> method)
> {
> if (method.getName().matches("^[gs]et.+$"))
> {
> return Strings.uncapitalize(method.getName().substring(3));
> }
> return null;
> }
> {code}
> I'm attaching a test case that reproduces it if you want
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
9 years, 9 months
[JBoss JIRA] (ROASTER-33) Accessor of type boolean starting with 'is' are not considered accessor
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/ROASTER-33?page=com.atlassian.jira.plugin... ]
George Gastaldi commented on ROASTER-33:
----------------------------------------
Hi [~agoncal],
I noticed that in your test, the {{myBoolean}} attribute is a {{java.lang.Boolean}}, not a primitive boolean though
> Accessor of type boolean starting with 'is' are not considered accessor
> -----------------------------------------------------------------------
>
> Key: ROASTER-33
> URL: https://issues.jboss.org/browse/ROASTER-33
> Project: Roaster
> Issue Type: Bug
> Affects Versions: 2.7.1.Final
> Reporter: Antonio Goncalves
> Fix For: 2.x Future
>
> Attachments: IsTest.java
>
>
> If I parse a class with a boolean attribute with {{is/set}} instead of {{get/set}}, the accessor is not recognized. I think it's because of the {{AbstractJavaSourceMemberHolder.extractPropertyName}} method :
> {code}
> private String extractPropertyName(Method<O, ?> method)
> {
> if (method.getName().matches("^[gs]et.+$"))
> {
> return Strings.uncapitalize(method.getName().substring(3));
> }
> return null;
> }
> {code}
> I'm attaching a test case that reproduces it if you want
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
9 years, 9 months
[JBoss JIRA] (FORGE-2008) Broken history in Forge console
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-2008?page=com.atlassian.jira.plugin... ]
George Gastaldi closed FORGE-2008.
----------------------------------
Labels: (was: respin-b)
Resolution: Done
Upgraded Aesh to 0.56.1
> Broken history in Forge console
> -------------------------------
>
> Key: FORGE-2008
> URL: https://issues.jboss.org/browse/FORGE-2008
> Project: Forge
> Issue Type: Bug
> Components: UI - Shell
> Affects Versions: 2.9.2.Final
> Environment: Windows 7, Eclipse Luna
> Reporter: George Gastaldi
> Assignee: Vineet Reynolds
> Priority: Critical
> Fix For: 2.9.3.Final
>
>
> When I press the up arrow key, instead of seeing the previous entry, I see a strange character {{à}}. Pressing the key multiple times appends more characters to the console, instead of cycling through the history entries multiple times.
> This occurs only on Windows, and not on Linux (Fedora 20) or Mac.
> History appears to be recorded correctly though.
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
9 years, 9 months
[JBoss JIRA] (FORGE-2008) Broken history in Forge console
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-2008?page=com.atlassian.jira.plugin... ]
George Gastaldi moved JBIDE-18311 to FORGE-2008:
------------------------------------------------
Project: Forge (was: Tools (JBoss Tools))
Key: FORGE-2008 (was: JBIDE-18311)
Affects Version/s: 2.9.2.Final
(was: 4.2.0.Beta3)
Component/s: UI - Shell
(was: forge)
Fix Version/s: 2.9.3.Final
(was: 4.2.0.CR1)
> Broken history in Forge console
> -------------------------------
>
> Key: FORGE-2008
> URL: https://issues.jboss.org/browse/FORGE-2008
> Project: Forge
> Issue Type: Bug
> Components: UI - Shell
> Affects Versions: 2.9.2.Final
> Environment: Windows 7, Eclipse Luna
> Reporter: George Gastaldi
> Assignee: Vineet Reynolds
> Priority: Critical
> Labels: respin-b
> Fix For: 2.9.3.Final
>
>
> When I press the up arrow key, instead of seeing the previous entry, I see a strange character {{à}}. Pressing the key multiple times appends more characters to the console, instead of cycling through the history entries multiple times.
> This occurs only on Windows, and not on Linux (Fedora 20) or Mac.
> History appears to be recorded correctly though.
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
9 years, 9 months
[JBoss JIRA] (FORGE-1905) Use Scaffold as a general term for code generation
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-1905?page=com.atlassian.jira.plugin... ]
George Gastaldi commented on FORGE-1905:
----------------------------------------
{quote}
<lincolnthree> gastaldi: btw, -1 on renaming jpa-generate command to scaffold
<lincolnthree> gastaldi: i think scaffold should be renamed to generate probably at some point
<gastaldi> I think there is a JIRA for that
<gastaldi> I also think we have discussed that in the F2F
<lincolnthree> yeah i don't remember which way we went, but i don't really like the term scaffold anymore
<lincolnthree> we should have an official discussion about it probably
<lincolnthree> but not sure we have time for that
<lincolnthree> scaffold meand something very specific
<lincolnthree> gah
<gastaldi> FORGE-1905
<jbossbot> jira [FORGE-1905] Use Scaffold as a general term for code generation [Open (Unresolved) Task, Critical, Unassigned] https://issues.jboss.org/browse/FORGE-1905
<lincolnthree> yeah i think i prefer generate
<lincolnthree> not sure
<gastaldi> ok, let me close this JIRA then and we can discuss later
<lincolnthree> gastaldi: ok
{quote}
> Use Scaffold as a general term for code generation
> --------------------------------------------------
>
> Key: FORGE-1905
> URL: https://issues.jboss.org/browse/FORGE-1905
> Project: Forge
> Issue Type: Task
> Components: Scaffold
> Affects Versions: 2.6.0.Final
> Reporter: George Gastaldi
> Priority: Critical
> Fix For: 2.x Future
>
>
> Scaffold is a term widely used for code generation. It should not be restricted to generating UIs only, so commands that generate code (like REST: Generate Endpoints from Tables) should use this term.
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
9 years, 9 months