[JBoss JIRA] (FORGE-2495) WizardCommandController does not execute all steps when execute is called directly
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-2495?page=com.atlassian.jira.plugin... ]
George Gastaldi closed FORGE-2495.
----------------------------------
Resolution: Done
> WizardCommandController does not execute all steps when execute is called directly
> ----------------------------------------------------------------------------------
>
> Key: FORGE-2495
> URL: https://issues.jboss.org/browse/FORGE-2495
> Project: Forge
> Issue Type: Bug
> Components: UI - API
> Affects Versions: 2.19.2.Final
> Reporter: George Gastaldi
> Assignee: George Gastaldi
> Fix For: 2.20.0.Final
>
>
> The following code does not execute all the steps:
> {code}
> try (WizardCommandController controller = uiTestHarness.createWizardController(JPASetupWizard.class,
> project.getRoot()))
> {
> controller.initialize();
> controller.execute();
> }
> {code}
> That is because {{controller.execute()}} does not call {{refreshFlow()}}. If {{controller.canExecute()}} is called before {{controller.execute()}}, then it works. The solution is to call {{refreshFlow()}} in the {{execute()}} method.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 7 months
[JBoss JIRA] (FORGE-2495) WizardCommandController does not execute all steps when execute is called directly
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-2495?page=com.atlassian.jira.plugin... ]
George Gastaldi reopened FORGE-2495:
------------------------------------
> WizardCommandController does not execute all steps when execute is called directly
> ----------------------------------------------------------------------------------
>
> Key: FORGE-2495
> URL: https://issues.jboss.org/browse/FORGE-2495
> Project: Forge
> Issue Type: Bug
> Components: UI - API
> Affects Versions: 2.19.2.Final
> Reporter: George Gastaldi
> Assignee: George Gastaldi
> Fix For: 2.20.0.Final
>
>
> The following code does not execute all the steps:
> {code}
> try (WizardCommandController controller = uiTestHarness.createWizardController(JPASetupWizard.class,
> project.getRoot()))
> {
> controller.initialize();
> controller.execute();
> }
> {code}
> That is because {{canExecute()}} calls {{refreshFlow()}}. If canExecute is called before execute, then it works. The solution is to call refreshFlow() in the execute() method.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 7 months
[JBoss JIRA] (FORGE-2495) WizardCommandController does not execute all steps when execute is called directly
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-2495?page=com.atlassian.jira.plugin... ]
George Gastaldi closed FORGE-2495.
----------------------------------
Resolution: Done
> WizardCommandController does not execute all steps when execute is called directly
> ----------------------------------------------------------------------------------
>
> Key: FORGE-2495
> URL: https://issues.jboss.org/browse/FORGE-2495
> Project: Forge
> Issue Type: Bug
> Components: UI - API
> Affects Versions: 2.19.2.Final
> Reporter: George Gastaldi
> Assignee: George Gastaldi
> Fix For: 2.20.0.Final
>
>
> The following code does not execute all the steps:
> {code}
> try (WizardCommandController controller = uiTestHarness.createWizardController(JPASetupWizard.class,
> project.getRoot()))
> {
> controller.initialize();
> controller.execute();
> }
> {code}
> That is because {{canExecute()}} calls {{refreshFlow()}}. If canExecute is called before execute, then it works. The solution is to call refreshFlow() in the execute() method.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 7 months
[JBoss JIRA] (FORGE-2495) WizardCommandController does not execute all steps when execute is called directly
by George Gastaldi (JIRA)
George Gastaldi created FORGE-2495:
--------------------------------------
Summary: WizardCommandController does not execute all steps when execute is called directly
Key: FORGE-2495
URL: https://issues.jboss.org/browse/FORGE-2495
Project: Forge
Issue Type: Bug
Components: UI - API
Affects Versions: 2.19.2.Final
Reporter: George Gastaldi
Assignee: George Gastaldi
Fix For: 2.20.0.Final
The following code does not execute all the steps:
{code}
try (WizardCommandController controller = uiTestHarness.createWizardController(JPASetupWizard.class,
project.getRoot()))
{
controller.initialize();
controller.execute();
}
{code}
That is because {{canExecute()}} calls {{refreshFlow()}}. If canExecute is called before execute, then it works. The solution is to call refreshFlow() in the execute() method.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 7 months
[JBoss JIRA] (FORGE-2484) java-new-enum-const should follow the naming convention
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-2484?page=com.atlassian.jira.plugin... ]
George Gastaldi reassigned FORGE-2484:
--------------------------------------
Assignee: George Gastaldi
> java-new-enum-const should follow the naming convention
> -------------------------------------------------------
>
> Key: FORGE-2484
> URL: https://issues.jboss.org/browse/FORGE-2484
> Project: Forge
> Issue Type: Sub-task
> Components: Java EE
> Affects Versions: 2.19.1.Final
> Reporter: Antonio Goncalves
> Assignee: George Gastaldi
> Priority: Minor
> Fix For: 2.x Future
>
>
> At the moment to add a new constant to an enum we type :
> {code}
> java-new-enum-const VISA ;
> {code}
> To follow the other commands, it should have a {{named}} parameter
> {code}
> java-new-enum-const --named VISA ;
> java-new-enum-const --named MASTER_CARD ;
> java-new-enum-const --named AMERICAN_EXPRESS ;
> {code}
> Changing {{new}} to {{add}} we could end up with :
> {code}
> java-add-enum-const --named VISA ;
> java-add-enum-const --named MASTER_CARD ;
> java-add-enum-const --named AMERICAN_EXPRESS ;
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 7 months
[JBoss JIRA] (FORGE-2484) java-new-enum-const should follow the naming convention
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-2484?page=com.atlassian.jira.plugin... ]
George Gastaldi commented on FORGE-2484:
----------------------------------------
[~agoncal], could you review the PR?
> java-new-enum-const should follow the naming convention
> -------------------------------------------------------
>
> Key: FORGE-2484
> URL: https://issues.jboss.org/browse/FORGE-2484
> Project: Forge
> Issue Type: Sub-task
> Components: Java EE
> Affects Versions: 2.19.1.Final
> Reporter: Antonio Goncalves
> Priority: Minor
> Fix For: 2.x Future
>
>
> At the moment to add a new constant to an enum we type :
> {code}
> java-new-enum-const VISA ;
> {code}
> To follow the other commands, it should have a {{named}} parameter
> {code}
> java-new-enum-const --named VISA ;
> java-new-enum-const --named MASTER_CARD ;
> java-new-enum-const --named AMERICAN_EXPRESS ;
> {code}
> Changing {{new}} to {{add}} we could end up with :
> {code}
> java-add-enum-const --named VISA ;
> java-add-enum-const --named MASTER_CARD ;
> java-add-enum-const --named AMERICAN_EXPRESS ;
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 7 months
[JBoss JIRA] (FORGE-2484) java-new-enum-const should follow the naming convention
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-2484?page=com.atlassian.jira.plugin... ]
George Gastaldi updated FORGE-2484:
-----------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/forge/core/pull/586
> java-new-enum-const should follow the naming convention
> -------------------------------------------------------
>
> Key: FORGE-2484
> URL: https://issues.jboss.org/browse/FORGE-2484
> Project: Forge
> Issue Type: Sub-task
> Components: Java EE
> Affects Versions: 2.19.1.Final
> Reporter: Antonio Goncalves
> Priority: Minor
> Fix For: 2.x Future
>
>
> At the moment to add a new constant to an enum we type :
> {code}
> java-new-enum-const VISA ;
> {code}
> To follow the other commands, it should have a {{named}} parameter
> {code}
> java-new-enum-const --named VISA ;
> java-new-enum-const --named MASTER_CARD ;
> java-new-enum-const --named AMERICAN_EXPRESS ;
> {code}
> Changing {{new}} to {{add}} we could end up with :
> {code}
> java-add-enum-const --named VISA ;
> java-add-enum-const --named MASTER_CARD ;
> java-add-enum-const --named AMERICAN_EXPRESS ;
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 7 months
[JBoss JIRA] (FORGE-2494) when composing commands from other commands we need to be able to hide inputs in the base command
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-2494?page=com.atlassian.jira.plugin... ]
George Gastaldi updated FORGE-2494:
-----------------------------------
Fix Version/s: 2.x Future
> when composing commands from other commands we need to be able to hide inputs in the base command
> -------------------------------------------------------------------------------------------------
>
> Key: FORGE-2494
> URL: https://issues.jboss.org/browse/FORGE-2494
> Project: Forge
> Issue Type: Feature Request
> Components: Brainstorming, UI - API
> Reporter: James Strachan
> Fix For: 2.x Future
>
>
> right now in fabric8-forge for creating new projects; we reuse the project-new command; but we've added a hack to override the targetLocation property; so that the user doesn't' get to pick that - we want to hide that completely from the user. Meanwhile the project-new-git logical wrapper command defaults this value, uses a canonical temporary folder and then stores the new project in git (instead of a local file system on the developers laptop).
> It would be good to port this code to be pure vanilla forge commands that could be reused from the CLI / eclipse / IDEA too. To do this we'd need to be able to wrap the project-new command with a project-new-git command that then hides the input for the "targetLocation" property (defaulting the value so that the inner project-new command can work as before; then the outer command, project-new-git can do the git thingy.
> I've not had chance to experiment a way to do this nicely; maybe using a proxy command or something and using a temporary UIBuilder class that we pass to the delegate inner command to build its stuff; so that the outer command can remove things from the real UIBuilder etc - but I figured it'd be nice for this kind of thing to be a standard feature to make commands easier to combine and compose. It'd also make it easier for us to move the project-new-git command back into the main forge project (though I guess thats kinda complex as the project-new-git command would probably want to create a local copy too on the users desktop when not running in a REST service - so maybe this kinda thing is highly environment specific?)
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 7 months
[JBoss JIRA] (FORGE-2494) when composing commands from other commands we need to be able to hide inputs in the base command
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-2494?page=com.atlassian.jira.plugin... ]
George Gastaldi updated FORGE-2494:
-----------------------------------
Component/s: Brainstorming
UI - API
> when composing commands from other commands we need to be able to hide inputs in the base command
> -------------------------------------------------------------------------------------------------
>
> Key: FORGE-2494
> URL: https://issues.jboss.org/browse/FORGE-2494
> Project: Forge
> Issue Type: Feature Request
> Components: Brainstorming, UI - API
> Reporter: James Strachan
> Fix For: 2.x Future
>
>
> right now in fabric8-forge for creating new projects; we reuse the project-new command; but we've added a hack to override the targetLocation property; so that the user doesn't' get to pick that - we want to hide that completely from the user. Meanwhile the project-new-git logical wrapper command defaults this value, uses a canonical temporary folder and then stores the new project in git (instead of a local file system on the developers laptop).
> It would be good to port this code to be pure vanilla forge commands that could be reused from the CLI / eclipse / IDEA too. To do this we'd need to be able to wrap the project-new command with a project-new-git command that then hides the input for the "targetLocation" property (defaulting the value so that the inner project-new command can work as before; then the outer command, project-new-git can do the git thingy.
> I've not had chance to experiment a way to do this nicely; maybe using a proxy command or something and using a temporary UIBuilder class that we pass to the delegate inner command to build its stuff; so that the outer command can remove things from the real UIBuilder etc - but I figured it'd be nice for this kind of thing to be a standard feature to make commands easier to combine and compose. It'd also make it easier for us to move the project-new-git command back into the main forge project (though I guess thats kinda complex as the project-new-git command would probably want to create a local copy too on the users desktop when not running in a REST service - so maybe this kinda thing is highly environment specific?)
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 7 months
[JBoss JIRA] (FORGE-2492) forge hangs on AbstractProjectCommand.getSelectedProject() when used inside fabric8-forge (the REST service)
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-2492?page=com.atlassian.jira.plugin... ]
George Gastaldi closed FORGE-2492.
----------------------------------
Fix Version/s: 2.20.0.Final
Assignee: George Gastaldi
Resolution: Partially Completed
Closing this issue as partially completed, as it now provides a way to log Wagon transfer events
> forge hangs on AbstractProjectCommand.getSelectedProject() when used inside fabric8-forge (the REST service)
> ------------------------------------------------------------------------------------------------------------
>
> Key: FORGE-2492
> URL: https://issues.jboss.org/browse/FORGE-2492
> Project: Forge
> Issue Type: Feature Request
> Affects Versions: 2.17.0.Final, 2.19.2.Final
> Environment: using the fabric8-forge docker image inside OpenShift
> Reporter: James Strachan
> Assignee: George Gastaldi
> Fix For: 2.20.0.Final
>
>
> Here's a stack trace:
> https://gist.github.com/jstrachan/741d65b7dd87ca0e701e
> when using Forge from the hawtio console, the JVM seems to hang for 1-2 minutes now inside the call to AbstractProjectCommand.getSelectedProject(). Whats odd is I can create an archetype and invoke this code path on startup just fine - but then thats in a different thread to the one using Forge from inside the JAXRS service; so am wondering if its related to which thread is being used?
> Seems to ultimately be a wagon / aether issue; taking too long to download things.
> Wonder is there any way to configure the maven addon in forge to register a Wagon listener maybe? No idea whats causing the pause
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 7 months