[JBoss JIRA] (FORGE-2246) Refactoring the JPA Commands
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-2246?page=com.atlassian.jira.plugin... ]
George Gastaldi updated FORGE-2246:
-----------------------------------
Status: Closed (was: Pull Request Sent)
Fix Version/s: 2.15.1.Final
(was: 2.x Future)
(was: 3.x Future)
Resolution: Done
> Refactoring the JPA Commands
> ----------------------------
>
> Key: FORGE-2246
> URL: https://issues.jboss.org/browse/FORGE-2246
> Project: Forge
> Issue Type: Sub-task
> Components: UI - API
> Reporter: Antonio Goncalves
> Assignee: Antonio Goncalves
> Priority: Minor
> Fix For: 2.15.1.Final
>
>
> The idea is to refactor the JPA commands (under {{org.jboss.forge.addon.javaee.jpa.ui}}) :
> * Add an interface with all the default sub-packages in {{javaee-api}}
> ** Interface {{org.jboss.forge.addon.javaee.JavaEEPackages}}
> ** Something like {{BUSINESS_MODEL}} would be {{model}}
> ** {{BUSINESS_LOGIC}} would be {{service}}
> ** {{EXCEPTIONS}} would be {{exception}}
> * Create a new {{org.jboss.forge.addon.javaee.jpa.ui.AbstractJPACommand}} that extends {{AbstractJavaEECommand}} and implements {{PrerequisiteCommandsProvider}}
> ** {{getMetadata}} By adding JPA (and this way each command will be "Java EE / JPA / New Embeddable"
> ** {{isProjectRequired}}
> ** {{getPrerequisiteCommands}}
> ** Add a method {{calculateDefaultPackage}}
> * Refactor the classes
> ** They extend from {{AbstractJPACommand}}
> ** Rename them by prefixing them with {{JPA}}
> *** {{NewEmbeddableCommand}} -> {{JPANewEmbeddableCommand}}
> *** {{NewEntityCommand}} -> {{JPANewEntityCommand}}
> *** ...
> Questions : some classes redifine {{named}} and {{targetPackage}} some don't, why ? :
> {code}
> @Inject
> @WithAttributes(label = "Entity name", description = "The simple name of the generated class", required = true)
> private UIInput<String> named;
> @Inject
> @WithAttributes(label = "Target package", type = InputType.JAVA_PACKAGE_PICKER)
> private UIInput<String> targetPackage;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 1 month
[JBoss JIRA] (FORGE-2268) allow wizards in the CLI to let the user configure non-required inputs
by James Strachan (JIRA)
[ https://issues.jboss.org/browse/FORGE-2268?page=com.atlassian.jira.plugin... ]
James Strachan commented on FORGE-2268:
---------------------------------------
Is this something that'd be enabled in the CLI provider itself; or something we could add as an option inside the camel commands? If the latter, any pointers on examples I could use to try it out?
> allow wizards in the CLI to let the user configure non-required inputs
> ----------------------------------------------------------------------
>
> Key: FORGE-2268
> URL: https://issues.jboss.org/browse/FORGE-2268
> Project: Forge
> Issue Type: Feature Request
> Reporter: James Strachan
>
> we're creating wizards for creating new camel components and endpoints. Pretty much all of these have a large number of possible input properties. However most of them are not required.
> I've hacked a multi-page wizard; the 2nd page adds all the non-required inputs to the builder. The CLI then ignores them all and accepts the default values ;)
> It would be nice if there a way prompt the user with something like...
> {code}
> Would you like to change any of the 12 inputs [Yn]:
> Y
> [1] foo
> [2] bar
> ...
> [12] thingy...
> 2
> enter the value for property bar with default value [123] :
> 456
> property bar set to 456
> Would you like to change any of the 12 inputs [Yn]:
> (repeat until n)
> {code}
> i.e. folks can just hit an extra enter to not bother entering any values, or they can keep hitting 'y' then picking the number of the input to change, then the value and enter
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 1 month
[JBoss JIRA] (FORGE-2268) allow wizards in the CLI to let the user configure non-required inputs
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-2268?page=com.atlassian.jira.plugin... ]
George Gastaldi commented on FORGE-2268:
----------------------------------------
I think we can introduce this behavior by creating a {{UICommandTransformer}} (maybe activate through a flag, not sure).
> allow wizards in the CLI to let the user configure non-required inputs
> ----------------------------------------------------------------------
>
> Key: FORGE-2268
> URL: https://issues.jboss.org/browse/FORGE-2268
> Project: Forge
> Issue Type: Feature Request
> Reporter: James Strachan
>
> we're creating wizards for creating new camel components and endpoints. Pretty much all of these have a large number of possible input properties. However most of them are not required.
> I've hacked a multi-page wizard; the 2nd page adds all the non-required inputs to the builder. The CLI then ignores them all and accepts the default values ;)
> It would be nice if there a way prompt the user with something like...
> {code}
> Would you like to change any of the 12 inputs [Yn]:
> Y
> [1] foo
> [2] bar
> ...
> [12] thingy...
> 2
> enter the value for property bar with default value [123] :
> 456
> property bar set to 456
> Would you like to change any of the 12 inputs [Yn]:
> (repeat until n)
> {code}
> i.e. folks can just hit an extra enter to not bother entering any values, or they can keep hitting 'y' then picking the number of the input to change, then the value and enter
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 1 month
[JBoss JIRA] (FORGE-2268) allow wizards in the CLI to let the user configure non-required inputs
by James Strachan (JIRA)
[ https://issues.jboss.org/browse/FORGE-2268?page=com.atlassian.jira.plugin... ]
James Strachan commented on FORGE-2268:
---------------------------------------
BTW there's a CDI and Spring based "new-camel-component-(cdi|spring)" depending on if you run forge in a spring based or CDI based example project.
https://github.com/fabric8io/fabric8/tree/master/forge-addons/camel/src/m...
Here's a sample camel / CDI project to use if you want...
https://github.com/fabric8io/example-camel-cdi
unfortunately the camel forge plugin requires a snapshot of Apache Camel; hopefully next week there'll be released version/milestone to avoid you having to build that (as it takes hours ;)
> allow wizards in the CLI to let the user configure non-required inputs
> ----------------------------------------------------------------------
>
> Key: FORGE-2268
> URL: https://issues.jboss.org/browse/FORGE-2268
> Project: Forge
> Issue Type: Feature Request
> Reporter: James Strachan
>
> we're creating wizards for creating new camel components and endpoints. Pretty much all of these have a large number of possible input properties. However most of them are not required.
> I've hacked a multi-page wizard; the 2nd page adds all the non-required inputs to the builder. The CLI then ignores them all and accepts the default values ;)
> It would be nice if there a way prompt the user with something like...
> {code}
> Would you like to change any of the 12 inputs [Yn]:
> Y
> [1] foo
> [2] bar
> ...
> [12] thingy...
> 2
> enter the value for property bar with default value [123] :
> 456
> property bar set to 456
> Would you like to change any of the 12 inputs [Yn]:
> (repeat until n)
> {code}
> i.e. folks can just hit an extra enter to not bother entering any values, or they can keep hitting 'y' then picking the number of the input to change, then the value and enter
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 1 month
[JBoss JIRA] (FORGE-2268) allow wizards in the CLI to let the user configure non-required inputs
by James Strachan (JIRA)
James Strachan created FORGE-2268:
-------------------------------------
Summary: allow wizards in the CLI to let the user configure non-required inputs
Key: FORGE-2268
URL: https://issues.jboss.org/browse/FORGE-2268
Project: Forge
Issue Type: Feature Request
Reporter: James Strachan
we're creating wizards for creating new camel components and endpoints. Pretty much all of these have a large number of possible input properties. However most of them are not required.
I've hacked a multi-page wizard; the 2nd page adds all the non-required inputs to the builder. The CLI then ignores them all and accepts the default values ;)
It would be nice if there a way prompt the user with something like...
{code}
Would you like to change any of the 12 inputs [Yn]:
Y
[1] foo
[2] bar
...
[12] thingy...
2
enter the value for property bar with default value [123] :
456
property bar set to 456
Would you like to change any of the 12 inputs [Yn]:
(repeat until n)
{code}
i.e. folks can just hit an extra enter to not bother entering any values, or they can keep hitting 'y' then picking the number of the input to change, then the value and enter
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 1 month
[JBoss JIRA] (FORGEPLUGINS-151) Forge OpenShift plugin hangs when creating a JBoss app in Windows
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGEPLUGINS-151?page=com.atlassian.jira.... ]
George Gastaldi closed FORGEPLUGINS-151.
----------------------------------------
Resolution: Won't Fix
See the comments in FORGEPLUGINS-148
> Forge OpenShift plugin hangs when creating a JBoss app in Windows
> -----------------------------------------------------------------
>
> Key: FORGEPLUGINS-151
> URL: https://issues.jboss.org/browse/FORGEPLUGINS-151
> Project: Forge Plugins/Addons
> Issue Type: Bug
> Components: OpenShift Plugin
> Environment: Window7
> Git-1.8.3-preview2013.6.1 jdk-7u25-windows-x64
> Reporter: nan wei
> Assignee: William DeCoste
>
> Description of problem:
> When creating a jboss app, app creation process hang there.
> Version:
> forge-distribution-1.3.3.Final.zip
> Window7
> Git-1.8.3-preview2013.6.1 jdk-7u25-windows-x64
> How reproducible:
> always
> Steps to Reproduce:
> 1. Ensure that you have already installed a Java 6+ JDK.
> 1.1 install jdk-7u25-windows-x64
> 1.2 set JAVA_HOME.
> 2. Download Forge 1.3.2.Final and Un-zip Forge into a folder on your hard-disk, this folder will be your FORGE_HOME.
> 2.1 Add '$FORGE_HOME/bin' to your windows path.
> 2.2 installing Git(Git-1.8.3-preview2013.6.1)
> 3. Open a command prompt and run 'forge.bat'.
> 4. Install OpenShift plugin for forge.
> 5. create a jboss app.
> Actual results:
> [forge-openshift-demo] forge-openshift-demo $ rhc setup
> ***INFO*** Loaded OpenShift configuration from C:\Users\nanwei/.openshift/expres
> s.conf
> ? Enter the application name [forgeopenshiftd] [forgeopenshiftd] wsy
> ***INFO*** Using RHLOGIN:nwei for https://10.4.59.171
> ? Enter your Red Hat Openshift password: ******
> ***INFO*** Found OpenShift User: nwei
> Choose a JBoss Cartridge:
>
> 1 - [Cartridge [name=jbosseap-6.0]]*
> 2 - [Cartridge [name=jbossews-2.0]]
> 3 - [Cartridge [name=jbossews-1.0]]
>
> ? Choose an option by typing the number of the selection [*-default] [0] 1
> ***INFO*** Using JBoss Cartridge: jbosseap-6.0
> Initialized empty Git repository in C:/Users/nanwei/Downloads/forge/bin/forge-op
> enshift-demo/.git/
> ***INFO*** Waiting for OpenShift to propagate DNS
> ***INFO*** Trying to contact http://forge-nweidomain.osetestv2.com/ (attempt 1 of
> 500)
> Updating openshift
> Expected results:
> The process will hang there for ever.
> Additional info:
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 1 month
[JBoss JIRA] (FORGEPLUGINS-148) Got java runtime exception "unknow request parameter type integer" when run rhc setup in forge shell
by Wenjing Zheng (JIRA)
[ https://issues.jboss.org/browse/FORGEPLUGINS-148?page=com.atlassian.jira.... ]
Wenjing Zheng commented on FORGEPLUGINS-148:
--------------------------------------------
George, according to the email you sent me: Given the 'rhc' tools have improved significantly, and the quickstart experience on openshift is pretty decent, joined with the great support in JBoss Developer Studio, we decided to drop support on the Openshift plugin, since we felt it is no longer useful and also given that we don't have enough resources to keep it up with the latest Openshift enhancements", you are free to close this bug as wont fix. Thanks for your great help!
> Got java runtime exception "unknow request parameter type integer" when run rhc setup in forge shell
> ----------------------------------------------------------------------------------------------------
>
> Key: FORGEPLUGINS-148
> URL: https://issues.jboss.org/browse/FORGEPLUGINS-148
> Project: Forge Plugins/Addons
> Issue Type: Bug
> Components: OpenShift Plugin
> Environment: JDK 1.7.0_45 & git 1.8.0
> windows 7& fedora 19
> Reporter: weiweijiang jiang
> Priority: Blocker
>
> when rhc setup in forge shell, it got java runtime error message "unknow request parameter type integer".
> And according to https://bugzilla.redhat.com/show_bug.cgi?id=1020283#c1 the issue has been fixed in client version pre-2.4.0, but the forge-plugin-openshift still use client version 2.0.1
> [no project] forge-distribution-1.4.2.Final $ forge find-plugin openshift
> Connecting to remote repository [https://raw.github.com/forge/plugin-repository/
> master/repository.yaml]... connected!
> - openshift (com.redhat.openshift:forge-openshift-plugin:::)
> Author: Pete Muir <pmuir(a)redhat.com>
> Website: http://openshift.com
> Location: https://github.com/forge/plugin-openshift.git
> Tags: cloud, openshift, redhat, jboss, deploy, rhc
> Description: Plugins for creating cloud instances, managing existing clo
> uds, and deploying applications to the Red Hat express cloud.
> And the following is https://raw.github.com/forge/plugin-openshift/master/pom.xml
> <?xml version="1.0" encoding="UTF-8"?>
> <project
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"
> xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
> <modelVersion>4.0.0</modelVersion>
> <groupId>com.redhat.openshift</groupId>
> <artifactId>forge-openshift-plugin</artifactId>
> <version>1.0.6.Final</version>
> <properties>
> <forge.api.version>1.0.6.Final</forge.api.version>
> <jgit.version>2.0.0.201206130900-r</jgit.version>
> <log4j.extras.version>1.1</log4j.extras.version>
> <openshift.client.version>2.0.1</openshift.client.version>
> <jsch.version>0.1.48</jsch.version>
> </properties>
> ...
> <build>
> <finalName>forge-openshift-plugin</finalName>
> <plugins>
> <plugin>
> <artifactId>maven-compiler-plugin</artifactId>
> <version>2.3.2</version>
> <configuration>
> <source>1.6</source>
> <target>1.6</target>
> </configuration>
> </plugin>
> </plugins>
> </build>
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 1 month
[JBoss JIRA] (FORGE-2246) Refactoring the JPA Commands
by Antonio Goncalves (JIRA)
[ https://issues.jboss.org/browse/FORGE-2246?page=com.atlassian.jira.plugin... ]
Antonio Goncalves updated FORGE-2246:
-------------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/forge/core/pull/544
> Refactoring the JPA Commands
> ----------------------------
>
> Key: FORGE-2246
> URL: https://issues.jboss.org/browse/FORGE-2246
> Project: Forge
> Issue Type: Sub-task
> Components: UI - API
> Reporter: Antonio Goncalves
> Assignee: Antonio Goncalves
> Priority: Minor
> Fix For: 2.x Future, 3.x Future
>
>
> The idea is to refactor the JPA commands (under {{org.jboss.forge.addon.javaee.jpa.ui}}) :
> * Add an interface with all the default sub-packages in {{javaee-api}}
> ** Interface {{org.jboss.forge.addon.javaee.JavaEEPackages}}
> ** Something like {{BUSINESS_MODEL}} would be {{model}}
> ** {{BUSINESS_LOGIC}} would be {{service}}
> ** {{EXCEPTIONS}} would be {{exception}}
> * Create a new {{org.jboss.forge.addon.javaee.jpa.ui.AbstractJPACommand}} that extends {{AbstractJavaEECommand}} and implements {{PrerequisiteCommandsProvider}}
> ** {{getMetadata}} By adding JPA (and this way each command will be "Java EE / JPA / New Embeddable"
> ** {{isProjectRequired}}
> ** {{getPrerequisiteCommands}}
> ** Add a method {{calculateDefaultPackage}}
> * Refactor the classes
> ** They extend from {{AbstractJPACommand}}
> ** Rename them by prefixing them with {{JPA}}
> *** {{NewEmbeddableCommand}} -> {{JPANewEmbeddableCommand}}
> *** {{NewEntityCommand}} -> {{JPANewEntityCommand}}
> *** ...
> Questions : some classes redifine {{named}} and {{targetPackage}} some don't, why ? :
> {code}
> @Inject
> @WithAttributes(label = "Entity name", description = "The simple name of the generated class", required = true)
> private UIInput<String> named;
> @Inject
> @WithAttributes(label = "Target package", type = InputType.JAVA_PACKAGE_PICKER)
> private UIInput<String> targetPackage;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 1 month