[JBoss JIRA] (FORGE-2765) Introduce a method in DependencyFacet to add a dependency to the <dependencyManagement> and <dependencies> sections
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-2765?page=com.atlassian.jira.plugin... ]
George Gastaldi updated FORGE-2765:
-----------------------------------
Description:
{{DependencyFacet.addDirectManagedDependency}} adds the dependency to the {{dependencyManagement}} section.
We should either:
a) Change this method to add to dependencyManagement AND dependency sections
b) Create a new method in {{DependencyFacet}} to do that
was:DependencyFacet.addDirectManagedDependency should add the dependency to the {{<dependencyManagement>}} and {{<dependencies>}} section in the pom.xml. Right now it adds only to the {{dependencyManagement}} section
> Introduce a method in DependencyFacet to add a dependency to the <dependencyManagement> and <dependencies> sections
> -------------------------------------------------------------------------------------------------------------------
>
> Key: FORGE-2765
> URL: https://issues.jboss.org/browse/FORGE-2765
> Project: Forge
> Issue Type: Feature Request
> Components: Build Tools - Maven, Dependencies, Facets
> Affects Versions: 3.7.2.Final
> Reporter: Charles Heidemann
> Priority: Minor
>
> {{DependencyFacet.addDirectManagedDependency}} adds the dependency to the {{dependencyManagement}} section.
> We should either:
> a) Change this method to add to dependencyManagement AND dependency sections
> b) Create a new method in {{DependencyFacet}} to do that
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 6 months
[JBoss JIRA] (FORGE-2765) Introduce a method in DependencyFacet to add a dependency to the <dependencyManagement> and <dependencies> sections
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-2765?page=com.atlassian.jira.plugin... ]
George Gastaldi updated FORGE-2765:
-----------------------------------
Summary: Introduce a method in DependencyFacet to add a dependency to the <dependencyManagement> and <dependencies> sections (was: DependencyFacet.addDirectManagedDependency does not work as intended in the Javadoc)
> Introduce a method in DependencyFacet to add a dependency to the <dependencyManagement> and <dependencies> sections
> -------------------------------------------------------------------------------------------------------------------
>
> Key: FORGE-2765
> URL: https://issues.jboss.org/browse/FORGE-2765
> Project: Forge
> Issue Type: Feature Request
> Components: Build Tools - Maven, Dependencies, Facets
> Affects Versions: 3.7.2.Final
> Reporter: Charles Heidemann
> Priority: Minor
>
> DependencyFacet.addDirectManagedDependency should add the dependency to the {{<dependencyManagement>}} and {{<dependencies>}} section in the pom.xml. Right now it adds only to the {{dependencyManagement}} section
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 6 months
[JBoss JIRA] (FORGE-2765) DependencyFacet.addDirectManagedDependency does not work as intended in the Javadoc
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-2765?page=com.atlassian.jira.plugin... ]
George Gastaldi updated FORGE-2765:
-----------------------------------
Description: DependencyFacet.addDirectManagedDependency should add the dependency to the {{<dependencyManagement>}} and {{<dependencies>}} section in the pom.xml. Right now it adds only to the {{dependencyManagement}} section (was: DependencyFacet.addManagedDependency(POM_DEPENDENCY);
Should be adding a pair of ManagedDependency/Dependency not just a ManagedDependency.
OR
DependencyFacet should be have a method like this DependencyFacet.addDependency(POM_DEPENDENCY)
to add a Dependency based on a ManagedDependency)
> DependencyFacet.addDirectManagedDependency does not work as intended in the Javadoc
> -----------------------------------------------------------------------------------
>
> Key: FORGE-2765
> URL: https://issues.jboss.org/browse/FORGE-2765
> Project: Forge
> Issue Type: Feature Request
> Components: Facets
> Affects Versions: 3.7.2.Final
> Reporter: Charles Heidemann
> Priority: Minor
>
> DependencyFacet.addDirectManagedDependency should add the dependency to the {{<dependencyManagement>}} and {{<dependencies>}} section in the pom.xml. Right now it adds only to the {{dependencyManagement}} section
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 6 months
[JBoss JIRA] (FORGE-2765) DependencyFacet.addDirectManagedDependency does not work as intended in the Javadoc
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-2765?page=com.atlassian.jira.plugin... ]
George Gastaldi updated FORGE-2765:
-----------------------------------
Summary: DependencyFacet.addDirectManagedDependency does not work as intended in the Javadoc (was: DependencyFacet miss a method addDependency or addManagedDependency should be add Dependncy and ManagedDependency)
> DependencyFacet.addDirectManagedDependency does not work as intended in the Javadoc
> -----------------------------------------------------------------------------------
>
> Key: FORGE-2765
> URL: https://issues.jboss.org/browse/FORGE-2765
> Project: Forge
> Issue Type: Feature Request
> Components: Facets
> Affects Versions: 3.7.2.Final
> Reporter: Charles Heidemann
> Priority: Minor
>
> DependencyFacet.addManagedDependency(POM_DEPENDENCY);
> Should be adding a pair of ManagedDependency/Dependency not just a ManagedDependency.
> OR
> DependencyFacet should be have a method like this DependencyFacet.addDependency(POM_DEPENDENCY)
> to add a Dependency based on a ManagedDependency
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 6 months
[JBoss JIRA] (FORGE-2765) DependencyFacet miss a method addDependency or addManagedDependency should be add Dependncy and ManagedDependency
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-2765?page=com.atlassian.jira.plugin... ]
George Gastaldi edited comment on FORGE-2765 at 10/10/17 12:03 AM:
-------------------------------------------------------------------
{{DependencyFacet}} has {{addDirectDependency(Dependency)}}, {{addManagedDependency}} and {{addDirectManagedDependency}}.
Can you elaborate more? Maybe add an example
was (Author: gastaldi):
`DependencyFacet` has `addDirectDependency(Dependency)`, `addManagedDependency` and `addDirectManagedDependency`.
Can you elaborate more? Maybe add an example
> DependencyFacet miss a method addDependency or addManagedDependency should be add Dependncy and ManagedDependency
> -----------------------------------------------------------------------------------------------------------------
>
> Key: FORGE-2765
> URL: https://issues.jboss.org/browse/FORGE-2765
> Project: Forge
> Issue Type: Feature Request
> Components: Facets
> Affects Versions: 3.7.2.Final
> Reporter: Charles Heidemann
> Priority: Minor
>
> DependencyFacet.addManagedDependency(POM_DEPENDENCY);
> Should be adding a pair of ManagedDependency/Dependency not just a ManagedDependency.
> OR
> DependencyFacet should be have a method like this DependencyFacet.addDependency(POM_DEPENDENCY)
> to add a Dependency based on a ManagedDependency
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 6 months
[JBoss JIRA] (FORGE-2765) DependencyFacet miss a method addDependency or addManagedDependency should be add Dependncy and ManagedDependency
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-2765?page=com.atlassian.jira.plugin... ]
George Gastaldi commented on FORGE-2765:
----------------------------------------
`DependencyFacet` has `addDirectDependency(Dependency)`, `addManagedDependency` and `addDirectManagedDependency`.
Can you elaborate more? Maybe add an example
> DependencyFacet miss a method addDependency or addManagedDependency should be add Dependncy and ManagedDependency
> -----------------------------------------------------------------------------------------------------------------
>
> Key: FORGE-2765
> URL: https://issues.jboss.org/browse/FORGE-2765
> Project: Forge
> Issue Type: Feature Request
> Components: Facets
> Affects Versions: 3.7.2.Final
> Reporter: Charles Heidemann
> Priority: Minor
>
> DependencyFacet.addManagedDependency(POM_DEPENDENCY);
> Should be adding a pair of ManagedDependency/Dependency not just a ManagedDependency.
> OR
> DependencyFacet should be have a method like this DependencyFacet.addDependency(POM_DEPENDENCY)
> to add a Dependency based on a ManagedDependency
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 6 months