[ https://issues.jboss.org/browse/ROASTER-127?page=com.atlassian.jira.plugi... ]
George Gastaldi closed ROASTER-127.
-----------------------------------
Fix Version/s: 2.20.2.Final
Resolution: Done
> Interface without package in the qualified name
> -----------------------------------------------
>
> Key: ROASTER-127
> URL: https://issues.jboss.org/browse/ROASTER-127
> Project: Roaster
> Issue Type: Bug
> Affects Versions: 2.20.0.Final
> Reporter: Marco Rizzi
> Assignee: Marco Rizzi
> Priority: Major
> Fix For: 2.20.2.Final
>
>
> I have the interface
> {code:java}
> package com.foo.forge;
> public interface MyInterface {}
> {code}
> and the class
> {code:java}
> package com.foo.forge;
> public class MockClass implements MyInterface {}
> {code}
> so they're in the same package .
> The [org.jboss.forge.roaster.model.InterfaceCapable#getInterfaces|https://gith...] method returns only the value {{MyInterface}} instead of {{com.foo.forge.MyInterface}}.
> I created a fix for this together with a test in the linked PR https://github.com/forge/roaster/pull/78
> Thanks,
> Marco
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
[ https://issues.jboss.org/browse/ROASTER-127?page=com.atlassian.jira.plugi... ]
Marco Rizzi updated ROASTER-127:
--------------------------------
Description:
I have the interface
{code:java}
package com.foo.forge;
public interface MyInterface {}
{code}
and the class
{code:java}
package com.foo.forge;
public class MockClass implements MyInterface {}
{code}
so they're in the same package .
The [org.jboss.forge.roaster.model.InterfaceCapable#getInterfaces|https://gith...] method returns only the value {{MyInterface}} instead of {{com.foo.forge.MyInterface}}.
I created a fix for this together with a test in the linked PR https://github.com/forge/roaster/pull/78
Thanks,
Marco
was:
I have the interface
{code:java}
package com.foo.forge;
public interface MyInterface {}
{code}
and the class
{code:java}
package com.foo.forge;
public class MockClass implements MyInterface {}
{code}
so they're in the same package .
The [org.jboss.forge.roaster.model.InterfaceCapable#getInterfaces|https://gith...] method returns only the value {{MyInterface}} instead of {{com.foo.forge.MyInterface}}.
I create a fix for this together with a test for this in my fork https://github.com/mrizzi/roaster/tree/interfaces_fix
If you think it's something good to be fixed, i'm more than happy about creating a PR.
Thanks,
Marco
> Interface without package in the qualified name
> -----------------------------------------------
>
> Key: ROASTER-127
> URL: https://issues.jboss.org/browse/ROASTER-127
> Project: Roaster
> Issue Type: Bug
> Affects Versions: 2.20.0.Final
> Reporter: Marco Rizzi
> Assignee: Marco Rizzi
> Priority: Major
>
> I have the interface
> {code:java}
> package com.foo.forge;
> public interface MyInterface {}
> {code}
> and the class
> {code:java}
> package com.foo.forge;
> public class MockClass implements MyInterface {}
> {code}
> so they're in the same package .
> The [org.jboss.forge.roaster.model.InterfaceCapable#getInterfaces|https://gith...] method returns only the value {{MyInterface}} instead of {{com.foo.forge.MyInterface}}.
> I created a fix for this together with a test in the linked PR https://github.com/forge/roaster/pull/78
> Thanks,
> Marco
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
[ https://issues.jboss.org/browse/ROASTER-127?page=com.atlassian.jira.plugi... ]
Marco Rizzi updated ROASTER-127:
--------------------------------
Status: Pull Request Sent (was: Coding In Progress)
Git Pull Request: https://github.com/forge/roaster/pull/78
> Interface without package in the qualified name
> -----------------------------------------------
>
> Key: ROASTER-127
> URL: https://issues.jboss.org/browse/ROASTER-127
> Project: Roaster
> Issue Type: Bug
> Affects Versions: 2.20.0.Final
> Reporter: Marco Rizzi
> Assignee: Marco Rizzi
> Priority: Major
>
> I have the interface
> {code:java}
> package com.foo.forge;
> public interface MyInterface {}
> {code}
> and the class
> {code:java}
> package com.foo.forge;
> public class MockClass implements MyInterface {}
> {code}
> so they're in the same package .
> The [org.jboss.forge.roaster.model.InterfaceCapable#getInterfaces|https://gith...] method returns only the value {{MyInterface}} instead of {{com.foo.forge.MyInterface}}.
> I create a fix for this together with a test for this in my fork https://github.com/mrizzi/roaster/tree/interfaces_fix
> If you think it's something good to be fixed, i'm more than happy about creating a PR.
> Thanks,
> Marco
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
[ https://issues.jboss.org/browse/ROASTER-127?page=com.atlassian.jira.plugi... ]
Work on ROASTER-127 started by Marco Rizzi.
-------------------------------------------
> Interface without package in the qualified name
> -----------------------------------------------
>
> Key: ROASTER-127
> URL: https://issues.jboss.org/browse/ROASTER-127
> Project: Roaster
> Issue Type: Bug
> Affects Versions: 2.20.0.Final
> Reporter: Marco Rizzi
> Assignee: Marco Rizzi
> Priority: Major
>
> I have the interface
> {code:java}
> package com.foo.forge;
> public interface MyInterface {}
> {code}
> and the class
> {code:java}
> package com.foo.forge;
> public class MockClass implements MyInterface {}
> {code}
> so they're in the same package .
> The [org.jboss.forge.roaster.model.InterfaceCapable#getInterfaces|https://gith...] method returns only the value {{MyInterface}} instead of {{com.foo.forge.MyInterface}}.
> I create a fix for this together with a test for this in my fork https://github.com/mrizzi/roaster/tree/interfaces_fix
> If you think it's something good to be fixed, i'm more than happy about creating a PR.
> Thanks,
> Marco
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
Marco Rizzi created ROASTER-127:
-----------------------------------
Summary: Interface without package in the qualified name
Key: ROASTER-127
URL: https://issues.jboss.org/browse/ROASTER-127
Project: Roaster
Issue Type: Bug
Affects Versions: 2.20.0.Final
Reporter: Marco Rizzi
I have the interface
{code:java}
package com.foo.forge;
public interface MyInterface {}
{code}
and the class
{code:java}
package com.foo.forge;
public class MockClass implements MyInterface {}
{code}
so they're in the same package .
The [org.jboss.forge.roaster.model.InterfaceCapable#getInterfaces|https://gith...] method returns only the value {{MyInterface}} instead of {{com.foo.forge.MyInterface}}.
I create a fix for this together with a test for this in my fork https://github.com/mrizzi/roaster/tree/interfaces_fix
If you think it's something good to be fixed, i'm more than happy about creating a PR.
Thanks,
Marco
--
This message was sent by Atlassian Jira
(v7.12.1#712002)