From jira-events at lists.jboss.org Mon Aug 26 11:55:26 2013 Content-Type: multipart/mixed; boundary="===============9121489807443658731==" MIME-Version: 1.0 From: Lincoln Baxter III (JIRA) To: forge-issues at lists.jboss.org Subject: [forge-issues] [JBoss JIRA] (FORGE-1067) Adopt WebJars as encapsulation for Bootstrap and JQuery resources Date: Mon, 26 Aug 2013 11:55:26 -0400 Message-ID: In-Reply-To: JIRA.12497775.1375367421000@jira02.app.mwc.hst.phx2.redhat.com --===============9121489807443658731== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://issues.jboss.org/browse/FORGE-1067?page=3Dcom.atlassian.jira.= plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D12799268#c= omment-12799268 ] = Lincoln Baxter III commented on FORGE-1067: ------------------------------------------- Hmmm... I'll need to see how some other people/projects feel about this. Th= e difference is that this adds a new external dependency, whereas the origi= nal direct inclusion of bootstrap keeps the dependency local, so that any c= hanges required do not require a release of an artifact that we do not cont= rol :/ I wish I could just say "yes" but the fact is that we have to consider thes= e things when stuff goes into a supported product :( However, this doesn't stop us from doing an unsupported "Much better and ea= sier to use scaffold." Hopefully the popularity of that would increase to t= he point where we can justify supporting it by default. = > Adopt WebJars as encapsulation for Bootstrap and JQuery resources > ----------------------------------------------------------------- > > Key: FORGE-1067 > URL: https://issues.jboss.org/browse/FORGE-1067 > Project: Forge > Issue Type: Enhancement > Components: Scaffold > Affects Versions: 1.3.3.Final > Reporter: Antonio Goncalves > Fix For: 1.x Future > > > At the moment JBoss Forge copies the {{bootstrap.css}} into the resources= directory. It would be nice to use WebJar [1] to package Bootstrap (and JQ= uery) into the war file. = > For this to happen you just need to add the following Maven dependencies = to the {{pom.xml}} : > {code} > > org.webjars > bootstrap > 2.3.2 > > > org.webjars > jquery > 2.0.3 > > {code} > Then, change the {{pageTemplate.xhtml}} so it looks like this : = > {code} > > xmlns:h=3D"http://java.sun.com/jsf/html" > xmlns:ui=3D"http://java.sun.com/jsf/facelets"> > > #{empty pageTitle ? '{#pageTitle}' : pageTitle} > > > > > > ... > ... > ... > > > > > > > {code} > And of course, get rid of the {{bootstrap.css}} file ;o) > [1] http://www.webjars.org/ > [1] http://www.jamesward.com/2012/10/31/webjars-officially-launched > See also : https://issues.jboss.org/browse/RF-12584 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrato= rs For more information on JIRA, see: http://www.atlassian.com/software/jira --===============9121489807443658731==--