[
https://issues.jboss.org/browse/FORGE-1067?page=com.atlassian.jira.plugin...
]
Lincoln Baxter III commented on FORGE-1067:
-------------------------------------------
Hmmm... I'll need to see how some other people/projects feel about this. The
difference is that this adds a new external dependency, whereas the original direct
inclusion of bootstrap keeps the dependency local, so that any changes required do not
require a release of an artifact that we do not control :/
I wish I could just say "yes" but the fact is that we have to consider these
things when stuff goes into a supported product :(
However, this doesn't stop us from doing an unsupported "Much better and easier
to use scaffold." Hopefully the popularity of that would increase to the point where
we can justify supporting it by default.
Adopt WebJars as encapsulation for Bootstrap and JQuery resources
-----------------------------------------------------------------
Key: FORGE-1067
URL:
https://issues.jboss.org/browse/FORGE-1067
Project: Forge
Issue Type: Enhancement
Components: Scaffold
Affects Versions: 1.3.3.Final
Reporter: Antonio Goncalves
Fix For: 1.x Future
At the moment JBoss Forge copies the {{bootstrap.css}} into the resources directory. It
would be nice to use WebJar [1] to package Bootstrap (and JQuery) into the war file.
For this to happen you just need to add the following Maven dependencies to the
{{pom.xml}} :
{code}
<dependency>
<groupId>org.webjars</groupId>
<artifactId>bootstrap</artifactId>
<version>2.3.2</version>
</dependency>
<dependency>
<groupId>org.webjars</groupId>
<artifactId>jquery</artifactId>
<version>2.0.3</version>
</dependency>
{code}
Then, change the {{pageTemplate.xhtml}} so it looks like this :
{code}
<!DOCTYPE html>
<html
xmlns="http://www.w3.org/1999/xhtml"
xmlns:h="http://java.sun.com/jsf/html"
xmlns:ui="http://java.sun.com/jsf/facelets">
<h:head>
<title>#{empty pageTitle ? '{#pageTitle}' : pageTitle}</title>
<link rel="icon"
href="#{resource['favicon.ico']}"/>
<h:outputStylesheet library="webjars/bootstrap/2.3.2/css"
name="bootstrap.min.css"/>
<h:outputStylesheet name="forge-style.css"/>
</h:head>
<h:body>
...
...
...
<!-- Bootstrap core JavaScript
================================================== -->
<!-- Placed at the end of the document so the pages load faster -->
<h:outputScript name="webjars/jquery/2.0.3/jquery.min.js"/>
<h:outputScript library="webjars/bootstrap/2.3.2/js"
name="bootstrap.min.js"/>
</h:body>
</html>
{code}
And of course, get rid of the {{bootstrap.css}} file ;o)
[1]
http://www.webjars.org/
[1]
http://www.jamesward.com/2012/10/31/webjars-officially-launched
See also :
https://issues.jboss.org/browse/RF-12584
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:
http://www.atlassian.com/software/jira