[forge-issues] [JBoss JIRA] (FORGE-1312) UICommand.execute is executed out of sequence when a list of commands or wizards are to be executed
[
https://issues.jboss.org/browse/FORGE-1312?page=com.atlassian.jira.plugin...
]
Vineet Reynolds commented on FORGE-1312:
----------------------------------------
I've taken a look at this, and the current behaviour boils down to this bit of code in
the {{FinishJob}} inner class in the {{ForgeWizard}} class:
{noformat}
for (IWizardPage wizardPage : getPages()) {
currentCommand = ((ForgeWizardPage) wizardPage)
.getUICommand();
...
Result result = currentCommand.execute(uiContext);
...
}
{noformat}
The order of execution of {{UICommand}}s depends on the order in which the pages are
displayed. In the scaffold setup wizard, the first page to be displayed is the scaffold
setup wizard page, and hence, it is also the first command to be executed even though
other commands (for facet installation) should be executed first.
I think we might need a mechanism to allow addons to dictate the order. At the bare
minimum, I'd prefer that we have some way to ensure that Facet setup UIWizards and
UICommands are executed before others.
UICommand.execute is executed out of sequence when a list of commands
or wizards are to be executed
---------------------------------------------------------------------------------------------------
Key: FORGE-1312
URL: https://issues.jboss.org/browse/FORGE-1312
Project: Forge
Issue Type: Bug
Components: UI - Eclipse
Affects Versions: 2.0.0.Alpha14
Reporter: Vineet Reynolds
Related to FORGE-1131, in the Scaffold setup wizard, I have:
{noformat}
@Override
public Result execute(UIContext context) throws Exception
{
ScaffoldProvider selectedProvider = provider.getValue();
selectedProvider.setup(getSelectedProject(context), createSetupContext());
return Results.success("Scaffold was setup successfully.");
}
{noformat}
This is expected to be executed only after all other setup wizards and commands have been
executed. For example, if the Faces scaffold provider is being setup, then any or all of
CDI, EJB, Servlet, Faces and JPA setup wizards must be executed before
{{ScaffoldSetupWizard.execute()}} is invoked. This is not the case currently, resulting in
{{ScaffoldSetupWizard.execute()}} being invoked first.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira