[JBoss JIRA] (FORGE-501) Faces scaffold creates compilation errors when "id" getter is not called "getId()"
10:10 a.m.
Burr Sutter created FORGE-501:
---------------------------------
Summary: Faces scaffold creates compilation errors when "id" getter
is not called "getId()"
Key: FORGE-501
URL: https://issues.jboss.org/browse/FORGE-501
Project: Forge
Issue Type: Bug
Reporter: Burr Sutter
scaffold from-entity ~.model.* --scaffoldType faces --overwrite
generates an ActorBean.java containing
return "view?faces-redirect=true&id=" + this.actor.getId();
when the Actor.java model has the following
@Id
@Column(name = "ACTOR_ID", unique = true, nullable = false)
public short getActorId() {
return this.actorId;
}
public void setActorId(short actorId) {
this.actorId = actorId;
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:12 a.m.
[
https://issues.jboss.org/browse/FORGE-501?page=com.atlassian.jira.plugin....
]
Burr Sutter updated FORGE-501:
------------------------------
Attachment: Actor.java
ActorBean.java
Faces scaffold creates compilation errors when "id" getter
is not called "getId()"
----------------------------------------------------------------------------------
Key: FORGE-501
URL: https://issues.jboss.org/browse/FORGE-501
Project: Forge
Issue Type: Bug
Reporter: Burr Sutter
Attachments: Actor.java, ActorBean.java
scaffold from-entity ~.model.* --scaffoldType faces --overwrite
generates an ActorBean.java containing
return "view?faces-redirect=true&id=" + this.actor.getId();
when the Actor.java model has the following
@Id
@Column(name = "ACTOR_ID", unique = true, nullable = false)
public short getActorId() {
return this.actorId;
}
public void setActorId(short actorId) {
this.actorId = actorId;
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:30 p.m.
[
https://issues.jboss.org/browse/FORGE-501?page=com.atlassian.jira.plugin....
]
Lincoln Baxter III reassigned FORGE-501:
----------------------------------------
Assignee: Richard Kennard
Hey Richard, could you take a look at this? I'm sure it also pertains to your aerogear
scaffold work.
Thanks so much!
~Lincoln
Faces scaffold creates compilation errors when "id" getter
is not called "getId()"
----------------------------------------------------------------------------------
Key: FORGE-501
URL: https://issues.jboss.org/browse/FORGE-501
Project: Forge
Issue Type: Bug
Reporter: Burr Sutter
Assignee: Richard Kennard
Attachments: Actor.java, ActorBean.java
scaffold from-entity ~.model.* --scaffoldType faces --overwrite
generates an ActorBean.java containing
return "view?faces-redirect=true&id=" + this.actor.getId();
when the Actor.java model has the following
@Id
@Column(name = "ACTOR_ID", unique = true, nullable = false)
public short getActorId() {
return this.actorId;
}
public void setActorId(short actorId) {
this.actorId = actorId;
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:36 p.m.
[
https://issues.jboss.org/browse/FORGE-501?page=com.atlassian.jira.plugin....
]
Lincoln Baxter III reassigned FORGE-501:
----------------------------------------
Assignee: Thomas Frühbeck (was: Richard Kennard)
Thanks Thomas!
Faces scaffold creates compilation errors when "id" getter
is not called "getId()"
----------------------------------------------------------------------------------
Key: FORGE-501
URL: https://issues.jboss.org/browse/FORGE-501
Project: Forge
Issue Type: Bug
Reporter: Burr Sutter
Assignee: Thomas Frühbeck
Attachments: Actor.java, ActorBean.java
scaffold from-entity ~.model.* --scaffoldType faces --overwrite
generates an ActorBean.java containing
return "view?faces-redirect=true&id=" + this.actor.getId();
when the Actor.java model has the following
@Id
@Column(name = "ACTOR_ID", unique = true, nullable = false)
public short getActorId() {
return this.actorId;
}
public void setActorId(short actorId) {
this.actorId = actorId;
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:09 p.m.
[
https://issues.jboss.org/browse/FORGE-501?page=com.atlassian.jira.plugin....
]
Thomas Frühbeck commented on FORGE-501:
---------------------------------------
The current implementation is very consistent and clear regarding the usage of the field
name "id" for the primary key. Although beautiful it mixes three aspects of the
concept of "id": the field name of the primary key, the property name in JPA
queries and the value object in the view.
I shortly evalutated some approaches:
- change the primary key field to "id" independent of the real field name
unfortunately legacy code will break, code generation by reverse engineering will
fail
- use the primary key field throughout the whole application
makes a consistent development view but exposes the inner definitions
- transition from view "id" to the internal real primary key in the managed
bean and el
this seems to be the best solution but causes some "id" vs.
"primaryKey" irritations
Faces scaffold creates compilation errors when "id" getter
is not called "getId()"
----------------------------------------------------------------------------------
Key: FORGE-501
URL: https://issues.jboss.org/browse/FORGE-501
Project: Forge
Issue Type: Bug
Reporter: Burr Sutter
Assignee: Thomas Frühbeck
Attachments: Actor.java, ActorBean.java
scaffold from-entity ~.model.* --scaffoldType faces --overwrite
generates an ActorBean.java containing
return "view?faces-redirect=true&id=" + this.actor.getId();
when the Actor.java model has the following
@Id
@Column(name = "ACTOR_ID", unique = true, nullable = false)
public short getActorId() {
return this.actorId;
}
public void setActorId(short actorId) {
this.actorId = actorId;
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:43 a.m.
[
https://issues.jboss.org/browse/FORGE-501?page=com.atlassian.jira.plugin....
]
Thomas Frühbeck commented on FORGE-501:
---------------------------------------
sent pull request: https://shadogray@github.com/shadogray/core.git
Faces scaffold creates compilation errors when "id" getter
is not called "getId()"
----------------------------------------------------------------------------------
Key: FORGE-501
URL: https://issues.jboss.org/browse/FORGE-501
Project: Forge
Issue Type: Bug
Reporter: Burr Sutter
Assignee: Thomas Frühbeck
Attachments: Actor.java, ActorBean.java
scaffold from-entity ~.model.* --scaffoldType faces --overwrite
generates an ActorBean.java containing
return "view?faces-redirect=true&id=" + this.actor.getId();
when the Actor.java model has the following
@Id
@Column(name = "ACTOR_ID", unique = true, nullable = false)
public short getActorId() {
return this.actorId;
}
public void setActorId(short actorId) {
this.actorId = actorId;
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:45 a.m.
[
https://issues.jboss.org/browse/FORGE-501?page=com.atlassian.jira.plugin....
]
Thomas Frühbeck updated FORGE-501:
----------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://shadogray@github.com/shadogray/core.git
Faces scaffold creates compilation errors when "id" getter
is not called "getId()"
----------------------------------------------------------------------------------
Key: FORGE-501
URL: https://issues.jboss.org/browse/FORGE-501
Project: Forge
Issue Type: Bug
Reporter: Burr Sutter
Assignee: Thomas Frühbeck
Attachments: Actor.java, ActorBean.java
scaffold from-entity ~.model.* --scaffoldType faces --overwrite
generates an ActorBean.java containing
return "view?faces-redirect=true&id=" + this.actor.getId();
when the Actor.java model has the following
@Id
@Column(name = "ACTOR_ID", unique = true, nullable = false)
public short getActorId() {
return this.actorId;
}
public void setActorId(short actorId) {
this.actorId = actorId;
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:45 a.m.
[
https://issues.jboss.org/browse/FORGE-501?page=com.atlassian.jira.plugin....
]
Thomas Frühbeck updated FORGE-501:
----------------------------------
Status: Pull Request Sent (was: Pull Request Sent)
Git Pull Request: https://github.com/forge/core/pull/125 (was:
https://shadogray@github.com/shadogray/core.git)
Faces scaffold creates compilation errors when "id" getter
is not called "getId()"
----------------------------------------------------------------------------------
Key: FORGE-501
URL: https://issues.jboss.org/browse/FORGE-501
Project: Forge
Issue Type: Bug
Reporter: Burr Sutter
Assignee: Thomas Frühbeck
Attachments: Actor.java, ActorBean.java
scaffold from-entity ~.model.* --scaffoldType faces --overwrite
generates an ActorBean.java containing
return "view?faces-redirect=true&id=" + this.actor.getId();
when the Actor.java model has the following
@Id
@Column(name = "ACTOR_ID", unique = true, nullable = false)
public short getActorId() {
return this.actorId;
}
public void setActorId(short actorId) {
this.actorId = actorId;
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:03 a.m.
[
https://issues.jboss.org/browse/FORGE-501?page=com.atlassian.jira.plugin....
]
Lincoln Baxter III updated FORGE-501:
-------------------------------------
Status: Resolved (was: Pull Request Sent)
Fix Version/s: 1.0.1.Final
Resolution: Done
Awesome, thomas! Max / Burr, could you please try this out!?
Faces scaffold creates compilation errors when "id" getter
is not called "getId()"
----------------------------------------------------------------------------------
Key: FORGE-501
URL: https://issues.jboss.org/browse/FORGE-501
Project: Forge
Issue Type: Bug
Reporter: Burr Sutter
Assignee: Thomas Frühbeck
Fix For: 1.0.1.Final
Attachments: Actor.java, ActorBean.java
scaffold from-entity ~.model.* --scaffoldType faces --overwrite
generates an ActorBean.java containing
return "view?faces-redirect=true&id=" + this.actor.getId();
when the Actor.java model has the following
@Id
@Column(name = "ACTOR_ID", unique = true, nullable = false)
public short getActorId() {
return this.actorId;
}
public void setActorId(short actorId) {
this.actorId = actorId;
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:17 p.m.
[
https://issues.jboss.org/browse/FORGE-501?page=com.atlassian.jira.plugin....
]
Lincoln Baxter III closed FORGE-501.
------------------------------------
Faces scaffold creates compilation errors when "id" getter
is not called "getId()"
----------------------------------------------------------------------------------
Key: FORGE-501
URL: https://issues.jboss.org/browse/FORGE-501
Project: Forge
Issue Type: Bug
Reporter: Burr Sutter
Assignee: Thomas Frühbeck
Fix For: 1.0.1.Final
Attachments: Actor.java, ActorBean.java
scaffold from-entity ~.model.* --scaffoldType faces --overwrite
generates an ActorBean.java containing
return "view?faces-redirect=true&id=" + this.actor.getId();
when the Actor.java model has the following
@Id
@Column(name = "ACTOR_ID", unique = true, nullable = false)
public short getActorId() {
return this.actorId;
}
public void setActorId(short actorId) {
this.actorId = actorId;
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4675
days inactive
4685
days old
9 comments
3 participants
participants (3)
-
Burr Sutter (JIRA) -
Lincoln Baxter III (JIRA)
-
Thomas Frühbeck (JIRA)