Error when creating JPA Entity due to validation gap on target package input ---------------------------------------------------------------------------- Key: FORGE-1473 URL: https://issues.jboss.org/browse/FORGE-1473 Project: Forge Issue Type: Enhancement Security Level: Public(Everyone can see) Components: Builtin Plugins Affects Versions: 2.0.0.CR1 Reporter: Lincoln Baxter III Assignee: George Gastaldi Fix For: 2.7.2.Final "jpa-new-entity --named Customer --targetPackage org.rewrite.double.param.model" Specifically causes this command to crash because the java reserved word "double" appears in the target package. Validation of java packages should have caught this. {code} java.lang.IllegalArgumentException at org.eclipse.jdt.core.dom.SimpleName.setIdentifier(SimpleName.java:194) at org.eclipse.jdt.core.dom.AST.newSimpleName(AST.java:2045) at org.eclipse.jdt.core.dom.AST.newName(AST.java:1795) at org.jboss.forge.parser.java.impl.AbstractJavaSource.setPackage(AbstractJavaSource.java:528) at org.jboss.forge.parser.java.impl.AbstractJavaSource.setPackage(AbstractJavaSource.java:55) at org.jboss.forge.addon.javaee.jpa.PersistenceOperations.createJavaClass(PersistenceOperations.java:148) at org.jboss.forge.addon.javaee.jpa.PersistenceOperations.newEntity(PersistenceOperations.java:114) at org.jboss.forge.addon.javaee.jpa.ui.NewEntityCommand.execute(NewEntityCommand.java:153) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at org.jboss.forge.furnace.proxy.ClassLoaderInterceptor$1.call(ClassLoaderInterceptor.java:59) at org.jboss.forge.furnace.util.ClassLoaders.executeIn(ClassLoaders.java:34) at org.jboss.forge.furnace.proxy.ClassLoaderInterceptor.invoke(ClassLoaderInterceptor.java:75) at org.jboss.forge.addon.javaee.jpa.ui.NewEntityCommand_$$_javassist_cca46d3f-e79c-43dd-a2be-381ec65640a6.execute(NewEntityCommand_$$_javassist_cca46d3f-e79c-43dd-a2be-381ec65640a6.java) at org.jboss.forge.addon.ui.impl.controller.SingleCommandControllerImpl.execute(SingleCommandControllerImpl.java:92) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at org.jboss.forge.furnace.proxy.ClassLoaderAdapterCallback$1.call(ClassLoaderAdapterCallback.java:102) at org.jboss.forge.furnace.util.ClassLoaders.executeIn(ClassLoaders.java:34) at org.jboss.forge.furnace.proxy.ClassLoaderAdapterCallback.invoke(ClassLoaderAdapterCallback.java:75) at org.jboss.forge.addon.ui.controller.CommandController_$$_javassist_4d9a25ee-cc1c-432b-9e9d-bbb27a9ac16e.execute(CommandController_$$_javassist_4d9a25ee-cc1c-432b-9e9d-bbb27a9ac16e.java) at org.jboss.tools.forge.ui.ext.wizards.ForgeWizard$1.run(ForgeWizard.java:81) at org.eclipse.jface.operation.ModalContext.runInCurrentThread(ModalContext.java:464) at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:372) at org.eclipse.jface.wizard.WizardDialog.run(WizardDialog.java:1028) at org.jboss.tools.forge.ui.ext.wizards.ForgeWizard.performFinish(ForgeWizard.java:71) at org.eclipse.jface.wizard.WizardDialog.finishPressed(WizardDialog.java:827) at org.eclipse.jface.wizard.WizardDialog.buttonPressed(WizardDialog.java:432) at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Dialog.java:628) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:248) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84) at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4166) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1466) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1489) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1474) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1279) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4012) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3651) at org.eclipse.jface.window.Window.runEventLoop(Window.java:826) at org.eclipse.jface.window.Window.open(Window.java:802) at org.jboss.tools.forge.ui.ext.dialog.WizardDialogHelper.openWizard(WizardDialogHelper.java:141) at org.jboss.tools.forge.ui.ext.dialog.UICommandListDialog$1$1.handleElementSelected(UICommandListDialog.java:161) at org.jboss.tools.forge.ui.ext.quickaccess.QuickAccessContents.handleSelection(QuickAccessContents.java:326) at org.jboss.tools.forge.ui.ext.quickaccess.QuickAccessContents.access$0(QuickAccessContents.java:316) at org.jboss.tools.forge.ui.ext.quickaccess.QuickAccessContents$1.keyPressed(QuickAccessContents.java:347) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:167) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84) at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4166) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1466) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1489) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1474) at org.eclipse.swt.widgets.Widget.sendKeyEvent(Widget.java:1503) at org.eclipse.swt.widgets.Text.sendKeyEvent(Text.java:1632) at org.eclipse.swt.widgets.Widget.sendKeyEvent(Widget.java:1499) at org.eclipse.swt.widgets.Text.sendKeyEvent(Text.java:1598) at org.eclipse.swt.widgets.Control.doCommandBySelector(Control.java:1060) at org.eclipse.swt.widgets.Display.windowProc(Display.java:5648) at org.eclipse.swt.internal.cocoa.OS.objc_msgSendSuper(Native Method) at org.eclipse.swt.widgets.Widget.callSuper(Widget.java:221) at org.eclipse.swt.widgets.Widget.superKeyDown(Widget.java:1907) at org.eclipse.swt.widgets.Widget.keyDown(Widget.java:1085) at org.eclipse.swt.widgets.Control.keyDown(Control.java:2400) at org.eclipse.swt.widgets.Display.windowProc(Display.java:5558) at org.eclipse.swt.internal.cocoa.OS.objc_msgSendSuper(Native Method) at org.eclipse.swt.widgets.Widget.callSuper(Widget.java:221) at org.eclipse.swt.widgets.Widget.windowSendEvent(Widget.java:2104) at org.eclipse.swt.widgets.Shell.windowSendEvent(Shell.java:2318) at org.eclipse.swt.widgets.Display.windowProc(Display.java:5620) at org.eclipse.swt.internal.cocoa.OS.objc_msgSendSuper(Native Method) at org.eclipse.swt.widgets.Display.applicationSendEvent(Display.java:5057) at org.eclipse.swt.widgets.Display.applicationProc(Display.java:5206) at org.eclipse.swt.internal.cocoa.OS.objc_msgSend(Native Method) at org.eclipse.swt.internal.cocoa.NSApplication.sendEvent(NSApplication.java:128) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3648) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1113) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:997) at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:138) at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:610) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:567) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150) at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:124) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:354) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:181) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:636) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:591) at org.eclipse.equinox.launcher.Main.run(Main.java:1450) at org.eclipse.equinox.launcher.Main.main(Main.java:1426) {code}