[ https://issues.jboss.org/browse/FORGE-460?page=com.atlassian.jira.plugin.... ] Pete Muir commented on FORGE-460: --------------------------------- For example, see ticket-monster example -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/FORGE-460?page=com.atlassian.jira.plugin.... ] Richard Kennard commented on FORGE-460: --------------------------------------- Yeah, you'll need that installed. But even then it won't work. The Metawidget module for RichFaces is turned off at the moment. I need to figure out how to test it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/FORGE-460?page=com.atlassian.jira.plugin.... ] Richard Kennard updated FORGE-460: ---------------------------------- Status: Pull Request Sent (was: Open) Git Pull Request: https://github.com/forge/core/pull/94 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/FORGE-460?page=com.atlassian.jira.plugin.... ] Lincoln Baxter III updated FORGE-460: ------------------------------------- Status: Resolved (was: Pull Request Sent) Fix Version/s: 1.0.0.CR1 Resolution: Done Please verify. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/FORGE-460?page=com.atlassian.jira.plugin.... ] Pete Muir commented on FORGE-460: --------------------------------- I'm not seeing this working right now. The project, is, as ever at https://github.com/mbogoevici/ticket-monster-1/ - run the admin_layer.fsh script. Use the develop branch *not master*. Give Marius a kick for using gitflow ;-) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/FORGE-460?page=com.atlassian.jira.plugin.... ] Richard Kennard updated FORGE-460: ---------------------------------- Status: Pull Request Sent (was: Reopened) Git Pull Request: https://github.com/forge/core/pull/94 (was: https://github.com/forge/core/pull/94) Sorry. I was (stupidly) expecting you to call 'richfaces setup' before 'scaffold setup'. Try again now? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/FORGE-460?page=com.atlassian.jira.plugin.... ] Pete Muir commented on FORGE-460: --------------------------------- Specifically, look at the table - the add icon and the RF calendar icon overlap. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/FORGE-460?page=com.atlassian.jira.plugin.... ] Lincoln Baxter III commented on FORGE-460: ------------------------------------------ Why is it stupid to expect that one would call richfaces setup? Shouldn't that be required if you want richfaces functionality? PS. Nice job richard! -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/FORGE-460?page=com.atlassian.jira.plugin.... ] Lincoln Baxter III commented on FORGE-460: ------------------------------------------ Got it. Very nice. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/FORGE-460?page=com.atlassian.jira.plugin.... ] Richard Kennard edited comment on FORGE-460 at 1/31/12 9:07 PM: ---------------------------------------------------------------- Further fixes for: CSS fixes. Adding multiple one-to-many at once. Required field handling. Nested collections. Note we appear to have a bit of an issue with Bean Validation's @NotEmpty. Pete could you please investigate? Basically: 1. Generate the app 2. Cheer how the date pickers no longer overlap 3. Cry because when you go 'Booking->Create New' you get validation errors on the search fields Now, I have already removed JSF's 'required=true' attribute from these fields. So it appears it is Bean Validation doing this. You cannot use 'immediate=true' on the button or else nothing will get POSTed at all. The 'correct' solution, I think, is to add f:validateBean disabled="true" to each of the required fields. I can do this no problem, but it doesn't seem to work (under AS 7.0.2.Final). Example: 1. Add 'f:validateBean disabled=true' to 'h:inputText id="bookingBeanSearchCancellationCode"' and 'h:inputText id="bookingBeanSearchContactEmail"' in 'booking/search.xhtml' 2. Go to the search screen and click 'Create New'. Works! Hurrah! 3. Go back to the search screen and click 'Search' and then 'Create New'. Now it fails. It appears f:validateBean does not survive POST-back? Is this a bug? Even if this *did* work, a bad side effect is that all validation is disabled for these fields. So for example it no longer validates the e-mail address format. We can probably live with that on the search screens, but it may be unacceptable on the one-to-many 'add' fields (where this is also a problem). Suggestions? was (Author: kennardconsulting): Further fixes for: CSS fixes. Adding multiple one-to-many at once. Required field handling. Nested collections. Note we appear to have a bit of an issue with Bean Validation's @NotEmpty. Pete could you please investigate? Basically: 1. Generate the app 2. Cheer how the date pickers no longer overlap 3. Cry because when you go 'Booking->Create New' you get validation errors on the search fields Now, I have already removed JSF's 'required=true' attribute from these fields. So it appears it is Bean Validation doing this. You cannot use 'immediate=true' on the button or else nothing will get POSTed at all. The 'correct' solution, I think, is to add f:validateBean disabled="true" to each of the required fields. I can do this no problem, but it doesn't seem to work. Example: 1. Add 'f:validateBean disabled=true' to 'h:inputText id="bookingBeanSearchCancellationCode"' and 'h:inputText id="bookingBeanSearchContactEmail"' in 'booking/search.xhtml' 2. Go to the search screen and click 'Create New'. Works! Hurrah! 3. Go back to the search screen and click 'Search' and then 'Create New'. Now it fails. It appears f:validateBean does not survive POST-back? Is this a bug? Even if this *did* work, a bad side effect is that all validation is disabled for these fields. So for example it no longer validates the e-mail address format. We can probably live with that on the search screens, but it may be unacceptable on the one-to-many 'add' fields (where this is also a problem). Suggestions? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/FORGE-460?page=com.atlassian.jira.plugin.... ] Richard Kennard commented on FORGE-460: --------------------------------------- Okay, I tried that and it works! Validation groups has the enormous advantage that... <f:validateBean validationGroups="..."/> ...does not get 'forgotten' on POST-back the way... <f:validateBean disabled="true"/> ...does (I'm pretty sure that's a bug). However I'm not sure where we go from here? A validation group isn't just a name, it's an actual interface. So we'd have to supply a UI-specific interface that people put on their domain model. That seems kind of icky. However it works well enough once you do that. So perhaps we leave this one alone, and if people encounter it tell them to add a group into their domain model? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/FORGE-460?page=com.atlassian.jira.plugin.... ] Emmanuel Bernard commented on FORGE-460: ---------------------------------------- I don't see it as a UI specific group, it's more a specific group dedicated to your search business component and the fact that you reuse a domain model to store the search data (I don't think that's bad but it mixes some concerns). Following me? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/FORGE-460?page=com.atlassian.jira.plugin.... ] Emmanuel Bernard commented on FORGE-460: ---------------------------------------- also note that most constraints won't be much useful assuming the search engine is flexible. I could look for `manuel` in the email field to find all people having the manuel string in their email. `manuel` is not an email per se. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/FORGE-460?page=com.atlassian.jira.plugin.... ] Richard Kennard updated FORGE-460: ---------------------------------- Attachment: emmanuel.zip Minimal test case -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/FORGE-460?page=com.atlassian.jira.plugin.... ] Emmanuel Bernard commented on FORGE-460: ---------------------------------------- Yes that's definitely a bug. I'd bet in the JSF engine. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/FORGE-460?page=com.atlassian.jira.plugin.... ] Richard Kennard commented on FORGE-460: --------------------------------------- Okay, opened as: https://issues.jboss.org/browse/AS7-3621 I guess FORGE-460 will remain in limbo until that's resolved? Pete can you please assign to Stan? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/FORGE-460?page=com.atlassian.jira.plugin.... ] Richard Kennard updated FORGE-460: ---------------------------------- Status: Resolved (was: Pull Request Sent) Resolution: Done Sounds good to me! -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira