[
https://issues.jboss.org/browse/ROASTER-13?page=com.atlassian.jira.plugin...
]
Matej Briskar edited comment on ROASTER-13 at 5/14/14 9:37 AM:
---------------------------------------------------------------
The return value check is done in the getMutator() method but not in the isMutator()
method.. There probably is a reason, why isMutator() is checking if the method is
generally a mutator but is not checking, if it is the mutator of the current field, where
the method was called.
Therefore there are 2 options to resolve this issue:
1) Follow the approach and add the same check to getAccessor() method for the returning
type.
2) Change both, isAccessor() and isMutator() to contain this check of the return
type/parameter type.
Following the 1) approach, it then doesn't make sense why the isMutator() method is
defined in the PropertyImpl then, or does it?
was (Author: mbriskar):
The return value check is done in the getMutator() method but not in isMutator() method..
There probably is a reason, why isMutator() is checking if the method is generally a
mutator but is not checking, if it is the mutator of the current field, where the method
was called.
Therefore there are 2 options to resolve this issue:
1) Follow the approach and add the same check to getAccessor() method for the returning
type.
2) Change both, isAccessor() and isMutator() to contain this check of the return
type/parameter type.
Following the 1) approach, it then doesn't make sense why the isMutator() method is
defined in the PropertyImpl then, or does it?
PropertyImpl is not checking return type/parameter type in
isAccessor() isMutator() methods
-------------------------------------------------------------------------------------------
Key: ROASTER-13
URL:
https://issues.jboss.org/browse/ROASTER-13
Project: Roaster
Issue Type: Bug
Reporter: Matej Briskar
Assignee: Matej Briskar
--
This message was sent by Atlassian JIRA
(v6.2.3#6260)