[
https://issues.jboss.org/browse/FORGE-440?page=com.atlassian.jira.plugin....
]
Lennart Jörelid edited comment on FORGE-440 at 6/24/13 9:00 PM:
----------------------------------------------------------------
But we could possibly add API calls to Forge which inserts comments - say *before* an
element.
I do agree that the Maven core treats its model in ... uhm ... interesting ways, but one
could claim that a tool ridding all POMs of comments is difficult (at best) to use or
introduce
when dealing with larger POMs.
... because such POMs need to be commented quite a bit to provide some means of
explaining
*why* some plugins/configuration/properties are present. For instance, a huge parent pom
such as
https://bitbucket.org/lennartj/nazgul_tools/src/4c72405abda254318338c0527...
needs its comments - or the usability of it is reduced even further. If Forge squashes the
comments, it is basically impossible to use Forge in any project that values its comments
in POMs.
was (Author: lennartj):
But we could possibly add API calls to Forge which inserts comments - say *before* an
element.
I do agree that the Maven core treats its model in ... uhm ... interesting ways, but one
could claim that a tool ridding all POMs of comments is difficult (at best) to use or
introduce
when dealing with larger POMs.
... because such POMs need to be commented quite a bit to provide some means of
explaining
*why* some plugins/configuration/properties are present in a parent pom.
For instance, a huge parent pom such as
https://bitbucket.org/lennartj/nazgul_tools/src/4c72405abda254318338c0527...
needs its comments - or the usability of it is reduced even further. If Forge squashes the
comments, it is basically impossible to use Forge in any project that values its comments
in POMs.
A pom.xml which contains comments loses all of them after Forge
operates on it.
-------------------------------------------------------------------------------
Key: FORGE-440
URL:
https://issues.jboss.org/browse/FORGE-440
Project: Forge
Issue Type: Bug
Components: Build Tools - Maven
Affects Versions: 1.0.6.Final
Environment: HEAD
Reporter: Pete Muir
Fix For: 2.x Future
Also looses formatting, but this is less of an issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:
http://www.atlassian.com/software/jira