[
https://issues.jboss.org/browse/FORGE-525?page=com.atlassian.jira.plugin....
]
Jason Porter commented on FORGE-525:
------------------------------------
I've done some more digging.
In the classes DependencyInstallerImpl and DependencyImpl we're not resolving
properties for any of the values on a dependency when we compare them. That needs to
happen, but we can't change the value on the dependency otherwise when it's
written to the pom the property will be gone.You can see in the MavenDependencyFacet how
properties are resolved.
project add-dependency should accept properties
-----------------------------------------------
Key: FORGE-525
URL:
https://issues.jboss.org/browse/FORGE-525
Project: Forge
Issue Type: Enhancement
Components: Maven Integration
Affects Versions: 1.0.2.Final
Reporter: Jason Porter
Attachments: FORGE-525_test.patch
Here's some sample input:
{code}
$ project set-property --name arquillian.version --value 1.0.0.CR6
Set property [arquillian.version=1.0.0.CR6]
$ project add-dependency org.jboss.arquillian:arquillian-bom:::${arquillian.version}
***INFO*** The command [add-dependency] takes [1] unnamed argument(s), but found [2].
***INFO*** Swallowed unknown token [{] for command [add-dependency].
***INFO*** Swallowed unknown token [arquillian.version] for command [add-dependency].
***INFO*** Swallowed unknown token [}] for command [add-dependency].
***INFO*** Could not parse [org.jboss.arquillian:arquillian-bom:::$]... please try
again...
? [[ groupId:artifactId {:version :scope :packaging} ] (of type
org.jboss.forge.project.dependencies.Dependency)]: [killed]
***INFO*** Aborted.
$ project add-dependency
"org.jboss.arquillian:arquillian-bom:::${arquillian.version}"
***INFO*** Could not parse
[org.jboss.arquillian:arquillian-bom:::${arquillian.version}]... please try again...
{code}
Either one of those two should work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see:
http://www.atlassian.com/software/jira