]
Antonio Goncalves updated FORGE-2275:
-------------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request:
Refactor the Java EE Tests with new @AddonDependency
----------------------------------------------------
Key: FORGE-2275
URL:
https://issues.jboss.org/browse/FORGE-2275
Project: Forge
Issue Type: Sub-task
Components: Java EE
Affects Versions: 2.15.1.Final
Reporter: Antonio Goncalves
Assignee: Antonio Goncalves
Fix For: 2.x Future
The JPA / Bean Validation / CDI Tests have recently been strenghten. It is important to
refactor them with new @AddonDependency management (because these tests are used in the
Tutorials and should use the latest dependency management)
Tests should look like this :
https://github.com/forge/core/blob/master/maven/tests/src/test/java/org/j...
There is a command to create tests : {{addon-new-test}}
https://github.com/forge/core/blob/master/addons/impl/src/main/java/org/j...
So the tests go from :
{code}
@Deployment
@AddonDeployments({
@AddonDeployment(name = "org.jboss.forge.addon:ui"),
@AddonDeployment(name = "org.jboss.forge.addon:ui-test-harness"),
@AddonDeployment(name =
"org.jboss.forge.addon:shell-test-harness"),
@AddonDeployment(name = "org.jboss.forge.addon:javaee"),
@AddonDeployment(name = "org.jboss.forge.addon:maven")
})
public static AddonArchive getDeployment()
{
return ShrinkWrap
.create(AddonArchive.class)
.addClass(ProjectHelper.class)
.addBeansXML()
.addAsAddonDependencies(
AddonDependencyEntry.create("org.jboss.forge.furnace.container:cdi"),
AddonDependencyEntry.create("org.jboss.forge.addon:projects"),
AddonDependencyEntry.create("org.jboss.forge.addon:ui"),
AddonDependencyEntry.create("org.jboss.forge.addon:ui-test-harness"),
AddonDependencyEntry.create("org.jboss.forge.addon:shell-test-harness"),
AddonDependencyEntry.create("org.jboss.forge.addon:javaee"),
AddonDependencyEntry.create("org.jboss.forge.addon:maven")
);
}
{code}
To
{code}
@Deployment
@AddonDependencies({
@AddonDependency(name = "org.jboss.forge.addon:ui-test-harness"),
@AddonDependency(name =
"org.jboss.forge.addon:shell-test-harness"),
@AddonDependency(name = "org.jboss.forge.addon:javaee"),
@AddonDependency(name = "org.jboss.forge.addon:maven"),
@AddonDependency(name = "org.jboss.forge.furnace.container:cdi")
})
public static AddonArchive getDeployment()
{
return
ShrinkWrap.create(AddonArchive.class).addBeansXML().addClass(ProjectHelper.class);
}
{code}
But there is still a problem with the setup commands {{JPASetupWizardTest}},
{{RestSetupTest}} and {{WebSocketSetupWizardTest}}