[ https://issues.jboss.org/browse/FORGE-526?page=com.atlassian.jira.plugin.... ] Sandro Sonntag updated FORGE-526: --------------------------------- Git Pull Request: https://github.com/xandrox/core/commit/2dff40d8183a602d96756ef98df72a45de... (was: https://github.com/xandrox/core/commit/2dff40d8183a602d96756ef98df72a45de...) Description: Added consideration of classifiers. With this change its possible add the same artifact with different classifiers. This is very important for GWT appliactions because they need a class and a source jar to compile. With out that the dependency is always overridden and the classifier is ignored. This codesample does not work: Dependency hibernateValidatorSources = DependencyBuilder .create("org.hibernate:hibernate-validator:4.2.0.Final:compile:jar").setClassifier("sources"); Dependency hibernateValidator = DependencyBuilder .create("org.hibernate:hibernate-validator:4.2.0.Final:compile:jar"); installer.install(project, hibernateValidatorSources, hibernateValidatorSources.getScopeTypeEnum()); installer.install(project, hibernateValidator, hibernateValidatorSources.getScopeTypeEnum()); best regards Sandro was: Added consideration of classifiers. With this change its possible add the same artifact with different classifiers. This is very important for GWT appliactions because they need a class and a source jar to compile. With out that the dependency is always overridden and the classifier is ignored. This codesample does not work: Dependency hibernateValidatorSources = DependencyBuilder .create("org.hibernate:hibernate-validator:4.2.0.Final:compile:jar").setClassifier("sources"); Dependency hibernateValidator = DependencyBuilder .create("org.hibernate:hibernate-validator:4.2.0.Final:compile:jar"); installer.install(project, hibernateValidatorSources, hibernateValidatorSources.getScopeTypeEnum()); installer.install(project, hibernateValidatorSources, hibernateValidatorSources.getScopeTypeEnum()); best regards Sandro -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/FORGE-526?page=com.atlassian.jira.plugin.... ] Sandro Sonntag updated FORGE-526: --------------------------------- Git Pull Request: https://github.com/forge/core/pull/148 (was: https://github.com/xandrox/core/commit/2dff40d8183a602d96756ef98df72a45de...) Fixed the pull request -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira