Author: chris.laprun(a)jboss.com
Date: 2012-03-22 06:34:48 -0400 (Thu, 22 Mar 2012)
New Revision: 8629
Modified:
epp/portal/branches/EPP_5_2_Branch/webui/core/src/main/java/org/exoplatform/webui/form/validator/EmailAddressValidator.java
epp/portal/branches/EPP_5_2_Branch/webui/core/src/test/java/org/exoplatform/webui/test/validator/TestWebuiValidator.java
Log:
Bug 804796 - wrong email validation when creating new user: added more tests and prevented
array out of bounds exception.
Modified:
epp/portal/branches/EPP_5_2_Branch/webui/core/src/main/java/org/exoplatform/webui/form/validator/EmailAddressValidator.java
===================================================================
---
epp/portal/branches/EPP_5_2_Branch/webui/core/src/main/java/org/exoplatform/webui/form/validator/EmailAddressValidator.java 2012-03-22
04:41:07 UTC (rev 8628)
+++
epp/portal/branches/EPP_5_2_Branch/webui/core/src/main/java/org/exoplatform/webui/form/validator/EmailAddressValidator.java 2012-03-22
10:34:48 UTC (rev 8629)
@@ -69,7 +69,7 @@
private boolean validateLocalPart(char[] localPart)
{
- if(!Character.isLetter(localPart[0]) ||
!Character.isLetterOrDigit(localPart[localPart.length - 1]))
+ if(localPart.length == 0 || !Character.isLetter(localPart[0]) ||
!Character.isLetterOrDigit(localPart[localPart.length - 1]))
{
return false;
}
@@ -93,7 +93,7 @@
private boolean validateDomainName(char[] domainName)
{
- if(!Character.isLetter(domainName[0]) ||
!Character.isLetterOrDigit(domainName[domainName.length - 1]))
+ if(domainName.length == 0 || !Character.isLetter(domainName[0]) ||
!Character.isLetterOrDigit(domainName[domainName.length - 1]))
{
return false;
}
Modified:
epp/portal/branches/EPP_5_2_Branch/webui/core/src/test/java/org/exoplatform/webui/test/validator/TestWebuiValidator.java
===================================================================
---
epp/portal/branches/EPP_5_2_Branch/webui/core/src/test/java/org/exoplatform/webui/test/validator/TestWebuiValidator.java 2012-03-22
04:41:07 UTC (rev 8628)
+++
epp/portal/branches/EPP_5_2_Branch/webui/core/src/test/java/org/exoplatform/webui/test/validator/TestWebuiValidator.java 2012-03-22
10:34:48 UTC (rev 8629)
@@ -137,6 +137,9 @@
{
Validator validator = new EmailAddressValidator();
assertFalse(expected(validator, "root"));
+ assertFalse(expected(validator, "@"));
+ assertFalse(expected(validator, "foo@"));
+ assertFalse(expected(validator, "@foo"));
assertTrue(expected(validator, "root.gtn(a)exoplatform.com"));
assertTrue(expected(validator,
"root.exo.gtn.portal(a)explatform.biz.edu.vn"));
assertTrue(expected(validator,
"root_exo_gtn_portal(a)explatform-edu.biz.vn"));
Show replies by date