I will try it.

on my side I moved most of the 3rd party dependencies to the (non really used until now) gatein-dep module that is supposed to specify the version for dependencies.

It cleans up gatein from the version used for those 3rd parties, in the parent pom and in the packaging poms for Tomcat and Jetty (and a bit of JBoss AS).

It should contain dependencies that do not vary much over time basically I think we can classify such dependencies in 3 categories:

1/ 3rd party dependencies (like commons-*, slf4j, etc...)
2/ component dependencies onto which our teams have control (gatein components, JCR, etc...)
3/ project dependencies 

Only those of 1/ go in that gatein-dep pom.

For this matter I changed version to 1.1.0-Beta01 (previously 1.0.3-Beta01) and made a release.

I think that the JBoss packaging should leverage it more when they are able to, but I did not dare to touch them.

On Apr 27, 2011, at 5:22 PM, Marko Strukelj wrote:

Committed.

Give it a try ...


On Wed, Apr 27, 2011 at 2:02 PM, Julien Viet <julien@julienviet.com> wrote:
I don't have any but I don't manage much how documentation is handled, perhaps Thomas has some.

On Apr 27, 2011, at 1:58 PM, Marko Strukelj wrote:


I have a fix for this by using maven-jdocbook-plugin 2.3.4. 

It involves moving all the content from 'en' to 'en/en-US'.

Any objections against committing this?



On Tue, Apr 26, 2011 at 8:05 PM, Julien Viet <julien@julienviet.com> wrote:
I assumed we were discussing maven 3 build :-)

On Apr 26, 2011, at 7:56 PM, Marko Strukelj wrote:


If you said it was maven3 related right away, and that it's an example of why we're not yet mandating maven3 this thread would be a lot shorter :)

But I found it as well:

Maybe some newer version of maven-jdocbook-plugin works.


On Tue, Apr 26, 2011 at 7:36 PM, Julien Viet <julien@julienviet.com> wrote:
that's an issue that was first raised by Arnaud Heritier when he tried maven 3 to fully build gatein.

On Apr 26, 2011, at 7:34 PM, Marko Strukelj wrote:

Ok, looks like it's maven3 specific issue ...

Are there any more of these?


On Tue, Apr 26, 2011 at 7:24 PM, Julien Viet <julien@julienviet.com> wrote:
(julien)-(jobs:0)-(~/java/gatein/portal/trunk/docs)
(! 511)-> pwd
/Users/julien/java/gatein/portal/trunk/docs

(julien)-(jobs:0)-(~/java/gatein/portal/trunk/docs)
(! 512)-> ls
pom.xml reference-guide target user-guide

(julien)-(jobs:0)-(~/java/gatein/portal/trunk/docs)
(! 513)-> mvn -v
Apache Maven 3.0.3 (r1075438; 2011-02-28 18:31:09+0100)
Maven home: /Users/julien/java/maven-3.0.3
Java version: 1.6.0_24, vendor: Apple Inc.
Java home: /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home
Default locale: en_US, platform encoding: MacRoman
OS name: "mac os x", version: "10.6.7", arch: "x86_64", family: "mac"

(julien)-(jobs:0)-(~/java/gatein/portal/trunk/docs)
(! 514)-> mvn clean install
[INFO] Scanning for projects...
[WARNING] 
[WARNING] Some problems were encountered while building the effective model for org.gatein.doc:gatein-user-guide-en:jdocbook:3.2.0-Beta01-SNAPSHOT
[WARNING] The expression ${pom.name} is deprecated. Please use ${project.name} instead.
[WARNING] 
[WARNING] Some problems were encountered while building the effective model for org.gatein.doc:gatein-reference-guide-en:jdocbook:3.2.0-Beta01-SNAPSHOT
[WARNING] The expression ${pom.name} is deprecated. Please use ${project.name} instead.
[WARNING] 
[WARNING] Some problems were encountered while building the effective model for org.gatein.doc:docs-aggregator:pom:3.2.0-Beta01-SNAPSHOT
[WARNING] 'build.pluginManagement.plugins.plugin.(groupId:artifactId)' must be unique but found duplicate declaration of plugin org.apache.maven.plugins:maven-javadoc-plugin @ org.gatein:gatein-parent:1.1.0-Beta01, /Users/julien/.m2/repository/org/gatein/gatein-parent/1.1.0-Beta01/gatein-parent-1.1.0-Beta01.pom, line 179, column 17
[WARNING] 'build.pluginManagement.plugins.plugin.(groupId:artifactId)' must be unique but found duplicate declaration of plugin org.apache.maven.plugins:maven-source-plugin @ org.gatein:gatein-parent:1.1.0-Beta01, /Users/julien/.m2/repository/org/gatein/gatein-parent/1.1.0-Beta01/gatein-parent-1.1.0-Beta01.pom, line 190, column 17
[WARNING] The expression ${pom.name} is deprecated. Please use ${project.name} instead.
[WARNING] 
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING] 
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING] 
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Build Order:
[INFO] 
[INFO] GateIn - Portal (docs-aggregator)
[INFO] GateIn User Guide en
[INFO] GateIn Reference Guide en
[INFO]                                                                         
[INFO] ------------------------------------------------------------------------
[INFO] Building GateIn - Portal (docs-aggregator) 3.2.0-Beta01-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO] 
[INFO] --- maven-clean-plugin:2.4.1:clean (default-clean) @ docs-aggregator ---
[INFO] Deleting /Users/julien/java/gatein/portal/trunk/docs/target
[INFO] 
[INFO] --- maven-enforcer-plugin:1.0-beta-1:enforce (enforce-plugin-versions) @ docs-aggregator ---
[WARNING] This rule is not compatible with the current version of Maven. The rule is not able to perform any checks.
[INFO] 
[INFO] --- maven-enforcer-plugin:1.0-beta-1:enforce (enforce-java-version) @ docs-aggregator ---
[INFO] 
[INFO] --- maven-enforcer-plugin:1.0-beta-1:enforce (enforce-maven-version) @ docs-aggregator ---
[INFO] 
[INFO] --- maven-antrun-plugin:1.6:run (compile) @ docs-aggregator ---
[WARNING] Parameter tasks is deprecated, use target instead
[INFO] Executing tasks

main:
     [copy] Warning: /Users/julien/java/gatein/portal/trunk/docs/src/main/webapp/WEB-INF/classes does not exist.
[INFO] Executed tasks
[INFO] 
[INFO] --- maven-source-plugin:2.1.2:jar-no-fork (attach-sources) @ docs-aggregator ---
[INFO] 
[INFO] --- maven-install-plugin:2.3.1:install (default-install) @ docs-aggregator ---
[INFO] Installing /Users/julien/java/gatein/portal/trunk/docs/pom.xml to /Users/julien/.m2/repository/org/gatein/doc/docs-aggregator/3.2.0-Beta01-SNAPSHOT/docs-aggregator-3.2.0-Beta01-SNAPSHOT.pom
[INFO]                                                                         
[INFO] ------------------------------------------------------------------------
[INFO] Building GateIn User Guide en 3.2.0-Beta01-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO] 
[INFO] --- maven-clean-plugin:2.4.1:clean (default-clean) @ gatein-user-guide-en ---
[INFO] Deleting /Users/julien/java/gatein/portal/trunk/docs/user-guide/target
[INFO] 
[INFO] --- maven-enforcer-plugin:1.0-beta-1:enforce (enforce-plugin-versions) @ gatein-user-guide-en ---
[WARNING] This rule is not compatible with the current version of Maven. The rule is not able to perform any checks.
[INFO] 
[INFO] --- maven-enforcer-plugin:1.0-beta-1:enforce (enforce-java-version) @ gatein-user-guide-en ---
[INFO] 
[INFO] --- maven-enforcer-plugin:1.0-beta-1:enforce (enforce-maven-version) @ gatein-user-guide-en ---
[INFO] 
[INFO] --- maven-jdocbook-plugin:2.1.1:resources (default-resources) @ gatein-user-guide-en ---
[INFO] unpacking dependency resource [/Users/julien/.m2/repository/org/gatein/doc/gatein-jdocbook-style/1.0.0-CR2/gatein-jdocbook-style-1.0.0-CR2.jdocbook-style] to staging-dir [/Users/julien/java/gatein/portal/trunk/docs/user-guide/target/docbook/staging]
[INFO] Expanding: /Users/julien/.m2/repository/org/gatein/doc/gatein-jdocbook-style/1.0.0-CR2/gatein-jdocbook-style-1.0.0-CR2.jdocbook-style into /Users/julien/java/gatein/portal/trunk/docs/user-guide/target/docbook/staging
[INFO] 
[INFO] --- maven-jdocbook-plugin:2.1.1:generate (default-generate) @ gatein-user-guide-en ---
Error at xsl:import on line 16 of jar:file:/Users/julien/.m2/repository/org/gatein/doc/gatein-docbook-xslt/1.0.0-CR2/gatein-docbook-xslt-1.0.0-CR2.jar!/xslt/org/gatein/pdf.xsl:
  Malformed URL classpath:/xslt/org/jboss/pdf.xsl(base jar:file:/Users/julien/.m2/repository/org/gatein/doc/gatein-docbook-xslt/1.0.0-CR2/gatein-docbook-xslt-1.0.0-CR2.jar!/xslt/org/gatein/pdf.xsl): unknown protocol: classpath
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] GateIn - Portal (docs-aggregator) ................. SUCCESS [0.861s]
[INFO] GateIn User Guide en .............................. FAILURE [3.285s]
[INFO] GateIn Reference Guide en ......................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 28.398s
[INFO] Finished at: Tue Apr 26 19:23:28 CEST 2011
[INFO] Final Memory: 7M/505M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.jboss.maven.plugins:maven-jdocbook-plugin:2.1.1:generate (default-generate) on project gatein-user-guide-en: XSLT problem: unable to build transformer [null] : Failed to compile stylesheet. 1 error detected. -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :gatein-user-guide-en

(julien)-(jobs:0)-(~/java/gatein/portal/trunk/docs)
(! 515)-> 



On Apr 26, 2011, at 7:15 PM, Marko Strukelj wrote:

Can't reproduce:

C:\devel\gatein-QA\docs>svn update
At revision 6348.

C:\devel\gatein-QA\docs>svn status

C:\devel\gatein-QA\docs>mvn clean install
[INFO] Scanning for projects...
[WARNING]
        Profile with id: 'default' has not been activated.

[INFO] Reactor build order:
[INFO]   GateIn - Portal (docs-aggregator)
[INFO]   GateIn User Guide en
[INFO]   GateIn Reference Guide en

...

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] ------------------------------------------------------------------------
[INFO] GateIn - Portal (docs-aggregator) ..................... SUCCESS [4.614s]
[INFO] GateIn User Guide en .................................. SUCCESS [1:04.173s]
[INFO] GateIn Reference Guide en ............................. SUCCESS [40.761s]
[INFO] ------------------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESSFUL
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 2 minutes 9 seconds
[INFO] Finished at: Tue Apr 26 19:13:21 CEST 2011
[INFO] Final Memory: 51M/418M
[INFO] ------------------------------------------------------------------------



On Tue, Apr 26, 2011 at 6:52 PM, Julien Viet <julien@julienviet.com> wrote:
the jdocbook plugin of the documentation.

On Apr 26, 2011, at 6:46 PM, Marko Strukelj wrote:

What do you execute to get this?

On Tue, Apr 26, 2011 at 5:59 PM, Julien Viet <julien@julienviet.com> wrote:
[ERROR] Failed to execute goal org.jboss.maven.plugins:maven-jdocbook-plugin:2.1.1:generate (default-generate) on project gatein-user-guide-en: XSLT problem: unable to build transformer [null] : Failed to compile stylesheet. 1 error detected. -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.jboss.maven.plugins:maven-jdocbook-plugin:2.1.1:generate (default-generate) on project gatein-user-guide-en: XSLT problem
at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:217)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
at org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:319)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)
at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
Caused by: org.apache.maven.plugin.MojoExecutionException: XSLT problem
at org.jboss.maven.plugins.jdocbook.AbstractDocBookMojo.execute(AbstractDocBookMojo.java:285)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209)
... 19 more
Caused by: org.jboss.jdocbook.xslt.XSLTException: unable to build transformer [null] : Failed to compile stylesheet. 1 error detected.
at org.jboss.jdocbook.xslt.TransformerBuilder.buildTransformer(TransformerBuilder.java:94)
at org.jboss.jdocbook.xslt.TransformerBuilder.buildTransformer(TransformerBuilder.java:78)
at org.jboss.jdocbook.render.impl.BasicRenderer.buildTransformer(BasicRenderer.java:139)
at org.jboss.jdocbook.render.impl.BasicRenderer.performRendering(BasicRenderer.java:119)
at org.jboss.jdocbook.render.impl.BasicRenderer.render(BasicRenderer.java:115)
at org.jboss.maven.plugins.jdocbook.GenerationMojo.process(GenerationMojo.java:117)
at org.jboss.maven.plugins.jdocbook.AbstractDocBookMojo.doExecute(AbstractDocBookMojo.java:250)
at org.jboss.maven.plugins.jdocbook.AbstractDocBookMojo.execute(AbstractDocBookMojo.java:282)
... 21 more
Caused by: javax.xml.transform.TransformerConfigurationException: Failed to compile stylesheet. 1 error detected.
at com.icl.saxon.PreparedStyleSheet.prepare(PreparedStyleSheet.java:136)
at com.icl.saxon.TransformerFactoryImpl.newTemplates(TransformerFactoryImpl.java:127)
at com.icl.saxon.TransformerFactoryImpl.newTransformer(TransformerFactoryImpl.java:79)
at org.jboss.jdocbook.xslt.TransformerBuilder.buildTransformer(TransformerBuilder.java:88)
... 28 more




On Apr 26, 2011, at 5:43 PM, Marko Strukelj wrote:

I’ve done some fixes on the portal build …

I’ve added parent.relativePath to many modules to fix ‘chicken or egg’ problem that caused failures when building from scratch with empty repository, without additional settings.xml. Might be that I just patched up the ‘bugs’, not really fixed them, as the modules involved might have wrong parents set in the first place. But it clean builds now when before it didn’t (using maven3).

Also, in jboss packaging we have a dependency on org.exoplatform.portal:exo.portal.server.jboss.plugin

Looking at the contents of this artifact it’s obvious that it has no effect at all. It contains one conf/portal/configuration.xml file whose content is completely commented out.

This is the only artifact for jboss-as5 and jboss-as6 packaging that depends on exo maven repository - it’s not available in jboss repo.

So I commented it out for both jboss-as5 and jboss-as6 packaging, and it now builds OOTB without having to create settings.xml with repositories definitions.

Also I’d prefer if we mandate maven3 for build. It’s double work to test build for maven2, as well as for maven3, and there’s constant dilemma if someone claims build doesn’t work - what version of maven they used. I see no good reason to maintain compatibility with maven2, when build works perfectly fine with maven3.
There’s the issue of packaging/profiles.xml which has no effect when building with maven3, so currently you have to specify extra settings via CLI. That can be fixed by moving properties into packaging/pom.xml.

- marko


_______________________________________________
gatein-dev mailing list
gatein-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/gatein-dev