I looked at it, it looks fine.

However have you tried to make the new mixin extends the gtn:visible mixin ? I think it would be better as having this mixin would imply to have the visible mixin.

Julien Viet
julienviet.com

On Thursday 30 January 2014 at 15:47, Juraci Paixão Kröhling wrote:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Julien,

On 01/29/2014 08:26 AM, Julien Viet wrote:
to avoid migration issues:

use instead a new mixin node type (let’s call it gtn:visible2)
that extends gtn:visible and adds this new property.

Thanks! In fact, I've added a new mixin named "gtn:restrictAccess",
but I'm not sure I understand what you mean by "extends gtn:visible
and adds this new property".

https://github.com/jpkrohling/gatein-portal/compare/BZ794359-HidePageIfPublicationDateInFuture-squashed#diff-ce6f188607a68a6d2697dd1e79999cbaR148

Also, I guess that the link to the full diff got lost in the thread,
so, here it is:

https://github.com/jpkrohling/gatein-portal/compare/BZ794359-HidePageIfPublicationDateInFuture-squashed

Based on my tests, there's no migration issues anymore, so, I think
the $subj is now outdated, but I'd still like to get a feedback on
whether the feature (and the proposed code to implement it) would be
considered for merging if/when I send this as a PR.

Thanks!
Juca.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCgAGBQJS6mXpAAoJECKM1e+fkPrXasoH/jyq1Gu95g+OctGrZSigbxIA
EM0K6TB8YQk1jvDmOxmWN215S7cxmkF0Zj3bdmfzFP3znSAzR13daHuuISCtIDv8
8mu69A5RDCwEuDNJK7TYLkIUmztY13LySluiLFRcvUNecdxsucDsioELX1nch5Tb
KTGxwP15J8Y5Vp9P6nHxvtUafbA17rymCi2Zo3vSQRkxJjRbahs21IrKas3UywsS
DwqcF8rUauKKD10uoBD+8WRSc7zGjoVFopUWyPaSer5uOS8PqUcfsVns7fOLAlvg
ycNQ21329XIrLHzVnkrvkFZZnYjcDIAk1jCs+/49EX7XmvfjN4esGHDoO7TMHQs=
=cgXK
-----END PGP SIGNATURE-----
_______________________________________________
gatein-dev mailing list
gatein-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/gatein-dev