Ok, it's possible to avoid changing
in User interface and use fullName
field for it. However I think that
it's not so clear from semantics
perspective as fullName always means
combination of firstName lastName
when displayName, which will be
editable by user, can be something
completely different (like email
address). But looks like we don't
have much other choices if we want
to avoid change of User interface...
However in GateIn UI, I would be for
using label "Display Name" for this
new field. Is it ok? And it would
mean that class
org.exoplatform.services.organization.impl.UserImpl
will need to add new field: private
String lastName = null;
with implementations like:
public String getFullName()
{
return this.fullName != null ?
this.fullName : getFirstName() + " "
+ getLastName();
}
public void setFullName(String
fullName)
{
this.fullName = fullName;
}
Do you want me to create JIRA in
EXOJCR for it?
I think that for GateIn 3.2 is late
anyway because AFAIK release will be
in next few days.
Thanks,
Marek
On 23.2.2012 10:54, Nicolas FILOTTO
wrote:
Indeed you
are right this field exists and
should be used for this purpose.
This way we have nothing to change
in top level applications (apart
the ability to modify it of
course), we only need to implement
these methods to store/retrieve it
properly in/from the data store in
the different implementation of
the OrganizationService which is
more acceptable/doable for GateIn
3.2/ JCR 1.14 if it is really
needed to have it asap
On Thu,
Feb 23, 2012 at 8:52 AM, Julien
Viet
<julien@julienviet.com>
wrote:
The computed
property "fullName" is
persistable and could be
used for this display name.
When the value does not
exist: use the current
behavior "firstName
lastName".
When a user saves a new
value, it will be used
instead of the default
computed value.
There is already the
setFullName(String) method
on the User interface that
is empty in all
implementations.
On Feb 23,
2012, at 9:08
AM, Nicolas
FILOTTO wrote:
Hi,
How many
customers are we
talking about?
I'm not against
doing that for
next versions
but it is
clearly too late
for GateIn
3.2/JCR 1.14, it
is not
acceptable to
modify
interfaces in
branches that
are very close
to be in
maintenance
mode. Moreover
we would have 3
implementations
of the
Organization
Service to
review in very
limited time
only on eXo
side, on your
side you have
IDM too.
BR,
Nicolas
On
Wed, Feb 22,
2012 at 9:49
PM, Marek
Posolda
<mposolda@redhat.com>
wrote:
Hi,
We have
customers who
would like to
have editable
"displayName"
of user.
Currently
what's
displayed in
right top
corner after
login of user
is
his fullName,
which is
hardcoded as
'firstName
lastName' . So
we have
suggestions to
add new
non-mandatory
field
displayName,
which can be
something
similar like
in Thunderbird
https://wiki.mozilla.org/Thunderbird:Help_Documentation:Using_the_Address_Book#Contact_Tab
. So user can
fill
displayName
during his
registration
and it will be
displayed in
right top
corner in
UIUserInfoPortlet.
If user won't
have
displayName,
it will
fallback to
old behaviour
and it will
show fullName
instead of it.
What do you
think about
it? I already
created JIRA
https://issues.jboss.org/browse/GTNPORTAL-2358
with attached
patches.
First patch is
for required
changes in
exo.core.component.organization.api
. It's about
adding 2 new
methods
"getDisplayName"
and
"setDisplayName"
to interface
User and
change
UserImpl
implementation
and other
things
according to
it. Should I
create JIRA
into EXOJCR
project for
it?
Second patch
is for GateIn
where needed
changes are:
- Adding new
field into all
portlets for
creating and
updating of
user
- Changing
logic in
UIUserInfoPortlet
to use
displayName
with fallback
to fullName
Any
objections?
Thanks,
Marek
_______________________________________________
gatein-dev
mailing list
gatein-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/gatein-dev
_______________________________________________
gatein-dev
mailing list
gatein-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/gatein-dev