Indeed, we should internationalize the returned constant


On Sat, Aug 28, 2010 at 11:00 PM, <gatein-dev-request@lists.jboss.org> wrote:
Send gatein-dev mailing list submissions to
       gatein-dev@lists.jboss.org

To subscribe or unsubscribe via the World Wide Web, visit
       https://lists.jboss.org/mailman/listinfo/gatein-dev
or, via email, send a message with subject or body 'help' to
       gatein-dev-request@lists.jboss.org

You can reach the person managing the list at
       gatein-dev-owner@lists.jboss.org

When replying, please edit your Subject line so it is more specific
than "Re: Contents of gatein-dev digest..."


Today's Topics:

  1. Fwd: [gatein-commits] gatein SVN: r3915 -
     exo/portal/branches/3.1.x/portlet/exoadmin/src/main/java/org/exoplatform/applicationregistry/webui/component.
     (Christophe Laprun)
  2. Re: Fwd: [gatein-commits] gatein SVN: r3915 -
     exo/portal/branches/3.1.x/portlet/exoadmin/src/main/java/org/exoplatform/applicationregistry/webui/component.
     (Trong Tran)


----------------------------------------------------------------------

Message: 1
Date: Fri, 27 Aug 2010 18:25:46 +0200
From: Christophe Laprun <claprun@redhat.com>
Subject: [gatein-dev] Fwd: [gatein-commits] gatein SVN: r3915 -
       exo/portal/branches/3.1.x/portlet/exoadmin/src/main/java/org/exoplatform/applicationregistry/webui/component.

To: gatein-dev@lists.jboss.org
Message-ID: <DE49B992-38B3-4923-BC2D-B59EBE191B3F@redhat.com>
Content-Type: text/plain; charset=us-ascii

Shouldn't the following be localizable?

Begin forwarded message:

> From: do-not-reply@jboss.org
> Date: August 24, 2010 6:45:51 PM GMT+02:00
> To: gatein-commits@lists.jboss.org
> Subject: [gatein-commits] gatein SVN: r3915 - exo/portal/branches/3.1.x/portlet/exoadmin/src/main/java/org/exoplatform/applicationregistry/webui/component.
> Reply-To: gatein-commits@lists.jboss.org
>
> Author: hoang_to
> Date: 2010-08-24 12:45:50 -0400 (Tue, 24 Aug 2010)
> New Revision: 3915
>
> Modified:
>   exo/portal/branches/3.1.x/portlet/exoadmin/src/main/java/org/exoplatform/applicationregistry/webui/component/UIPortletManagement.java
> Log:
> EXOGTN-23: Exceptions are not properly handled in Application Registry Service
>
> Modified: exo/portal/branches/3.1.x/portlet/exoadmin/src/main/java/org/exoplatform/applicationregistry/webui/component/UIPortletManagement.java
> ===================================================================
> --- exo/portal/branches/3.1.x/portlet/exoadmin/src/main/java/org/exoplatform/applicationregistry/webui/component/UIPortletManagement.java     2010-08-24 16:32:56 UTC (rev 3914)
> +++ exo/portal/branches/3.1.x/portlet/exoadmin/src/main/java/org/exoplatform/applicationregistry/webui/component/UIPortletManagement.java     2010-08-24 16:45:50 UTC (rev 3915)
> @@ -313,17 +313,38 @@
>
>       public String getDisplayName()
>       {
> -         return getMetaValue(MetaInfo.DISPLAY_NAME, name_);
> +         try
> +         {
> +            return getMetaValue(MetaInfo.DISPLAY_NAME, name_);
> +         }
> +         catch (Exception ex)
> +         {
> +            return "COULD NOT GET DISPLAY NAME OF THE PORTLET";
> +         }
>       }
>
>       public String getDescription()
>       {
> -         return getMetaValue(MetaInfo.DESCRIPTION, name_);
> +         try
> +         {
> +            return getMetaValue(MetaInfo.DESCRIPTION, name_);
> +         }
> +         catch (Exception ex)
> +         {
> +            return "COULD NOT GET DESCRIPTION OF THE PORTLET";
> +         }
>       }
>
>       public PreferencesInfo getPortletPreferences()
>       {
> -         return portletInfo_.getPreferences();
> +         try
> +         {
> +            return portletInfo_.getPreferences();
> +         }
> +         catch (Exception ex)
> +         {
> +            return null;
> +         }
>       }
>
>       private String getMetaValue(String metaKey, String defaultValue)
>
> _______________________________________________
> gatein-commits mailing list
> gatein-commits@lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/gatein-commits

Cordialement / Best,
Chris

==
Principal Software Engineer / JBoss Enterprise Middleware Red Hat, Inc.
Follow GateIn: http://blog.gatein.org / http://twitter.com/gatein
Follow me: http://metacosm.codepuccino.com / http://twitter.com/metacosm




------------------------------

Message: 2
Date: Fri, 27 Aug 2010 23:47:28 +0700
From: Trong Tran <trongtt@gmail.com>
Subject: Re: [gatein-dev] Fwd: [gatein-commits] gatein SVN: r3915 -
       exo/portal/branches/3.1.x/portlet/exoadmin/src/main/java/org/exoplatform/applicationregistry/webui/component.

To: Christophe Laprun <claprun@redhat.com>
Cc: gatein-dev <gatein-dev@lists.jboss.org>
Message-ID:
       <AANLkTimFiuO3k+beXQmnR3TjnnoK4m5cc8jiYMhzFAd5@mail.gmail.com>
Content-Type: text/plain; charset="iso-8859-1"

it should be indeed

On 27 August 2010 23:25, Christophe Laprun <claprun@redhat.com> wrote:

> Shouldn't the following be localizable?
>
> Begin forwarded message:
>
> > From: do-not-reply@jboss.org
> > Date: August 24, 2010 6:45:51 PM GMT+02:00
> > To: gatein-commits@lists.jboss.org
> > Subject: [gatein-commits] gatein SVN: r3915 -
> exo/portal/branches/3.1.x/portlet/exoadmin/src/main/java/org/exoplatform/applicationregistry/webui/component.
> > Reply-To: gatein-commits@lists.jboss.org
> >
> > Author: hoang_to
> > Date: 2010-08-24 12:45:50 -0400 (Tue, 24 Aug 2010)
> > New Revision: 3915
> >
> > Modified:
> >
> exo/portal/branches/3.1.x/portlet/exoadmin/src/main/java/org/exoplatform/applicationregistry/webui/component/UIPortletManagement.java
> > Log:
> > EXOGTN-23: Exceptions are not properly handled in Application Registry
> Service
> >
> > Modified:
> exo/portal/branches/3.1.x/portlet/exoadmin/src/main/java/org/exoplatform/applicationregistry/webui/component/UIPortletManagement.java
> > ===================================================================
> > ---
> exo/portal/branches/3.1.x/portlet/exoadmin/src/main/java/org/exoplatform/applicationregistry/webui/component/UIPortletManagement.java
>     2010-08-24 16:32:56 UTC (rev 3914)
> > +++
> exo/portal/branches/3.1.x/portlet/exoadmin/src/main/java/org/exoplatform/applicationregistry/webui/component/UIPortletManagement.java
>     2010-08-24 16:45:50 UTC (rev 3915)
> > @@ -313,17 +313,38 @@
> >
> >       public String getDisplayName()
> >       {
> > -         return getMetaValue(MetaInfo.DISPLAY_NAME, name_);
> > +         try
> > +         {
> > +            return getMetaValue(MetaInfo.DISPLAY_NAME, name_);
> > +         }
> > +         catch (Exception ex)
> > +         {
> > +            return "COULD NOT GET DISPLAY NAME OF THE PORTLET";
> > +         }
> >       }
> >
> >       public String getDescription()
> >       {
> > -         return getMetaValue(MetaInfo.DESCRIPTION, name_);
> > +         try
> > +         {
> > +            return getMetaValue(MetaInfo.DESCRIPTION, name_);
> > +         }
> > +         catch (Exception ex)
> > +         {
> > +            return "COULD NOT GET DESCRIPTION OF THE PORTLET";
> > +         }
> >       }
> >
> >       public PreferencesInfo getPortletPreferences()
> >       {
> > -         return portletInfo_.getPreferences();
> > +         try
> > +         {
> > +            return portletInfo_.getPreferences();
> > +         }
> > +         catch (Exception ex)
> > +         {
> > +            return null;
> > +         }
> >       }
> >
> >       private String getMetaValue(String metaKey, String defaultValue)
> >
> > _______________________________________________
> > gatein-commits mailing list
> > gatein-commits@lists.jboss.org
> > https://lists.jboss.org/mailman/listinfo/gatein-commits
>
> Cordialement / Best,
> Chris
>
> ==
> Principal Software Engineer / JBoss Enterprise Middleware Red Hat, Inc.
> Follow GateIn: http://blog.gatein.org / http://twitter.com/gatein
> Follow me: http://metacosm.codepuccino.com / http://twitter.com/metacosm
>
>
> _______________________________________________
> gatein-dev mailing list
> gatein-dev@lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/gatein-dev
>



--
Tran The Trong
eXo Platform SAS
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/gatein-dev/attachments/20100827/2bbbf382/attachment-0001.html

------------------------------

_______________________________________________
gatein-dev mailing list
gatein-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/gatein-dev


End of gatein-dev Digest, Vol 11, Issue 10
******************************************



--
Minh Hoang TO
eXoPlatform SAS, tang 8, building 18, Thai Ha, Ha Noi