Hi Tran,

I'm sorry to bother again, just one more small thing, hopefully this is
the last one:

https://github.com/gatein/gatein-portal/pull/625

I have added:
 +            if(maximizedUIComponent.getAncestorOfType(UIPage.class) ==
getUIComponent()) {
+
maximizedUIComponent.processRender((WebuiRequestContext)
WebuiRequestContext.getCurrentInstance());
+                return;
+            }

into UIPageBody.processRender because without this if you have one
maximized portlet and go to another page, then it would still display
the maximized portlet from the first page even if this portlet doesn't
exist at that page at all!

I hope this is ok, I just want to make sure that I can do this check for
maximizedUIComponent.getAncestorOfType(UIPage.class) and assume it
should be equal to uiComponent in the UIPageBody class.

Maybe I'm forgetting of some other usecase or this will always work?

It works fine for what I've tested.


Thanks,

On Friday 16 August 2013 23:54:25 Trong Tran wrote:

>Hello Adam,
>
>This is a concurrency problem of parallel requests on different nav
>node. UIPage objects are cached now for performance, when you move
>from nav node A -> B, the UIPage A takes off from the tree and B will
>be replaced.
>
>So the proper fix would be to simply replace
>getAncestorOfType(UIPortalApplication.class) by
>Util.getUIPortalApplication() in the #getSuitedTheme.
>
>Thanks
>
>On 15 August 2013 15:53, Adam Kovari <akovari@redhat.com> wrote:
>> Hi Tran,
>>
>> when you have a moment, could you please review my PR 625 for
>> GTNPORTAL-3156?
>>
>> https://issues.jboss.org/browse/GTNPORTAL-3156
>> https://github.com/gatein/gatein-portal/pull/625
>>
>>
>> Thanks,
>>
>> --
>> Adam Kovari
--

Adam Kovari