rollback done in the trunk<br><br><div class="gmail_quote">On Thu, Dec 10, 2009 at 8:44 AM, Nicolas Filotto <span dir="ltr">&lt;<a href="mailto:nicolas.filotto@gmail.com">nicolas.filotto@gmail.com</a>&gt;</span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">No need to do that, it seems that it is a regression at the kernel level, I&#39;ll fix it<br><br><div class="gmail_quote">

<div><div></div><div class="h5">On Wed, Dec 9, 2009 at 9:01 PM, Marko Strukelj <span dir="ltr">&lt;<a href="mailto:marko.strukelj@gmail.com" target="_blank">marko.strukelj@gmail.com</a>&gt;</span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div></div><div class="h5"><br><div>With the latest kernel-caching looks like the contract was changed by adding a few &#39;throws Exception&#39; declarations on methods.</div>


<div><br></div><div>Now portal build fails for me. To get the build to pass I had to catch the exceptions in a few places (exception handling not necessarily appropriate):</div>
<div><br></div><div><div>Index: component/portal/src/main/java/org/exoplatform/portal/pom/config/POMSession.java</div><div>===================================================================</div><div>--- component/portal/src/main/java/org/exoplatform/portal/pom/config/POMSession.java    (revision 981)</div>



<div>+++ component/portal/src/main/java/org/exoplatform/portal/pom/config/POMSession.java    (working copy)</div><div>@@ -96,7 +96,14 @@</div><div>       {</div><div>          throw new IllegalStateException(&quot;Cannot read object in shared cache from a modified session&quot;);</div>



<div>       }</div><div>-      return mgr.cache.get(key);</div><div>+      try</div><div>+      {</div><div>+         return mgr.cache.get(key);</div><div>+      }</div><div>+      catch (Exception e)</div><div>+      {</div>



<div>+         throw new RuntimeException(&quot;Exception while getting from cache: &quot;, e);</div><div>+      }</div><div>    }</div><div><br></div><div>    public void putInCache(Serializable key, Object value)</div>


<div>
@@ -105,7 +112,14 @@</div><div>       {</div><div>          throw new IllegalStateException(&quot;Cannot put object in shared cache from a modified session&quot;);</div><div>       }</div><div>-      mgr.cache.put(key, value);</div>



<div>+      try</div><div>+      {</div><div>+         mgr.cache.put(key, value);</div><div>+      }</div><div>+      catch (Exception e)</div><div>+      {</div><div>+         throw new RuntimeException(&quot;Exception while putting into cache: &quot;, e);</div>



<div>+      }</div><div>    }</div><div><br></div><div>    public void scheduleForEviction(Serializable key)</div><div>@@ -407,7 +421,13 @@</div><div>       {</div><div>          for (Serializable key : staleKeys)</div><div>



          {</div><div>-            mgr.cache.remove(key);</div><div>+            try</div><div>+            {</div><div>+               mgr.cache.remove(key);</div><div>+            }</div><div>+            catch (Exception ignored)</div>



<div>+            {</div><div>+            }</div><div>          }</div><div>       }</div><div>    }</div><div>Index: component/portal/src/main/java/org/exoplatform/portal/pom/config/POMSessionManager.java</div><div>===================================================================</div>



<div>--- component/portal/src/main/java/org/exoplatform/portal/pom/config/POMSessionManager.java     (revision 981)</div><div>+++ component/portal/src/main/java/org/exoplatform/portal/pom/config/POMSessionManager.java     (working copy)</div>



<div>@@ -95,7 +95,14 @@</div><div><br></div><div>    public void clearCache()</div><div>    {</div><div>-      cache.clearCache();</div><div>+      try</div><div>+      {</div><div>+         cache.clearCache();</div><div>



+      }</div><div>+      catch (Exception e)</div><div>+      {</div><div>+         throw new RuntimeException(&quot;Failed to clear cache: &quot;, e);</div><div>+      }</div><div>    }</div><div><br></div><div>    public MOPService getPOMService()</div>



<div>Index: component/resources/src/main/java/org/exoplatform/services/resources/impl/BaseResourceBundleService.java</div><div>===================================================================</div><div>--- component/resources/src/main/java/org/exoplatform/services/resources/impl/BaseResourceBundleService.java    (revision 981)</div>



<div>+++ component/resources/src/main/java/org/exoplatform/services/resources/impl/BaseResourceBundleService.java    (working copy)</div><div>@@ -266,7 +266,14 @@</div><div>     */</div><div>    protected final void invalidate(String name)</div>



<div>    {</div><div>-      cache_.remove(name);</div><div>+      try</div><div>+      {</div><div>+         cache_.remove(name);</div><div>+      }</div><div>+      catch (Exception ex)</div><div>+      {</div><div>+         log_.warn(&quot;Failed to invalidate entry: &quot; + name, ex);</div>



<div>+      }</div><div>    }</div><div><br></div><div>    public ResourceBundle getResourceBundle(String name, Locale locale, ClassLoader cl)</div><div><br></div><div><br></div><div>Cheers,</div><div><br></div><font color="#888888"><div>


- marko</div>
</font></div>
<br></div></div>_______________________________________________<br>
gatein-dev mailing list<br>
<a href="mailto:gatein-dev@lists.jboss.org" target="_blank">gatein-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/gatein-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/gatein-dev</a><br>
<br></blockquote></div><font color="#888888"><br><br clear="all"><br>-- <br>Nicolas Filotto<br>JCR Product Manager<br>Project Manager<br>eXo Platform SAS<br><a href="mailto:nicolas.filotto@exoplatform.com" target="_blank">nicolas.filotto@exoplatform.com</a><br>


+33 (0)6 31 32 92 19  <br>
</font></blockquote></div><br><br clear="all"><br>-- <br>Nicolas Filotto<br>JCR Product Manager<br>Project Manager<br>eXo Platform SAS<br><a href="mailto:nicolas.filotto@exoplatform.com">nicolas.filotto@exoplatform.com</a><br>

+33 (0)6 31 32 92 19  <br>