[JBoss JIRA] (GTNPORTAL-2771) Ensure that generated rememberme token is really unique
by Marek Posolda (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-2771?page=com.atlassian.jira.pl... ]
Marek Posolda updated GTNPORTAL-2771:
-------------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/gatein/gatein-portal/pull/296
Pull request based on approach 2 (generate different tokenId if it already exists). So generating of token is based on random number and format of tokens is still the same.
> Ensure that generated rememberme token is really unique
> -------------------------------------------------------
>
> Key: GTNPORTAL-2771
> URL: https://issues.jboss.org/browse/GTNPORTAL-2771
> Project: GateIn Portal
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Reporter: Marek Posolda
> Assignee: Marek Posolda
>
> Currently we are generating random rememberme tokens based on random int number (random.nextInt()). In systems with millions or many thousands login, this discriminator is not enough.
> We should improve it and fix it either by:
> 1) Ensure that generated token is really unique. In system with many logins the random number may not be unique enough, so we need to add other info (like System.currentTimeMillis() or counter or both...)
> 2) In case that token already exists, we should generate other one instead of refresh the current one.
> Maybe combination of both approaches would be best :-)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 6 months
[JBoss JIRA] (GTNPORTAL-2771) Ensure that generated rememberme token is really unique
by Marek Posolda (JIRA)
Marek Posolda created GTNPORTAL-2771:
----------------------------------------
Summary: Ensure that generated rememberme token is really unique
Key: GTNPORTAL-2771
URL: https://issues.jboss.org/browse/GTNPORTAL-2771
Project: GateIn Portal
Issue Type: Bug
Security Level: Public (Everyone can see)
Reporter: Marek Posolda
Assignee: Marek Posolda
Currently we are generating random rememberme tokens based on random int number (random.nextInt()). In systems with millions or many thousands login, this discriminator is not enough.
We should improve it and fix it either by:
1) Ensure that generated token is really unique. In system with many logins the random number may not be unique enough, so we need to add other info (like System.currentTimeMillis() or counter or both...)
2) In case that token already exists, we should generate other one instead of refresh the current one.
Maybe combination of both approaches would be best :-)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 6 months
[JBoss JIRA] (GTNPORTAL-2770) Bug JS: happens when js file in module contains tab charecter at header
by Vu Viet Phuong (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-2770?page=com.atlassian.jira.pl... ]
Vu Viet Phuong updated GTNPORTAL-2770:
--------------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/exoportal/gatein-portal/pull/10
> Bug JS: happens when js file in module contains tab charecter at header
> -----------------------------------------------------------------------
>
> Key: GTNPORTAL-2770
> URL: https://issues.jboss.org/browse/GTNPORTAL-2770
> Project: GateIn Portal
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Affects Versions: 3.5.0.Final
> Reporter: Pham Duy Dong
> Assignee: Vu Viet Phuong
> Priority: Minor
>
> - Declare a js (ex: abc.js) file in gatein-resources.xml
> {code:xml}
> ...
> <module>
> <name>moduleName</name>
> <script>
> <path>/javascript/webui/abc.js</path>
> </script>
> </module>
> ...
> {code}
> - Require it in groovy template file
> - In a javascript file (ex: abc.js):
> If comment at top file contains tab character(\t) at begining line, js bug happens
> After remove tab, bug js also not happens anymore
> -- js file with tab at header
> {code:title=abc.js|borderStyle=solid}
> /**
> * Some comments...
> */
> (function(gj) {
> ...
> {code}
> -- js file after remove tab
> {code:title=abc.js|borderStyle=solid}
> /**
> * Some comments...
> */
> (function(gj) {
> ...
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 6 months
[JBoss JIRA] (GTNPORTAL-2770) Bug JS: happens when js file in module contains tab charecter at header
by Vu Viet Phuong (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-2770?page=com.atlassian.jira.pl... ]
Vu Viet Phuong reassigned GTNPORTAL-2770:
-----------------------------------------
Assignee: Vu Viet Phuong
> Bug JS: happens when js file in module contains tab charecter at header
> -----------------------------------------------------------------------
>
> Key: GTNPORTAL-2770
> URL: https://issues.jboss.org/browse/GTNPORTAL-2770
> Project: GateIn Portal
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Affects Versions: 3.5.0.Final
> Reporter: Pham Duy Dong
> Assignee: Vu Viet Phuong
> Priority: Minor
>
> - Declare a js (ex: abc.js) file in gatein-resources.xml
> {code:xml}
> ...
> <module>
> <name>moduleName</name>
> <script>
> <path>/javascript/webui/abc.js</path>
> </script>
> </module>
> ...
> {code}
> - Require it in groovy template file
> - In a javascript file (ex: abc.js):
> If comment at top file contains tab character(\t) at begining line, js bug happens
> After remove tab, bug js also not happens anymore
> -- js file with tab at header
> {code:title=abc.js|borderStyle=solid}
> /**
> * Some comments...
> */
> (function(gj) {
> ...
> {code}
> -- js file after remove tab
> {code:title=abc.js|borderStyle=solid}
> /**
> * Some comments...
> */
> (function(gj) {
> ...
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 6 months
[JBoss JIRA] (GTNPORTAL-2767) Error Messages when using forward
by Trong Tran (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-2767?page=com.atlassian.jira.pl... ]
Trong Tran commented on GTNPORTAL-2767:
---------------------------------------
Seems you missed to attach the log file, @Frederic.
> Error Messages when using forward
> ---------------------------------
>
> Key: GTNPORTAL-2767
> URL: https://issues.jboss.org/browse/GTNPORTAL-2767
> Project: GateIn Portal
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: Common integration
> Affects Versions: 3.5.0.Beta02
> Environment: Gate In 3.5.0 Beta02 on top of EAP6
> Reporter: Frederic Hornain
>
> Indeed, the customer portal team has an issue regarding the navigation in portal.
> They are currently trying navigation.
> They would to go to another page by using a forward:
> private void executeNavigation(String nodeURL) {
> PortalRequestContext requestContext = null;
> ServletRequest request = null;
> ServletResponse response = null;
> String requestContextPath = null;
> String trimmedNodeURL = null;
> RequestDispatcher dispatcher = null;
> requestContext = Util.getPortalRequestContext();
> request = requestContext.getRequest();
> response = requestContext.getResponse();
> requestContextPath = requestContext.getPortalContextPath();
> // Remove the portal context path from the nodeURL
> // e.g. if nodeURL = "/portal/hello", and portal context path = "/portal" then trimmedNodeURL = "/hello"
> trimmedNodeURL = nodeURL.substring(requestContextPath != null ? requestContextPath.length() : 0);
> dispatcher = request.getRequestDispatcher(trimmedNodeURL);
> try {
> dispatcher.forward(request, response);
> } catch (Exception e) {
> // TODO
> }
> }
> It works and they are well redirected to the corresponding page.
> However, customer receive an error (see attached log file).
> Then would it be possible to fix this issue ?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 6 months
[JBoss JIRA] (GTNPORTAL-2770) Bug JS: happens when js file in module contains tab charecter at header
by Pham Duy Dong (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-2770?page=com.atlassian.jira.pl... ]
Pham Duy Dong updated GTNPORTAL-2770:
-------------------------------------
Description:
- Declare a js (ex: abc.js) file in gatein-resources.xml
{code:xml}
...
<module>
<name>moduleName</name>
<script>
<path>/javascript/webui/abc.js</path>
</script>
</module>
...
{code}
- Require it in groovy template file
- In a javascript file (ex: abc.js):
If comment at top file contains tab character(\t) at begining line, js bug happens
After remove tab, bug js also not happens anymore
-- js file with tab at header
{code:title=abc.js|borderStyle=solid}
/**
* Some comments...
*/
(function(gj) {
...
{code}
-- js file after remove tab
{code:title=abc.js|borderStyle=solid}
/**
* Some comments...
*/
(function(gj) {
...
{code}
was:
- Declare a js (ex: abc.js) file in gatein-resources.xml
{code:xml}
...
<module>
<name>moduleName</name>
<script>
<path>/javascript/webui/abc.js</path>
</script>
</module>
...
{code}
- Require it in groovy template file
- In a javascript file (ex: abc.js):
If comment at top file contains tab character(\t) at begining line, js bug happens
After remove tab, bug js also not happens anymore
-- js file with tab at header
{code:title=abc.js|borderStyle=solid}
/**
* Some comments...
*/
(function(gj) {
...
{code}
-- js file after remove tab
{code:title=WCMUIPopupWindow.js|borderStyle=solid}
/**
* Some comments...
*/
(function(gj) {
...
{code}
> Bug JS: happens when js file in module contains tab charecter at header
> -----------------------------------------------------------------------
>
> Key: GTNPORTAL-2770
> URL: https://issues.jboss.org/browse/GTNPORTAL-2770
> Project: GateIn Portal
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Affects Versions: 3.5.0.Final
> Reporter: Pham Duy Dong
> Priority: Minor
>
> - Declare a js (ex: abc.js) file in gatein-resources.xml
> {code:xml}
> ...
> <module>
> <name>moduleName</name>
> <script>
> <path>/javascript/webui/abc.js</path>
> </script>
> </module>
> ...
> {code}
> - Require it in groovy template file
> - In a javascript file (ex: abc.js):
> If comment at top file contains tab character(\t) at begining line, js bug happens
> After remove tab, bug js also not happens anymore
> -- js file with tab at header
> {code:title=abc.js|borderStyle=solid}
> /**
> * Some comments...
> */
> (function(gj) {
> ...
> {code}
> -- js file after remove tab
> {code:title=abc.js|borderStyle=solid}
> /**
> * Some comments...
> */
> (function(gj) {
> ...
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 6 months
[JBoss JIRA] (GTNPORTAL-2770) Bug JS: happens when js file in module contains tab charecter at header
by Pham Duy Dong (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-2770?page=com.atlassian.jira.pl... ]
Pham Duy Dong updated GTNPORTAL-2770:
-------------------------------------
Description:
- Declare a js (ex: abc.js) file in gatein-resources.xml
{code:xml}
...
<module>
<name>moduleName</name>
<script>
<path>/javascript/webui/abc.js</path>
</script>
</module>
...
{code}
- Require it in groovy template file
- In a javascript file (ex: abc.js):
If comment at top file contains tab character(\t) at begining line, js bug happens
After remove tab, bug js also not happens anymore
-- js file with tab at header
{code:title=abc.js|borderStyle=solid}
/**
* Some comments...
*/
(function(gj) {
...
{code}
-- js file after remove tab
{code:title=WCMUIPopupWindow.js|borderStyle=solid}
/**
* Some comments...
*/
(function(gj) {
...
{code}
was:
- Declare that js(ex: abc.js) file in gatein-resources.xml
{code:xml}
...
<module>
<name>moduleName</name>
<script>
<path>/javascript/webui/abc.js</path>
</script>
</module>
...
{code}
- Require it in groovy template file
- In a javascript file (ex: abc.js):
If comment at top file contains tab character(\t) at begining line, js bug happens
After remove tab, bug js also not happens anymore
-- js file with tab at header
{code:title=abc.js|borderStyle=solid}
/**
* Some comments...
*/
(function(gj) {
...
{code}
-- js file after remove tab
{code:title=WCMUIPopupWindow.js|borderStyle=solid}
/**
* Some comments...
*/
(function(gj) {
...
{code}
> Bug JS: happens when js file in module contains tab charecter at header
> -----------------------------------------------------------------------
>
> Key: GTNPORTAL-2770
> URL: https://issues.jboss.org/browse/GTNPORTAL-2770
> Project: GateIn Portal
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Affects Versions: 3.5.0.Final
> Reporter: Pham Duy Dong
> Priority: Minor
>
> - Declare a js (ex: abc.js) file in gatein-resources.xml
> {code:xml}
> ...
> <module>
> <name>moduleName</name>
> <script>
> <path>/javascript/webui/abc.js</path>
> </script>
> </module>
> ...
> {code}
> - Require it in groovy template file
> - In a javascript file (ex: abc.js):
> If comment at top file contains tab character(\t) at begining line, js bug happens
> After remove tab, bug js also not happens anymore
> -- js file with tab at header
> {code:title=abc.js|borderStyle=solid}
> /**
> * Some comments...
> */
> (function(gj) {
> ...
> {code}
> -- js file after remove tab
> {code:title=WCMUIPopupWindow.js|borderStyle=solid}
> /**
> * Some comments...
> */
> (function(gj) {
> ...
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 6 months
[JBoss JIRA] (GTNPORTAL-2770) Bug JS: happens when js file in module contains tab charecter at header
by Pham Duy Dong (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-2770?page=com.atlassian.jira.pl... ]
Pham Duy Dong updated GTNPORTAL-2770:
-------------------------------------
Description:
- Declare that js(ex: abc.js) file in gatein-resources.xml
{code:xml}
...
<module>
<name>moduleName</name>
<script>
<path>/javascript/eXo/webui/abc.js</path>
</script>
</module>
...
{code}
- Require it in groovy template file
- In a javascript file (ex: abc.js):
If comment at top file contains tab character(\t) at begining line, js bug happens
After remove tab, bug js also not happens anymore
-- js file with tab at header
{code:title=abc.js|borderStyle=solid}
/**
* Some comments...
*/
(function(gj) {
...
{code}
-- js file after remove tab
{code:title=WCMUIPopupWindow.js|borderStyle=solid}
/**
* Some comments...
*/
(function(gj) {
...
{code}
was:
- Declare that js(ex: WCMUIPopupWindow.js) file in gatein-resources.xml
{code:xml}
...
<module>
<name>moduleName</name>
<script>
<path>/javascript/eXo/webui/WCMUIPopupWindow.js</path>
</script>
</module>
...
{code}
- Require it in groovy template file
- In a javascript file (ex: WCMUIPopupWindow.js):
If comment at top file contains tab character(\t) at begining line, js bug happens
After remove tab, bug js also not happens anymore
-- js file with tab at header
{code:title=WCMUIPopupWindow.js|borderStyle=solid}
/**
* Some comments...
*/
(function(gj, wcm_utils, common, uiForm) {
...
{code}
-- js file after remove tab
{code:title=WCMUIPopupWindow.js|borderStyle=solid}
/**
* Some comments...
*/
(function(gj, wcm_utils, common, uiForm) {
...
{code}
> Bug JS: happens when js file in module contains tab charecter at header
> -----------------------------------------------------------------------
>
> Key: GTNPORTAL-2770
> URL: https://issues.jboss.org/browse/GTNPORTAL-2770
> Project: GateIn Portal
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Affects Versions: 3.5.0.Final
> Reporter: Pham Duy Dong
> Priority: Minor
>
> - Declare that js(ex: abc.js) file in gatein-resources.xml
> {code:xml}
> ...
> <module>
> <name>moduleName</name>
> <script>
> <path>/javascript/eXo/webui/abc.js</path>
> </script>
> </module>
> ...
> {code}
> - Require it in groovy template file
> - In a javascript file (ex: abc.js):
> If comment at top file contains tab character(\t) at begining line, js bug happens
> After remove tab, bug js also not happens anymore
> -- js file with tab at header
> {code:title=abc.js|borderStyle=solid}
> /**
> * Some comments...
> */
> (function(gj) {
> ...
> {code}
> -- js file after remove tab
> {code:title=WCMUIPopupWindow.js|borderStyle=solid}
> /**
> * Some comments...
> */
> (function(gj) {
> ...
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 6 months
[JBoss JIRA] (GTNPORTAL-2770) Bug JS: happens when js file in module contains tab charecter at header
by Pham Duy Dong (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-2770?page=com.atlassian.jira.pl... ]
Pham Duy Dong updated GTNPORTAL-2770:
-------------------------------------
Description:
- Declare that js(ex: abc.js) file in gatein-resources.xml
{code:xml}
...
<module>
<name>moduleName</name>
<script>
<path>/javascript/webui/abc.js</path>
</script>
</module>
...
{code}
- Require it in groovy template file
- In a javascript file (ex: abc.js):
If comment at top file contains tab character(\t) at begining line, js bug happens
After remove tab, bug js also not happens anymore
-- js file with tab at header
{code:title=abc.js|borderStyle=solid}
/**
* Some comments...
*/
(function(gj) {
...
{code}
-- js file after remove tab
{code:title=WCMUIPopupWindow.js|borderStyle=solid}
/**
* Some comments...
*/
(function(gj) {
...
{code}
was:
- Declare that js(ex: abc.js) file in gatein-resources.xml
{code:xml}
...
<module>
<name>moduleName</name>
<script>
<path>/javascript/eXo/webui/abc.js</path>
</script>
</module>
...
{code}
- Require it in groovy template file
- In a javascript file (ex: abc.js):
If comment at top file contains tab character(\t) at begining line, js bug happens
After remove tab, bug js also not happens anymore
-- js file with tab at header
{code:title=abc.js|borderStyle=solid}
/**
* Some comments...
*/
(function(gj) {
...
{code}
-- js file after remove tab
{code:title=WCMUIPopupWindow.js|borderStyle=solid}
/**
* Some comments...
*/
(function(gj) {
...
{code}
> Bug JS: happens when js file in module contains tab charecter at header
> -----------------------------------------------------------------------
>
> Key: GTNPORTAL-2770
> URL: https://issues.jboss.org/browse/GTNPORTAL-2770
> Project: GateIn Portal
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Affects Versions: 3.5.0.Final
> Reporter: Pham Duy Dong
> Priority: Minor
>
> - Declare that js(ex: abc.js) file in gatein-resources.xml
> {code:xml}
> ...
> <module>
> <name>moduleName</name>
> <script>
> <path>/javascript/webui/abc.js</path>
> </script>
> </module>
> ...
> {code}
> - Require it in groovy template file
> - In a javascript file (ex: abc.js):
> If comment at top file contains tab character(\t) at begining line, js bug happens
> After remove tab, bug js also not happens anymore
> -- js file with tab at header
> {code:title=abc.js|borderStyle=solid}
> /**
> * Some comments...
> */
> (function(gj) {
> ...
> {code}
> -- js file after remove tab
> {code:title=WCMUIPopupWindow.js|borderStyle=solid}
> /**
> * Some comments...
> */
> (function(gj) {
> ...
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 6 months