[JBoss JIRA] (GTNPORTAL-2751) <priority> in navigation.xml files ignored for merge importMode
by Trong Tran (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-2751?page=com.atlassian.jira.pl... ]
Trong Tran commented on GTNPORTAL-2751:
---------------------------------------
Ok. I agree with you.
> <priority> in navigation.xml files ignored for merge importMode
> ----------------------------------------------------------------
>
> Key: GTNPORTAL-2751
> URL: https://issues.jboss.org/browse/GTNPORTAL-2751
> Project: GateIn Portal
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Reporter: Peter Palaga
> Assignee: Hai Nguyen
> Original Estimate: 4 hours
> Time Spent: 3 hours
> Remaining Estimate: 7 hours
>
> Steps to reproduce:
> Clone the Portal Extension Quickstart and deploy it changing the {{<priority>}} value in {{war/src/main/webapp/WEB-INF/conf/sample-ext/portal/group/platform/administrators/navigation.xml}}.
> NOT OK: The changes have no effect, because priority is ignored in {{org.exoplatform.portal.mop.importer.NavigationImporter.perform()}} with {{importMode}} {{merge}}.
> h3. Solution Proposal A
> * Make {{<priority>}} optional in {{gatein_objects}} XSD and {{NavigationMarshaller.unmarshalNavigation(StaxNavigator<Element>)}}
> * Explicitly state in the documentation [1] that {{<priority>}} is considered only if not already set (first wins).
> h3. Solution Proposal B
> * Make {{<priority>}} optional in {{gatein_objects}} XSD and {{NavigationMarshaller.unmarshalNavigation(StaxNavigator<Element>)}}
> * Change the behavior of {{NavigationMarshaller.unmarshalNavigation(StaxNavigator<Element>)}} to the effect that {{<priority>}} is handled in the same way as navigation nodes: it is used or ignored according to the chosen {{importMode}}. Esp. for {{importMode}} {{merge}} the last read {{<priority>}} should win.
> * Document it in [1]
> For both A and B the most or all occutences of {{<priority>}} should be removed from Portal Extension Quickstart.
> [1] [https://docs.jboss.org/author/display/GTNPORTAL35/Portal+Navigation+Confi...]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 2 months
[JBoss JIRA] (GTNPORTAL-2751) <priority> in navigation.xml files ignored for merge importMode
by Peter Palaga (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-2751?page=com.atlassian.jira.pl... ]
Peter Palaga commented on GTNPORTAL-2751:
-----------------------------------------
bq. The proposal B makes more sense to me, BUT it would mean a change in behavior.
I also see B as the most natural way of how it should work and yes, {{<priority>}} values which were ignored so far, will not be ignored anymore. I believe that the change will not be that harmful for portal owners because it can be detected quite easily where it matters (it can be seen at the first sight). They should be aware of it if we document it properly.
> <priority> in navigation.xml files ignored for merge importMode
> ----------------------------------------------------------------
>
> Key: GTNPORTAL-2751
> URL: https://issues.jboss.org/browse/GTNPORTAL-2751
> Project: GateIn Portal
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Reporter: Peter Palaga
> Assignee: Hai Nguyen
> Original Estimate: 4 hours
> Time Spent: 3 hours
> Remaining Estimate: 7 hours
>
> Steps to reproduce:
> Clone the Portal Extension Quickstart and deploy it changing the {{<priority>}} value in {{war/src/main/webapp/WEB-INF/conf/sample-ext/portal/group/platform/administrators/navigation.xml}}.
> NOT OK: The changes have no effect, because priority is ignored in {{org.exoplatform.portal.mop.importer.NavigationImporter.perform()}} with {{importMode}} {{merge}}.
> h3. Solution Proposal A
> * Make {{<priority>}} optional in {{gatein_objects}} XSD and {{NavigationMarshaller.unmarshalNavigation(StaxNavigator<Element>)}}
> * Explicitly state in the documentation [1] that {{<priority>}} is considered only if not already set (first wins).
> h3. Solution Proposal B
> * Make {{<priority>}} optional in {{gatein_objects}} XSD and {{NavigationMarshaller.unmarshalNavigation(StaxNavigator<Element>)}}
> * Change the behavior of {{NavigationMarshaller.unmarshalNavigation(StaxNavigator<Element>)}} to the effect that {{<priority>}} is handled in the same way as navigation nodes: it is used or ignored according to the chosen {{importMode}}. Esp. for {{importMode}} {{merge}} the last read {{<priority>}} should win.
> * Document it in [1]
> For both A and B the most or all occutences of {{<priority>}} should be removed from Portal Extension Quickstart.
> [1] [https://docs.jboss.org/author/display/GTNPORTAL35/Portal+Navigation+Confi...]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 2 months
[JBoss JIRA] (GTNPORTAL-2751) <priority> in navigation.xml files ignored for merge importMode
by Trong Tran (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-2751?focusedWorklogId=12429942&... ]
Trong Tran logged work on GTNPORTAL-2751:
-----------------------------------------
Author: Trong Tran
Created on: 04/Oct/13 4:03 AM
Start Date: 04/Oct/13 4:02 AM
Worklog Time Spent: 1 hour
Work Description: Clarify to make a decision
Issue Time Tracking
-------------------
Remaining Estimate: 7 hours (was: 1 day)
Time Spent: 3 hours (was: 2 hours)
Worklog Id: (was: 12429942)
> <priority> in navigation.xml files ignored for merge importMode
> ----------------------------------------------------------------
>
> Key: GTNPORTAL-2751
> URL: https://issues.jboss.org/browse/GTNPORTAL-2751
> Project: GateIn Portal
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Reporter: Peter Palaga
> Assignee: Hai Nguyen
> Original Estimate: 4 hours
> Time Spent: 3 hours
> Remaining Estimate: 7 hours
>
> Steps to reproduce:
> Clone the Portal Extension Quickstart and deploy it changing the {{<priority>}} value in {{war/src/main/webapp/WEB-INF/conf/sample-ext/portal/group/platform/administrators/navigation.xml}}.
> NOT OK: The changes have no effect, because priority is ignored in {{org.exoplatform.portal.mop.importer.NavigationImporter.perform()}} with {{importMode}} {{merge}}.
> h3. Solution Proposal A
> * Make {{<priority>}} optional in {{gatein_objects}} XSD and {{NavigationMarshaller.unmarshalNavigation(StaxNavigator<Element>)}}
> * Explicitly state in the documentation [1] that {{<priority>}} is considered only if not already set (first wins).
> h3. Solution Proposal B
> * Make {{<priority>}} optional in {{gatein_objects}} XSD and {{NavigationMarshaller.unmarshalNavigation(StaxNavigator<Element>)}}
> * Change the behavior of {{NavigationMarshaller.unmarshalNavigation(StaxNavigator<Element>)}} to the effect that {{<priority>}} is handled in the same way as navigation nodes: it is used or ignored according to the chosen {{importMode}}. Esp. for {{importMode}} {{merge}} the last read {{<priority>}} should win.
> * Document it in [1]
> For both A and B the most or all occutences of {{<priority>}} should be removed from Portal Extension Quickstart.
> [1] [https://docs.jboss.org/author/display/GTNPORTAL35/Portal+Navigation+Confi...]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 2 months
[JBoss JIRA] (GTNPORTAL-2751) <priority> in navigation.xml files ignored for merge importMode
by Trong Tran (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-2751?page=com.atlassian.jira.pl... ]
Trong Tran commented on GTNPORTAL-2751:
---------------------------------------
The proposal B makes more sense to me, BUT it would mean a change in behavior.
So we would go with solution A for now. WDYT ?
> <priority> in navigation.xml files ignored for merge importMode
> ----------------------------------------------------------------
>
> Key: GTNPORTAL-2751
> URL: https://issues.jboss.org/browse/GTNPORTAL-2751
> Project: GateIn Portal
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Reporter: Peter Palaga
> Assignee: Hai Nguyen
> Original Estimate: 4 hours
> Time Spent: 2 hours
> Remaining Estimate: 1 day
>
> Steps to reproduce:
> Clone the Portal Extension Quickstart and deploy it changing the {{<priority>}} value in {{war/src/main/webapp/WEB-INF/conf/sample-ext/portal/group/platform/administrators/navigation.xml}}.
> NOT OK: The changes have no effect, because priority is ignored in {{org.exoplatform.portal.mop.importer.NavigationImporter.perform()}} with {{importMode}} {{merge}}.
> h3. Solution Proposal A
> * Make {{<priority>}} optional in {{gatein_objects}} XSD and {{NavigationMarshaller.unmarshalNavigation(StaxNavigator<Element>)}}
> * Explicitly state in the documentation [1] that {{<priority>}} is considered only if not already set (first wins).
> h3. Solution Proposal B
> * Make {{<priority>}} optional in {{gatein_objects}} XSD and {{NavigationMarshaller.unmarshalNavigation(StaxNavigator<Element>)}}
> * Change the behavior of {{NavigationMarshaller.unmarshalNavigation(StaxNavigator<Element>)}} to the effect that {{<priority>}} is handled in the same way as navigation nodes: it is used or ignored according to the chosen {{importMode}}. Esp. for {{importMode}} {{merge}} the last read {{<priority>}} should win.
> * Document it in [1]
> For both A and B the most or all occutences of {{<priority>}} should be removed from Portal Extension Quickstart.
> [1] [https://docs.jboss.org/author/display/GTNPORTAL35/Portal+Navigation+Confi...]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 2 months
[JBoss JIRA] (GTNPORTAL-3245) Add comfriming when user remove permissions on edit page & site
by Vu Viet Phuong (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-3245?page=com.atlassian.jira.pl... ]
Vu Viet Phuong updated GTNPORTAL-3245:
--------------------------------------
Status: Open (was: Pull Request Sent)
> Add comfriming when user remove permissions on edit page & site
> ---------------------------------------------------------------
>
> Key: GTNPORTAL-3245
> URL: https://issues.jboss.org/browse/GTNPORTAL-3245
> Project: GateIn Portal
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Affects Versions: 3.6.1.Final
> Reporter: Hai Nguyen
> Assignee: Hai Nguyen
> Priority: Minor
> Labels: backlogs
> Original Estimate: 4 hours
> Time Spent: 1 day, 3 hours
> Remaining Estimate: 1 hour
>
> - Login portal
> - Go to user and group management
> - Choose Group management tab
> - Add new group ( ex: AAA)
> - Go to Pages
> - Add new page for group above
> - Search this page and click edit
> - Click view page properties
> - Change access and edit permission to ( organization/*)
> - Click Finish button on Editor composer
> => Unknown error and throw exception in console
> {noformat}
> 2013-08-08 15:20:18,549 | ERROR | Error during the processAction phase [portal:UIPortalApplication<http-nio-0.0.0.0-8080-exec-10>]
> java.lang.NullPointerException: null
> at org.exoplatform.portal.webui.portal.UIPortalComposer$FinishPageEditionActionListener.execute(UIPortalComposer.java:680) ~[exo.portal.webui.portal-3.5.6-PLF.jar:3.5.6-PLF]
>
> {noformat}
>
> Reproduce on edit site is the same
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 2 months
[JBoss JIRA] (GTNPORTAL-3044) Inconsistency in html elements of shared layout/user bar portlets
by Vu Viet Phuong (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-3044?page=com.atlassian.jira.pl... ]
Vu Viet Phuong updated GTNPORTAL-3044:
--------------------------------------
Status: Open (was: Pull Request Sent)
> Inconsistency in html elements of shared layout/user bar portlets
> -----------------------------------------------------------------
>
> Key: GTNPORTAL-3044
> URL: https://issues.jboss.org/browse/GTNPORTAL-3044
> Project: GateIn Portal
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Affects Versions: 3.6.0.Beta02
> Environment: jboss-jpp-6.1.0.ER1-prod-17052013.zip
> Reporter: Vlastislav Ramik
> Assignee: Tuyen Nguyen The
> Labels: JPP61-Test-dev
> Original Estimate: 6 hours
> Time Spent: 7 hours
> Remaining Estimate: 0 minutes
>
> Shared layout/user bar portlets (ie the bar that appears at the top of the page when you are a logged-in user) has following inconsistency:
> Portal Actions (that with the redhat icon): {noformat}<li title="Portal Actions" style="width: 62px" class="UITab portlet-menu-item">{noformat} The is also empty link as a child of the <li> but it has zero length.
> Site: {noformat}<a title="Sites" class="SitesIcon TBIcon" href="javascript:;">Site</a>{noformat}
> Group: {noformat}<span title="Group" class="GroupIcon TBIcon">Group</span>{noformat}
> Dashboard: If the user does not have any dashboard pages there is a link. If the user has a dashboard page there is a span. This is correct in my opinion.
> Site/Group/Dashboard Editor: {noformat}<a title="Site/Group/Dashboard Editor" href="#" class="EditorIcon TBIcon">Site/Group/Dashboard Editor</a>{noformat}
> All this leads to different looking cursors when you hovering the portlet.
> Portal Actions: arrow cursor
> Site: link cursor and text is highlighted
> Group:
> - arrow cursor when you are hovering that "people" icon
> - text cursor when you are hovering Group text
> Dashboard:
> - in case of none dashboard pages - it behaves the same as Site
> - in case on any dashboard pages - it behaves the same as Group
> Site/Group/Dashboard Editor: link cursor and text is highlighted
> The solution can be using css cursor (e.g. cursor: pointer; ) but cleaner solution would be probably unify it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 2 months
[JBoss JIRA] (GTNPORTAL-3267) MOP import resource
by Trong Tran (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-3267?page=com.atlassian.jira.pl... ]
Trong Tran commented on GTNPORTAL-3267:
---------------------------------------
I sent a PR for 3.5.x, so you could have a look if you want.
> MOP import resource
> -------------------
>
> Key: GTNPORTAL-3267
> URL: https://issues.jboss.org/browse/GTNPORTAL-3267
> Project: GateIn Portal
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: Java API
> Affects Versions: 3.5.6.Final
> Reporter: Boubaker Khanfir
> Assignee: Trong Tran
> Fix For: 3.5.7.Final
>
> Attachments: portal_mobile_2013-10-01_11-22-50.zip
>
> Original Estimate: 4 hours
> Time Spent: 1 day, 6 hours
> Remaining Estimate: 0 minutes
>
> MOP resource management is based on a custom marshaller/unmarshaller (org.exoplatform.portal.mop.management.binding.xml.*).
> I had used the mop managed resource in a custom case:
> * Create a new site.
> * Add PortalBody in a container.
> * Export site using GateIN management.
> * Re-import exported site.
> => Exception:
> {code}
> Operation exception for operation import-resource and address /mop [org.gatein.management.cli<pool-4-thread-1>]
> org.gatein.management.api.exceptions.OperationException: Exception reading data for import.
> at org.exoplatform.portal.mop.management.operations.MopImportResource.execute(MopImportResource.java:198) ~[exo.portal.component.portal-3.5.x-PLF-SNAPSHOT.jar:3.5.x-PLF-SNAPSHOT]
> at org.gatein.management.core.api.controller.SimpleManagementController.execute(SimpleManagementController.java:100) ~[gatein-management-core-1.1.0.Final.jar:1.1.0.Final]
> ...
> Caused by: org.staxnav.StaxNavException: Unexpected element 'page-body' at [row,col]:[167,21]
> at org.gatein.common.xml.stax.navigator.Exceptions.unexpectedElement(Exceptions.java:45) ~[exo.portal.component.common-3.5.x-PLF-SNAPSHOT.jar:3.5.x-PLF-SNAPSHOT]
> at org.exoplatform.portal.mop.management.binding.xml.AbstractMarshaller.unmarshalContainer(AbstractMarshaller.java:171) ~[exo.portal.component.portal-3.5.x-PLF-SNAPSHOT.jar:3.5.x-PLF-SNAPSHOT]
> at org.exoplatform.portal.mop.management.binding.xml.SiteLayoutMarshaller.unmarshalPortalConfig(SiteLayoutMarshaller.java:216) ~[exo.portal.component.portal-3.5.x-PLF-SNAPSHOT.jar:3.5.x-PLF-SNAPSHOT]
> at org.exoplatform.portal.mop.management.binding.xml.SiteLayoutMarshaller.unmarshal(SiteLayoutMarshaller.java:80) ~[exo.portal.component.portal-3.5.x-PLF-SNAPSHOT.jar:3.5.x-PLF-SNAPSHOT]
> ... 40 common frames omitted
> {code}
> To fix this I used the *default* MOP marshaller:
> {code}
> import org.exoplatform.portal.config.model.ModelUnmarshaller;
> // ...
> public PortalConfig unmarshal(InputStream inputStream) throws BindingException {
> try {
> return ModelUnmarshaller.unmarshall(PortalConfig.class, inputStream).getObject();
> } catch (Exception e) {
> throw new BindingException(e);
> }
> }
> //...
> public Page.PageSet unmarshal(InputStream inputStream) throws BindingException {
> try {
> return ModelUnmarshaller.unmarshall(Page.PageSet.class, inputStream).getObject();
> } catch (Exception e) {
> throw new BindingException(e);
> }
> }
> //...
> public PageNavigation unmarshal(InputStream inputStream) throws BindingException {
> try {
> return ModelUnmarshaller.unmarshall(PageNavigation.class, inputStream).getObject();
> } catch (Exception e) {
> throw new BindingException(e);
> }
> }
> // ...
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 2 months