June 2014 - gatein-issues - Jboss List Archives

[JBoss JIRA] (GTNPORTAL-3490) [Services Management gadget] Hard-coded English labels

by Trong Tran (JIRA)

[ https://issues.jboss.org/browse/GTNPORTAL-3490?focusedWorklogId=12431308&... ] Trong Tran logged work on GTNPORTAL-3490: ----------------------------------------- Author: Trong Tran Created on: 10/Jun/14 4:08 AM Start Date: 10/Jun/14 4:08 AM Worklog Time Spent: 1 hour Issue Time Tracking ------------------- Remaining Estimate: 0 minutes (was: 1 hour) Time Spent: 1 hour Worklog Id: (was: 12431308) > [Services Management gadget] Hard-coded English labels > ------------------------------------------------------ > > Key: GTNPORTAL-3490 > URL: https://issues.jboss.org/browse/GTNPORTAL-3490 > Project: GateIn Portal > Issue Type: Enhancement > Security Level: Public(Everyone can see) > Components: Internationalization and Localization > Affects Versions: 3.5.10.Final, 3.7.1.Final > Reporter: H. Trang Vu > Assignee: H. Trang Vu > Fix For: 3.7.2.Final, 3.9.0.Final > > Attachments: FR-LargeSize-Methods-Properties.png, FR-Properties.png > > Original Estimate: 1 hour > Time Spent: 1 hour > Remaining Estimate: 0 minutes > > Steps to reproduce: > * Login as root > * Go to Application Registry, add *Services Management* gadget into a category > * Open Dashboard > * Add *Services Management* gadget > * Switch to French. > * Open the gadget in both normal size and large size > ** "Methods", "Properties" are still in English. -- This message was sent by Atlassian JIRA (v6.2.3#6260)

10 years, 5 months

1
0
0 / 0

[JBoss JIRA] (GTNPORTAL-3509) [Application Registry] Missing validator when importing applications

by Lucas Ponce (JIRA)

[ https://issues.jboss.org/browse/GTNPORTAL-3509?page=com.atlassian.jira.pl... ] Lucas Ponce updated GTNPORTAL-3509: ----------------------------------- Status: Pull Request Sent (was: Open) Git Pull Request: https://github.com/gatein/gatein-portal/pull/876 > [Application Registry] Missing validator when importing applications > -------------------------------------------------------------------- > > Key: GTNPORTAL-3509 > URL: https://issues.jboss.org/browse/GTNPORTAL-3509 > Project: GateIn Portal > Issue Type: Enhancement > Security Level: Public(Everyone can see) > Affects Versions: 3.5.10.Final, 3.7.1.Final, 3.8.2.Final > Reporter: H. Trang Vu > Assignee: Lucas Ponce > Priority: Minor > Attachments: SiteRedirectsAndImportExportAdminPortlet-TooLongAppName-DisplayName.png > > > When applications are added by configuration or by importing automatically all applications, there isn't any check of application name while its value is read-only after the creation. These validators (length and pattern) however existent when adding or editing an application. As a consequence, some imported applications cannot be changed (Display Name, Description, Access Permission). > Steps to reproduce: > # Login as root > # Go to Application Registry > # Click *Site Redirects and Import/Export* (the last item of *Administration* category). > # Change nothing. Click Save. Warning message appears as follows. > {noformat} > The length of the text in field "Application Name" must be between "3" and "30" characters. > The length of the text in field "Display Name" must be between "3" and "30" characters. > {noformat} > * It is feasible to reduce "Display Name" but not "Application Name" at run time. -- This message was sent by Atlassian JIRA (v6.2.3#6260)

10 years, 5 months

1
0
0 / 0

[JBoss JIRA] (GTNPORTAL-3509) [Application Registry] Missing validator when importing applications

by Lucas Ponce (JIRA)

[ https://issues.jboss.org/browse/GTNPORTAL-3509?page=com.atlassian.jira.pl... ] Lucas Ponce reassigned GTNPORTAL-3509: -------------------------------------- Assignee: Lucas Ponce > [Application Registry] Missing validator when importing applications > -------------------------------------------------------------------- > > Key: GTNPORTAL-3509 > URL: https://issues.jboss.org/browse/GTNPORTAL-3509 > Project: GateIn Portal > Issue Type: Enhancement > Security Level: Public(Everyone can see) > Affects Versions: 3.5.10.Final, 3.7.1.Final, 3.8.2.Final > Reporter: H. Trang Vu > Assignee: Lucas Ponce > Priority: Minor > Attachments: SiteRedirectsAndImportExportAdminPortlet-TooLongAppName-DisplayName.png > > > When applications are added by configuration or by importing automatically all applications, there isn't any check of application name while its value is read-only after the creation. These validators (length and pattern) however existent when adding or editing an application. As a consequence, some imported applications cannot be changed (Display Name, Description, Access Permission). > Steps to reproduce: > # Login as root > # Go to Application Registry > # Click *Site Redirects and Import/Export* (the last item of *Administration* category). > # Change nothing. Click Save. Warning message appears as follows. > {noformat} > The length of the text in field "Application Name" must be between "3" and "30" characters. > The length of the text in field "Display Name" must be between "3" and "30" characters. > {noformat} > * It is feasible to reduce "Display Name" but not "Application Name" at run time. -- This message was sent by Atlassian JIRA (v6.2.3#6260)

10 years, 5 months

1
0
0 / 0

[JBoss JIRA] (GTNPORTAL-3509) [Application Registry] Missing validator when importing applications

by H. Trang Vu (JIRA)

[ https://issues.jboss.org/browse/GTNPORTAL-3509?page=com.atlassian.jira.pl... ] H. Trang Vu commented on GTNPORTAL-3509: ---------------------------------------- Thank you [~rutlucas]. It's OK if you include the fix for this issue in the same PR for GTNPORTAL-3494. The sanitization should be done for both category and application. > [Application Registry] Missing validator when importing applications > -------------------------------------------------------------------- > > Key: GTNPORTAL-3509 > URL: https://issues.jboss.org/browse/GTNPORTAL-3509 > Project: GateIn Portal > Issue Type: Enhancement > Security Level: Public(Everyone can see) > Affects Versions: 3.5.10.Final, 3.7.1.Final, 3.8.2.Final > Reporter: H. Trang Vu > Priority: Minor > Attachments: SiteRedirectsAndImportExportAdminPortlet-TooLongAppName-DisplayName.png > > > When applications are added by configuration or by importing automatically all applications, there isn't any check of application name while its value is read-only after the creation. These validators (length and pattern) however existent when adding or editing an application. As a consequence, some imported applications cannot be changed (Display Name, Description, Access Permission). > Steps to reproduce: > # Login as root > # Go to Application Registry > # Click *Site Redirects and Import/Export* (the last item of *Administration* category). > # Change nothing. Click Save. Warning message appears as follows. > {noformat} > The length of the text in field "Application Name" must be between "3" and "30" characters. > The length of the text in field "Display Name" must be between "3" and "30" characters. > {noformat} > * It is feasible to reduce "Display Name" but not "Application Name" at run time. -- This message was sent by Atlassian JIRA (v6.2.3#6260)

10 years, 5 months

1
0
0 / 0

[JBoss JIRA] (GTNPORTAL-3509) [Application Registry] Missing validator when importing applications

by Lucas Ponce (JIRA)

[ https://issues.jboss.org/browse/GTNPORTAL-3509?page=com.atlassian.jira.pl... ] Lucas Ponce commented on GTNPORTAL-3509: ---------------------------------------- Hello, I've prepared a fix for the side effect discovered on GTNPORTAL-3494. This new issue is related to same code, I can take this JIRA and propose a fix if you are OK. Please, let me know. Thanks, Lucas > [Application Registry] Missing validator when importing applications > -------------------------------------------------------------------- > > Key: GTNPORTAL-3509 > URL: https://issues.jboss.org/browse/GTNPORTAL-3509 > Project: GateIn Portal > Issue Type: Enhancement > Security Level: Public(Everyone can see) > Affects Versions: 3.5.10.Final, 3.7.1.Final, 3.8.2.Final > Reporter: H. Trang Vu > Priority: Minor > Attachments: SiteRedirectsAndImportExportAdminPortlet-TooLongAppName-DisplayName.png > > > When applications are added by configuration or by importing automatically all applications, there isn't any check of application name while its value is read-only after the creation. These validators (length and pattern) however existent when adding or editing an application. As a consequence, some imported applications cannot be changed (Display Name, Description, Access Permission). > Steps to reproduce: > # Login as root > # Go to Application Registry > # Click *Site Redirects and Import/Export* (the last item of *Administration* category). > # Change nothing. Click Save. Warning message appears as follows. > {noformat} > The length of the text in field "Application Name" must be between "3" and "30" characters. > The length of the text in field "Display Name" must be between "3" and "30" characters. > {noformat} > * It is feasible to reduce "Display Name" but not "Application Name" at run time. -- This message was sent by Atlassian JIRA (v6.2.3#6260)

10 years, 5 months

1
0
0 / 0

[JBoss JIRA] (GTNPORTAL-3494) Names of imported applications in Application Registry are not localized

by Lucas Ponce (JIRA)

[ https://issues.jboss.org/browse/GTNPORTAL-3494?page=com.atlassian.jira.pl... ] Lucas Ponce commented on GTNPORTAL-3494: ---------------------------------------- PR proposed and sent. > Names of imported applications in Application Registry are not localized > ------------------------------------------------------------------------- > > Key: GTNPORTAL-3494 > URL: https://issues.jboss.org/browse/GTNPORTAL-3494 > Project: GateIn Portal > Issue Type: Bug > Security Level: Public(Everyone can see) > Components: WebUI > Affects Versions: 3.8.1.Final > Reporter: Lucas Ponce > Assignee: Lucas Ponce > Fix For: 3.8.3.Final, 3.9.0.Final > > -- This message was sent by Atlassian JIRA (v6.2.3#6260)

10 years, 5 months

1
0
0 / 0

[JBoss JIRA] (GTNPORTAL-3494) Names of imported applications in Application Registry are not localized

by Lucas Ponce (JIRA)

[ https://issues.jboss.org/browse/GTNPORTAL-3494?page=com.atlassian.jira.pl... ] Lucas Ponce updated GTNPORTAL-3494: ----------------------------------- Status: Pull Request Sent (was: Pull Request Sent) Git Pull Request: https://github.com/gatein/gatein-portal/pull/862, https://github.com/gatein/gatein-portal/pull/876 (was: https://github.com/gatein/gatein-portal/pull/862) > Names of imported applications in Application Registry are not localized > ------------------------------------------------------------------------- > > Key: GTNPORTAL-3494 > URL: https://issues.jboss.org/browse/GTNPORTAL-3494 > Project: GateIn Portal > Issue Type: Bug > Security Level: Public(Everyone can see) > Components: WebUI > Affects Versions: 3.8.1.Final > Reporter: Lucas Ponce > Assignee: Lucas Ponce > Fix For: 3.8.3.Final, 3.9.0.Final > > -- This message was sent by Atlassian JIRA (v6.2.3#6260)

10 years, 5 months

1
0
0 / 0

[JBoss JIRA] (GTNPORTAL-3509) [Application Registry] Missing validator when importing applications

by H. Trang Vu (JIRA)

[ https://issues.jboss.org/browse/GTNPORTAL-3509?page=com.atlassian.jira.pl... ] H. Trang Vu updated GTNPORTAL-3509: ----------------------------------- Attachment: SiteRedirectsAndImportExportAdminPortlet-TooLongAppName-DisplayName.png When importing automatically all applications, it only replaces slashes by underscores in Application Name and Display Name in [ApplicationRegistryServiceImpl.java|https://github.com/gatein/gatein-port...] {code:title=ApplicationRegistryServiceImpl.java} // Need to sanitize portlet and application names in case they contain characters that would // cause an improper Application name portletApplicationName = portletApplicationName.replace('/', '_'); portletName = portletName.replace('/', '_'); {code} While adding an application to a category on UI, it must pass the rule of length limit and character validation. For example, in [UIApplicationForm.java|https://github.com/gatein/gatein-portal/blob/3.7.1...] {code:title=UIApplicationForm.java} public UIApplicationForm() throws Exception { addUIFormInput(new UIFormStringInput("applicationName", "applicationName", null).addValidator(MandatoryValidator.class) .addValidator(StringLengthValidator.class, 3, 30).addValidator(NameValidator.class)); addUIFormInput(new UIFormStringInput("displayName", "displayName", null).addValidator(StringLengthValidator.class, 3, 30).addValidator(NotHTMLTagValidator.class)); addUIFormInput(new UIFormTextAreaInput("description", "description", null).addValidator(NullFieldValidator.class) .addValidator(NotHTMLTagValidator.class)); } {code} > [Application Registry] Missing validator when importing applications > -------------------------------------------------------------------- > > Key: GTNPORTAL-3509 > URL: https://issues.jboss.org/browse/GTNPORTAL-3509 > Project: GateIn Portal > Issue Type: Enhancement > Security Level: Public(Everyone can see) > Affects Versions: 3.5.10.Final, 3.7.1.Final, 3.8.2.Final > Reporter: H. Trang Vu > Priority: Minor > Attachments: SiteRedirectsAndImportExportAdminPortlet-TooLongAppName-DisplayName.png > > > When applications are added by configuration or by importing automatically all applications, there isn't any check of application name while its value is read-only after the creation. These validators (length and pattern) however existent when adding or editing an application. As a consequence, some imported applications cannot be changed (Display Name, Description, Access Permission). > Steps to reproduce: > # Login as root > # Go to Application Registry > # Click *Site Redirects and Import/Export* (the last item of *Administration* category). > # Change nothing. Click Save. Warning message appears as follows. > {noformat} > The length of the text in field "Application Name" must be between "3" and "30" characters. > The length of the text in field "Display Name" must be between "3" and "30" characters. > {noformat} > * It is feasible to reduce "Display Name" but not "Application Name" at run time. -- This message was sent by Atlassian JIRA (v6.2.3#6260)

10 years, 5 months

1
0
0 / 0

[JBoss JIRA] (GTNPORTAL-3509) [Application Registry] Missing validator when importing applications

by H. Trang Vu (JIRA)

H. Trang Vu created GTNPORTAL-3509: -------------------------------------- Summary: [Application Registry] Missing validator when importing applications Key: GTNPORTAL-3509 URL: https://issues.jboss.org/browse/GTNPORTAL-3509 Project: GateIn Portal Issue Type: Enhancement Security Level: Public (Everyone can see) Affects Versions: 3.8.2.Final, 3.7.1.Final, 3.5.10.Final Reporter: H. Trang Vu Priority: Minor When applications are added by configuration or by importing automatically all applications, there isn't any check of application name while its value is read-only after the creation. These validators (length and pattern) however existent when adding or editing an application. As a consequence, some imported applications cannot be changed (Display Name, Description, Access Permission). Steps to reproduce: # Login as root # Go to Application Registry # Click *Site Redirects and Import/Export* (the last item of *Administration* category). # Change nothing. Click Save. Warning message appears as follows. {noformat} The length of the text in field "Application Name" must be between "3" and "30" characters. The length of the text in field "Display Name" must be between "3" and "30" characters. {noformat} * It is feasible to reduce "Display Name" but not "Application Name" at run time. -- This message was sent by Atlassian JIRA (v6.2.3#6260)

10 years, 5 months

1
0
0 / 0

[JBoss JIRA] (GTNPORTAL-3494) Names of imported applications in Application Registry are not localized

by Lucas Ponce (JIRA)

[ https://issues.jboss.org/browse/GTNPORTAL-3494?page=com.atlassian.jira.pl... ] Lucas Ponce commented on GTNPORTAL-3494: ---------------------------------------- Thanks for your comment. I'm going to review the patch and send a fix for this side effect. > Names of imported applications in Application Registry are not localized > ------------------------------------------------------------------------- > > Key: GTNPORTAL-3494 > URL: https://issues.jboss.org/browse/GTNPORTAL-3494 > Project: GateIn Portal > Issue Type: Bug > Security Level: Public(Everyone can see) > Components: WebUI > Affects Versions: 3.8.1.Final > Reporter: Lucas Ponce > Assignee: Lucas Ponce > Fix For: 3.8.3.Final, 3.9.0.Final > > -- This message was sent by Atlassian JIRA (v6.2.3#6260)

10 years, 5 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

gatein-issues June 2014