[JBoss JIRA] (GTNPORTAL-3537) "Import applications" fails
by Trong Tran (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-3537?page=com.atlassian.jira.pl... ]
Trong Tran commented on GTNPORTAL-3537:
---------------------------------------
the *#sanitizePortletName* method not only replace "/" by "_", it also truncates the "unique" value with *#substring(0, MAX - 1)* which MAX is 30. That's mean that the "sanitized" value is max 29 length.
Unfortunately the max length of "unique" value can be 30 characters:
{code}
String unique = portletName.substring(0,Math.min(portletName.length(), 20)) + String.valueOf(contentId.hashCode());
{code}
Therefore, in the case if we have two different "unique" values with "local._juzu-tutorial1630574212" and "local._juzu-tutorial1630574210". After sanitization, the "sanitized" values will be the same "local._juzu-tutorial163057421" ==> It raises the problem.
So the proper fix for this could just be modifying:
{code}
if (sizePortletName >= MAX) {
- sanitizedPortletName = sanitizedPortletName.substring(0, MAX - 1);
+ sanitizedPortletName = sanitizedPortletName.substring(0, MAX);
} else if (sizePortletName <= MIN) {
sanitizedPortletName += "Portlet";
{code}
> "Import applications" fails
> ---------------------------
>
> Key: GTNPORTAL-3537
> URL: https://issues.jboss.org/browse/GTNPORTAL-3537
> Project: GateIn Portal
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Affects Versions: 3.9.0.Final
> Reporter: Trong Tran
> Fix For: 3.9.0.Final
>
> Attachments: juzu-tutorial-examples-gatein.war
>
>
> "Import applications" fails when the application name is too long AND there are two portlets with similar name (such as "Weather1" and "Weather2")
> I attached the juzu portlets example war which we can use to reproduce the problem.
> P/S: I notice that this problem is a regression from GTNPORTAL-3519
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
10 years, 5 months
[JBoss JIRA] (GTNPORTAL-3537) "Import applications" fails
by Juraci Paixão Kröhling (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-3537?page=com.atlassian.jira.pl... ]
Juraci Paixão Kröhling commented on GTNPORTAL-3537:
---------------------------------------------------
[~trong.tran], would you have a sample result for the two steps? I'd be interested in what's the end value for this method, ie, the "sanitized" value, and compare with the "unique". I think the "unique" might contain slashes, which are not valid HTML "id" properties, used in some places ([~rutlucas] had a problem related to this in the past).
> "Import applications" fails
> ---------------------------
>
> Key: GTNPORTAL-3537
> URL: https://issues.jboss.org/browse/GTNPORTAL-3537
> Project: GateIn Portal
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Affects Versions: 3.9.0.Final
> Reporter: Trong Tran
> Fix For: 3.9.0.Final
>
> Attachments: juzu-tutorial-examples-gatein.war
>
>
> "Import applications" fails when the application name is too long AND there are two portlets with similar name (such as "Weather1" and "Weather2")
> I attached the juzu portlets example war which we can use to reproduce the problem.
> P/S: I notice that this problem is a regression from GTNPORTAL-3519
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
10 years, 5 months
[JBoss JIRA] (GTNPORTAL-3537) "Import applications" fails
by Trong Tran (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-3537?page=com.atlassian.jira.pl... ]
Trong Tran commented on GTNPORTAL-3537:
---------------------------------------
apparently it can be fixed with following change BUT not sure if it's a complete fix.
{code}
private String uniqueDefinitionName(String portletName, String contentId) {
String unique = portletName.substring(0,Math.min(portletName.length(), 20)) + String.valueOf(contentId.hashCode());
- String sanitized = sanitizePortletName(unique);
- return sanitized;
+ return unique;
}
{code}
I do think we could completely re-work on this "Import applications". We have been working back and forth on several issues of this function.
> "Import applications" fails
> ---------------------------
>
> Key: GTNPORTAL-3537
> URL: https://issues.jboss.org/browse/GTNPORTAL-3537
> Project: GateIn Portal
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Affects Versions: 3.9.0.Final
> Reporter: Trong Tran
> Fix For: 3.9.0.Final
>
> Attachments: juzu-tutorial-examples-gatein.war
>
>
> "Import applications" fails when the application name is too long AND there are two portlets with similar name (such as "Weather1" and "Weather2")
> I attached the juzu portlets example war which we can use to reproduce the problem.
> P/S: I notice that this problem is a regression from GTNPORTAL-3519
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
10 years, 5 months
[JBoss JIRA] (GTNPORTAL-3519) "Import applications" fails when remote portlet name clashes with local portlet
by Trong Tran (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-3519?page=com.atlassian.jira.pl... ]
Trong Tran commented on GTNPORTAL-3519:
---------------------------------------
I notice that this fix causes another problem reported at GTNPORTAL-3537
> "Import applications" fails when remote portlet name clashes with local portlet
> -------------------------------------------------------------------------------
>
> Key: GTNPORTAL-3519
> URL: https://issues.jboss.org/browse/GTNPORTAL-3519
> Project: GateIn Portal
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Reporter: Juraci Paixão Kröhling
> Assignee: Juraci Paixão Kröhling
> Fix For: 3.8.5.Final, 3.9.0.Final
>
>
> The "import applications" on the application registry fails when there's a remote portlet with the same name as a local portlet, due to "unknown error" on the user interface, and "Cannot create a content with a content id ... with an existing different content id" in the logs.
> More details on BZ#1117813 .
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
10 years, 5 months
[JBoss JIRA] (GTNPORTAL-3537) "Import applications" fails
by Trong Tran (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-3537?page=com.atlassian.jira.pl... ]
Trong Tran updated GTNPORTAL-3537:
----------------------------------
Attachment: juzu-tutorial-examples-gatein.war
> "Import applications" fails
> ---------------------------
>
> Key: GTNPORTAL-3537
> URL: https://issues.jboss.org/browse/GTNPORTAL-3537
> Project: GateIn Portal
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Affects Versions: 3.9.0.Final
> Reporter: Trong Tran
> Fix For: 3.9.0.Final
>
> Attachments: juzu-tutorial-examples-gatein.war
>
>
> "Import applications" fails when the application name is too long AND there are two portlets with similar name (such as "Weather1" and "Weather2")
> I attached the juzu portlets example war which we can use to reproduce the problem.
> P/S: I notice that this problem is a regression from GTNPORTAL-3519
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
10 years, 5 months
[JBoss JIRA] (GTNPORTAL-3537) "Import applications" fails
by Trong Tran (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-3537?page=com.atlassian.jira.pl... ]
Trong Tran updated GTNPORTAL-3537:
----------------------------------
Fix Version/s: 3.9.0.Final
Description:
"Import applications" fails when the application name is too long AND there are two portlets with similar name (such as "Weather1" and "Weather2")
I attached the juzu portlets example war which we can use to reproduce the problem.
P/S: I notice that this problem is a regression from GTNPORTAL-3519
was:
"Import applications" fails when the application name is too long AND there are two portlets with similar name (such as "Weather1" and "Weather2")
I attached the juzu portlets example war which we can use to reproduce the problem.
Due Date: 12/Sep/14
Affects Version/s: 3.9.0.Final
> "Import applications" fails
> ---------------------------
>
> Key: GTNPORTAL-3537
> URL: https://issues.jboss.org/browse/GTNPORTAL-3537
> Project: GateIn Portal
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Affects Versions: 3.9.0.Final
> Reporter: Trong Tran
> Fix For: 3.9.0.Final
>
>
> "Import applications" fails when the application name is too long AND there are two portlets with similar name (such as "Weather1" and "Weather2")
> I attached the juzu portlets example war which we can use to reproduce the problem.
> P/S: I notice that this problem is a regression from GTNPORTAL-3519
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
10 years, 5 months
[JBoss JIRA] (GTNPORTAL-3536) Localization of tooltip and confirmation button when enable/disable user is not correct
by Tuyen Nguyen The (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-3536?page=com.atlassian.jira.pl... ]
Tuyen Nguyen The updated GTNPORTAL-3536:
----------------------------------------
Affects Version/s: 3.7.0.Final
> Localization of tooltip and confirmation button when enable/disable user is not correct
> ---------------------------------------------------------------------------------------
>
> Key: GTNPORTAL-3536
> URL: https://issues.jboss.org/browse/GTNPORTAL-3536
> Project: GateIn Portal
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Affects Versions: 3.7.0.Final
> Reporter: Tuyen Nguyen The
> Assignee: Tuyen Nguyen The
> Attachments: confirmation_in_english.png, confirmation_in_french.png, enable_disable_tooltip.png
>
>
> Case to reproduce:
> - Start gatein then login with user root
> - Switch language to French
> - Goto User and Group management portlet
> - Hover on icon enable/disable
> ==> Tooltip message is always in English => NOK
> - Click to disable user root
> - Confirmation popup is show in French => OK
> - Change language to English
> - Click to disable user root
> - Confirmation popup is show, the message is in English but button is still in French => NOK
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
10 years, 5 months
[JBoss JIRA] (GTNPORTAL-3537) "Import applications" fails
by Trong Tran (JIRA)
Trong Tran created GTNPORTAL-3537:
-------------------------------------
Summary: "Import applications" fails
Key: GTNPORTAL-3537
URL: https://issues.jboss.org/browse/GTNPORTAL-3537
Project: GateIn Portal
Issue Type: Bug
Security Level: Public (Everyone can see)
Reporter: Trong Tran
"Import applications" fails when the application name is too long AND there are two portlets with similar name (such as "Weather1" and "Weather2")
I attached the juzu portlets example war which we can use to reproduce the problem.
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
10 years, 5 months
[JBoss JIRA] (GTNPORTAL-3536) Localization of tooltip and confirmation button when enable/disable user is not correct
by Tuyen Nguyen The (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-3536?page=com.atlassian.jira.pl... ]
Tuyen Nguyen The updated GTNPORTAL-3536:
----------------------------------------
Attachment: enable_disable_tooltip.png
confirmation_in_french.png
confirmation_in_english.png
> Localization of tooltip and confirmation button when enable/disable user is not correct
> ---------------------------------------------------------------------------------------
>
> Key: GTNPORTAL-3536
> URL: https://issues.jboss.org/browse/GTNPORTAL-3536
> Project: GateIn Portal
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Reporter: Tuyen Nguyen The
> Assignee: Tuyen Nguyen The
> Attachments: confirmation_in_english.png, confirmation_in_french.png, enable_disable_tooltip.png
>
>
> Case to reproduce:
> - Start gatein then login with user root
> - Switch language to French
> - Goto User and Group management portlet
> - Hover on icon enable/disable
> ==> Tooltip message is always in English => NOK
> - Click to disable user root
> - Confirmation popup is show in French => OK
> - Change language to English
> - Click to disable user root
> - Confirmation popup is show, the message is in English but button is still in French => NOK
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
10 years, 5 months