[
https://issues.jboss.org/browse/GTNPORTAL-2751?page=com.atlassian.jira.pl...
]
Peter Palaga commented on GTNPORTAL-2751:
-----------------------------------------
I need to correct myself: there cannot be several user navigations, there is always just
one, like it is the case with site navigation.
bq. One of the issues that may arise however is what the priority would be for
navigation.xml that doesn't provide it. Internally it's an int so it must have
some value. Also it seems that's it's quite good to have priority as required for
group and user navigations, so what do you do if they don't provide one ?
The internal {{int}} can be handled somehow: it can be changed to {{Integer}} or one can
introduce a special value, e.g. -1 for the undefined state.
In Group navs, where it is logically required one can (i) either throw an exception or
(ii) assume some default value, e.g. 1. (ii) is probably better.
<priority> in navigation.xml files ignored for merge importMode
----------------------------------------------------------------
Key: GTNPORTAL-2751
URL:
https://issues.jboss.org/browse/GTNPORTAL-2751
Project: GateIn Portal
Issue Type: Task
Security Level: Public(Everyone can see)
Reporter: Peter Palaga
Steps to reproduce:
Clone the Portal Extension Quickstart and deploy it changing the {{<priority>}}
value in
{{war/src/main/webapp/WEB-INF/conf/sample-ext/portal/group/platform/administrators/navigation.xml}}.
NOT OK: The changes have no effect, because priority is ignored in
{{org.exoplatform.portal.mop.importer.NavigationImporter.perform()}} with {{importMode}}
{{merge}}.
h3. Solution Proposal A
* Make {{<priority>}} optional in {{gatein_objects}} XSD and
{{NavigationMarshaller.unmarshalNavigation(StaxNavigator<Element>)}}
* Explicitly state in the documentation [1] that {{<priority>}} is considered only
if not already set (first wins).
h3. Solution Proposal B
* Make {{<priority>}} optional in {{gatein_objects}} XSD and
{{NavigationMarshaller.unmarshalNavigation(StaxNavigator<Element>)}}
* Change the behavior of
{{NavigationMarshaller.unmarshalNavigation(StaxNavigator<Element>)}} to the effect
that {{<priority>}} is handled in the same way as navigation nodes: it is used or
ignored according to the chosen {{importMode}}. Esp. for {{importMode}} {{merge}} the last
read {{<priority>}} should win.
* Document it in [1]
For both A and B the most or all occutences of {{<priority>}} should be removed
from Portal Extension Quickstart.
[1] [
https://docs.jboss.org/author/display/GTNPORTAL35/Portal+Navigation+Confi...]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:
http://www.atlassian.com/software/jira