[gatein-issues] [JBoss JIRA] Work started: (GTNPORTAL-944) Improve Error Management in Skin Service

Improve Error Management in Skin Service ---------------------------------------- Key: GTNPORTAL-944 URL: https://jira.jboss.org/jira/browse/GTNPORTAL-944 Project: GateIn Portal Issue Type: Bug Security Level: Public(Everyone can see) Components: User Interface, WebUI Affects Versions: 3.0.0-GA Reporter: Tugdual Grall Assignee: Minh Hoang TO Fix For: 3.1.0-GA Original Estimate: 1 day Remaining Estimate: 1 day When creating new Skin the developer/web designer has multiple place files to modify to set the correct name/uri of the skin - web.xml should contains the name - Stylesheet.css should do a reference to the correct webapp root - ... When one of this name is not corect, the system is not working and some error are raised. For example a NPE is raised when the main CSS is not corrected configure, this occurs when the skin-web-app/skin/StyleSheet.css does not contais the correct URI @import url(<INVALIDURI>/UIPortalApplicationSkin.css); Trace: SEVERE: Could not render css /gatein-training-skin/skin/Stylesheet-lt.css java.lang.NullPointerException at org.exoplatform.portal.resource.SkinService.processCSSRecursively(SkinService.java:437) at org.exoplatform.portal.resource.SkinService.processCSS(SkinService.java:429) at org.exoplatform.portal.resource.SkinService.renderCSS(SkinService.java:341) at org.exoplatform.portal.application.ResourceRequestFilter.doFilter(ResourceRequestFilter.java:127) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:293) at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:849) at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:583) at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:454) at java.lang.Thread.run(Thread.java:637) We should put proper message in the log file with the place where the configuration is not correct. for example: - Invalid <CSS FILE> configuration, Skin service cannot load the skin "TrainingSkin/UIPortalApplicationSkin.css"