[JBoss JIRA] (GTNWCI-29) NullPointerException in WCILoginModule when TicketService does not return credentials
by Marek Posolda (Created) (JIRA)
NullPointerException in WCILoginModule when TicketService does not return credentials
-------------------------------------------------------------------------------------
Key: GTNWCI-29
URL: https://issues.jboss.org/browse/GTNWCI-29
Project: GateIn Web Container Integration
Issue Type: Bug
Affects Versions: 2.1.0-GA
Reporter: Marek Posolda
Priority: Minor
In WCILoginModule is code like:
{code}
Credentials credentials = GenericAuthentication.TICKET_SERVICE.validateTicket(password, true);
sharedState.put("javax.security.auth.login.name", credentials.getUsername());
sharedState.put("javax.security.auth.login.password", credentials.getPassword());
{code}
in case that ticketService return null, we have NPE when calling credentials.getUsername().
In this case, NullPointerException is catched and rethrown as LoginException and WCILoginModule is declared as optional in GateIn/EPP. So it's minor issue without effect to users. Inspite of it, I think cleaner to handle this case in better way than throwing NullPointerException.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years, 5 months
[JBoss JIRA] (GTNPORTAL-2293) handle forgot usernames and passwords better
by Matt Wringe (Created) (JIRA)
handle forgot usernames and passwords better
--------------------------------------------
Key: GTNPORTAL-2293
URL: https://issues.jboss.org/browse/GTNPORTAL-2293
Project: GateIn Portal
Issue Type: Feature Request
Security Level: Public (Everyone can see)
Reporter: Matt Wringe
a couple of things which should be changed with how the forgot username/password is handled
1) there should be something in the log about the email service not being setup when a user tries to get their password reset. Currently all the pops up is a message saying "Can't Send Email", this doesn't help determine why the server can't send the email.
2) if the email service is currently not configured, instead of making the user enter their username or email, they should be displayed with an error message right away when they click to reset their email/password. The "Can't send email" message is not clear if there is something wrong with the users account (ie thats not the email or username they used to register with) or if they just need to try again or at a later time.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years, 5 months