[JBoss JIRA] (GTNPORTAL-3314) Import page fails in pages.xml with empty <preferences> element
by Peter Palaga (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-3314?page=com.atlassian.jira.pl... ]
Peter Palaga updated GTNPORTAL-3314:
------------------------------------
Status: Resolved (was: Pull Request Sent)
Fix Version/s: 3.6.4.Final
3.7.0.Final
Resolution: Done
> Import page fails in pages.xml with empty <preferences> element
> ---------------------------------------------------------------
>
> Key: GTNPORTAL-3314
> URL: https://issues.jboss.org/browse/GTNPORTAL-3314
> Project: GateIn Portal
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Reporter: Lucas Ponce
> Assignee: Lucas Ponce
> Fix For: 3.6.4.Final, 3.7.0.Final
>
>
> Importing a page.xml:
> <page>
> <name>Tab_Default</name>
> <title>Tab_Default</title>
> <portlet-application>
> <portlet>
> <application-ref>dashboard</application-ref>
> <portlet-ref>DashboardPortlet</portlet-ref>
> <preferences/>
> </portlet>
> <access-permissions>Everyone</access-permissions>
> <show-info-bar>false</show-info-bar>
> <show-application-state>true</show-application-state>
> </portlet-application>
> </page>
> AbstractMarshaller fails when processing <preferences/> empty tag.
> This case is used in template/user/pages.xml
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 4 months
[JBoss JIRA] (GTNPORTAL-3314) Import page fails in pages.xml with empty <preferences> element
by Peter Palaga (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-3314?page=com.atlassian.jira.pl... ]
Peter Palaga commented on GTNPORTAL-3314:
-----------------------------------------
I am OK with the patch:
* It is consistent with gatein_objects_1_5.xsd.
* Nice that it contains a stax parser test case for the situation.
* The test case does not close the input stream properly, but there are many occurences of the same in {{PageMarshallerTest}}. I have created GTNPORTAL-3319 to track it.
* The analogous jibx parser seems to accept empty {{<preferences>}} too: https://github.com/gatein/gatein-portal/blob/master/component/portal/src/... but unfortunatelly, there is no test case to prove that. But there are close to zero jibx tests in general.
> Import page fails in pages.xml with empty <preferences> element
> ---------------------------------------------------------------
>
> Key: GTNPORTAL-3314
> URL: https://issues.jboss.org/browse/GTNPORTAL-3314
> Project: GateIn Portal
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Reporter: Lucas Ponce
> Assignee: Lucas Ponce
>
> Importing a page.xml:
> <page>
> <name>Tab_Default</name>
> <title>Tab_Default</title>
> <portlet-application>
> <portlet>
> <application-ref>dashboard</application-ref>
> <portlet-ref>DashboardPortlet</portlet-ref>
> <preferences/>
> </portlet>
> <access-permissions>Everyone</access-permissions>
> <show-info-bar>false</show-info-bar>
> <show-application-state>true</show-application-state>
> </portlet-application>
> </page>
> AbstractMarshaller fails when processing <preferences/> empty tag.
> This case is used in template/user/pages.xml
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 4 months