[JBoss JIRA] (GTNSSO-28) realm is wrong adds an extra g in the realm name with OpenAM 11
by Marek Posolda (JIRA)
[ https://issues.jboss.org/browse/GTNSSO-28?page=com.atlassian.jira.plugin.... ]
Marek Posolda updated GTNSSO-28:
--------------------------------
Priority: Major (was: Blocker)
> realm is wrong adds an extra g in the realm name with OpenAM 11
> ---------------------------------------------------------------
>
> Key: GTNSSO-28
> URL: https://issues.jboss.org/browse/GTNSSO-28
> Project: GateIn SSO
> Issue Type: Bug
> Affects Versions: 1.4.0.Beta01
> Environment: Using OpenAM 11 - using the plugin with Exo Platform but imagine this is probably the same for anything using gatein-sso for CDSSO with OpenAM 11
> Reporter: Michael McKinsey
> Assignee: Marek Posolda
>
> The realm name is coming up wrong with an extra g which I believe is causing the error #403x
> https://./openam/cdcservlet?realm=gatein&goto=https%3A%2F%2F.%3A8443%2Fportal%2Finitiatessologin&ProviderID=https%3A%2F%2F.%3A8443%2Fportal%2Finitiatessologin%2F%3FRealm%3Dggatein&RequestID=71288&IssueInstant=2014-05-08T01%3A10%3A30Z&MajorVersion=1&MinorVersion=0
> notice realm is ggatein
> I found a reference to the extra g:
> https://github.com/gatein/gatein-sso/blob/b3b0e3fb9fd5d9498a97e89357603d1...
> It says:
> // We need to use Realm=g because of bug (or strange behaviour) of OpenAM, which cuts first character of realmName during parsing
> String providerId = agentUrl + "/?Realm=g" + openSSORealm;
> I am guessing this was needed with OpenAM 10 but is causing an error with OpenAM 11. I was trying to fix this myself but I can't get gatein-sso to build in my environment just yet.
--
This message was sent by Atlassian JIRA
(v6.2.3#6260)
11 years, 10 months
[JBoss JIRA] (GTNSSO-28) realm is wrong adds an extra g in the realm name with OpenAM 11
by Marek Posolda (JIRA)
[ https://issues.jboss.org/browse/GTNSSO-28?page=com.atlassian.jira.plugin.... ]
Marek Posolda commented on GTNSSO-28:
-------------------------------------
yes, you're right. This was needed for OpenAM 9 and 10, which are currently supported versions. For OpenAM 11, you can either workaround and build gatein-sso in your environment, or if you have time, you can send PR with more proper fix, which will work in both OpenAM 9,10 and 11 . I think proper fix will need to add another init parameter (either with OpenAM version or name of the realm for ProviderID part).
For build gatein-sso, you just need java 6 (or later) and maven 3.0.3 (or later) and run just "mvn clean install" from "gatein-sso" directory. If it doesn't work, feel free to create another JIRA and please attach details about your environment (java version, maven version, OS etc).
> realm is wrong adds an extra g in the realm name with OpenAM 11
> ---------------------------------------------------------------
>
> Key: GTNSSO-28
> URL: https://issues.jboss.org/browse/GTNSSO-28
> Project: GateIn SSO
> Issue Type: Bug
> Affects Versions: 1.4.0.Beta01
> Environment: Using OpenAM 11 - using the plugin with Exo Platform but imagine this is probably the same for anything using gatein-sso for CDSSO with OpenAM 11
> Reporter: Michael McKinsey
> Assignee: Marek Posolda
> Priority: Blocker
>
> The realm name is coming up wrong with an extra g which I believe is causing the error #403x
> https://./openam/cdcservlet?realm=gatein&goto=https%3A%2F%2F.%3A8443%2Fportal%2Finitiatessologin&ProviderID=https%3A%2F%2F.%3A8443%2Fportal%2Finitiatessologin%2F%3FRealm%3Dggatein&RequestID=71288&IssueInstant=2014-05-08T01%3A10%3A30Z&MajorVersion=1&MinorVersion=0
> notice realm is ggatein
> I found a reference to the extra g:
> https://github.com/gatein/gatein-sso/blob/b3b0e3fb9fd5d9498a97e89357603d1...
> It says:
> // We need to use Realm=g because of bug (or strange behaviour) of OpenAM, which cuts first character of realmName during parsing
> String providerId = agentUrl + "/?Realm=g" + openSSORealm;
> I am guessing this was needed with OpenAM 10 but is causing an error with OpenAM 11. I was trying to fix this myself but I can't get gatein-sso to build in my environment just yet.
--
This message was sent by Atlassian JIRA
(v6.2.3#6260)
11 years, 10 months
[JBoss JIRA] (GTNPORTAL-3482) Deprecated class of UserImpl
by Tuyen Nguyen The (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-3482?page=com.atlassian.jira.pl... ]
Tuyen Nguyen The updated GTNPORTAL-3482:
----------------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/gatein/gatein-portal/pull/855
> Deprecated class of UserImpl
> ----------------------------
>
> Key: GTNPORTAL-3482
> URL: https://issues.jboss.org/browse/GTNPORTAL-3482
> Project: GateIn Portal
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Reporter: Tuyen Nguyen The
> Assignee: Tuyen Nguyen The
> Priority: Minor
>
> *org.exoplatform.services.organization.idm.UserImpl* class was created in order to make a workaround to display the *userName* if exist.
> This class should be *deleted* in Gatein according to a *TODO* annotation mentioned in top. In fact, the related issue *was fixed* in JCR 1.15, see:
> https://issues.jboss.org/browse/EXOJCR-1780.
>
> the correction was made into the class *org.exoplatform.services.organization.impl.UserImpl* on method getFullName (responsible for displaying the username)
> {code:title=UserImpl.java|borderStyle=solid}
> // wrapper method
> public String getFullName()
> {
> return getDisplayName();
> }
> public String getDisplayName()
> {
> return displayName != null ? displayName : getFirstName() + " " + getLastName();
> }
> {code}
> So no need to *...organization.idm.UserImpl* class any more as the class *org.exoplatform.services.organization.impl.UserImpl* was fixed.
--
This message was sent by Atlassian JIRA
(v6.2.3#6260)
11 years, 10 months
[JBoss JIRA] (GTNPORTAL-3482) Deprecated class of UserImpl
by Tuyen Nguyen The (JIRA)
Tuyen Nguyen The created GTNPORTAL-3482:
-------------------------------------------
Summary: Deprecated class of UserImpl
Key: GTNPORTAL-3482
URL: https://issues.jboss.org/browse/GTNPORTAL-3482
Project: GateIn Portal
Issue Type: Task
Security Level: Public (Everyone can see)
Reporter: Tuyen Nguyen The
Assignee: Tuyen Nguyen The
Priority: Minor
*org.exoplatform.services.organization.idm.UserImpl* class was created in order to make a workaround to display the *userName* if exist.
This class should be *deleted* in Gatein according to a *TODO* annotation mentioned in top. In fact, the related issue *was fixed* in JCR 1.15, see:
https://issues.jboss.org/browse/EXOJCR-1780.
the correction was made into the class *org.exoplatform.services.organization.impl.UserImpl* on method getFullName (responsible for displaying the username)
{code:title=UserImpl.java|borderStyle=solid}
// wrapper method
public String getFullName()
{
return getDisplayName();
}
public String getDisplayName()
{
return displayName != null ? displayName : getFirstName() + " " + getLastName();
}
{code}
So no need to *...organization.idm.UserImpl* class any more as the class *org.exoplatform.services.organization.impl.UserImpl* was fixed.
--
This message was sent by Atlassian JIRA
(v6.2.3#6260)
11 years, 10 months
[JBoss JIRA] (GTNPORTAL-3475) NPE in LinkedList$ListItr.next when iterating over UIGroupMembershipSelect.getListMemberhip()
by RH Bugzilla Integration (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-3475?page=com.atlassian.jira.pl... ]
RH Bugzilla Integration commented on GTNPORTAL-3475:
----------------------------------------------------
Peter Palaga <ppalaga(a)redhat.com> changed the Status of [bug 1096190|https://bugzilla.redhat.com/show_bug.cgi?id=1096190] from ASSIGNED to POST
> NPE in LinkedList$ListItr.next when iterating over UIGroupMembershipSelect.getListMemberhip()
> ---------------------------------------------------------------------------------------------
>
> Key: GTNPORTAL-3475
> URL: https://issues.jboss.org/browse/GTNPORTAL-3475
> Project: GateIn Portal
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Reporter: Peter Palaga
> Attachments: GTNPORTAL-3475.log
>
>
> Looks like a concurrent modification of the {{LinkedList}} refered to by {{UIGroupMembershipSelect.listMemberhip}}, because:
> i. It is not always reproducible, the NPE occurs roughly once per 10 attempts.
> ii. It happens on line {{next = next.next}} of the JRE's {{LinkedList.ListItr}} where it is hard to thing of anything else than concurrent modification as a cause.
> Steps to reproduce:
> (1) Start clean Portal instance for the first time
> (2) Go to Application Registry
> (3) Import Applications
> Not OK: There is an NPE logged (the whole log is attached):
> {code:none}
> Caused by: java.lang.NullPointerException
> at java.util.LinkedList$ListItr.next(LinkedList.java:891) [rt.jar:1.7.0_55]
> at UIGroupMembershipSelector.run(UIGroupMembershipSelector.gtmpl:20) at org.exoplatform.groovyscript.GroovyScript.render(GroovyScript.java:99) [exo.portal.component.scripting-3.8.0.Beta02-SNAPSHOT.jar:3.8.0.Beta02-SNAPSHOT]
> at org.exoplatform.groovyscript.GroovyTemplate.render(GroovyTemplate.java:115) [exo.portal.component.scripting-3.8.0.Beta02-SNAPSHOT.jar:3.8.0.Beta02-SNAPSHOT]
> {code}
> Expected: No NPE
--
This message was sent by Atlassian JIRA
(v6.2.3#6260)
11 years, 10 months
[JBoss JIRA] (GTNPORTAL-3475) NPE in LinkedList$ListItr.next when iterating over UIGroupMembershipSelect.getListMemberhip()
by Peter Palaga (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-3475?page=com.atlassian.jira.pl... ]
Peter Palaga updated GTNPORTAL-3475:
------------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/gatein/gatein-portal/pull/854
> NPE in LinkedList$ListItr.next when iterating over UIGroupMembershipSelect.getListMemberhip()
> ---------------------------------------------------------------------------------------------
>
> Key: GTNPORTAL-3475
> URL: https://issues.jboss.org/browse/GTNPORTAL-3475
> Project: GateIn Portal
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Reporter: Peter Palaga
> Attachments: GTNPORTAL-3475.log
>
>
> Looks like a concurrent modification of the {{LinkedList}} refered to by {{UIGroupMembershipSelect.listMemberhip}}, because:
> i. It is not always reproducible, the NPE occurs roughly once per 10 attempts.
> ii. It happens on line {{next = next.next}} of the JRE's {{LinkedList.ListItr}} where it is hard to thing of anything else than concurrent modification as a cause.
> Steps to reproduce:
> (1) Start clean Portal instance for the first time
> (2) Go to Application Registry
> (3) Import Applications
> Not OK: There is an NPE logged (the whole log is attached):
> {code:none}
> Caused by: java.lang.NullPointerException
> at java.util.LinkedList$ListItr.next(LinkedList.java:891) [rt.jar:1.7.0_55]
> at UIGroupMembershipSelector.run(UIGroupMembershipSelector.gtmpl:20) at org.exoplatform.groovyscript.GroovyScript.render(GroovyScript.java:99) [exo.portal.component.scripting-3.8.0.Beta02-SNAPSHOT.jar:3.8.0.Beta02-SNAPSHOT]
> at org.exoplatform.groovyscript.GroovyTemplate.render(GroovyTemplate.java:115) [exo.portal.component.scripting-3.8.0.Beta02-SNAPSHOT.jar:3.8.0.Beta02-SNAPSHOT]
> {code}
> Expected: No NPE
--
This message was sent by Atlassian JIRA
(v6.2.3#6260)
11 years, 10 months
[JBoss JIRA] (GTNPORTAL-3475) NPE in LinkedList$ListItr.next when iterating over UIGroupMembershipSelect.getListMemberhip()
by Peter Palaga (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-3475?page=com.atlassian.jira.pl... ]
Peter Palaga commented on GTNPORTAL-3475:
-----------------------------------------
The two requests are sent only if my Chrome extension (1) is active. When I disable it, there is only one request sent. The extension used to work without problems before, so it is maybe a bug in the current Chrome version.
But anyway, given that two concurrent requests are possible by design of WebUI, this needs to be fixed in {{UIGroupMembershipSelector}}. The second concurrent request can theoretically also come from some other source, say a browser refresh (combined with an overloaded server) or similar. So, I am going to fix this in UIGroupMembershipSelector through loading listMemberhip in a thread-safe manner.
(1) https://github.com/ppalaga/misc-content-scripts
> NPE in LinkedList$ListItr.next when iterating over UIGroupMembershipSelect.getListMemberhip()
> ---------------------------------------------------------------------------------------------
>
> Key: GTNPORTAL-3475
> URL: https://issues.jboss.org/browse/GTNPORTAL-3475
> Project: GateIn Portal
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Reporter: Peter Palaga
> Attachments: GTNPORTAL-3475.log
>
>
> Looks like a concurrent modification of the {{LinkedList}} refered to by {{UIGroupMembershipSelect.listMemberhip}}, because:
> i. It is not always reproducible, the NPE occurs roughly once per 10 attempts.
> ii. It happens on line {{next = next.next}} of the JRE's {{LinkedList.ListItr}} where it is hard to thing of anything else than concurrent modification as a cause.
> Steps to reproduce:
> (1) Start clean Portal instance for the first time
> (2) Go to Application Registry
> (3) Import Applications
> Not OK: There is an NPE logged (the whole log is attached):
> {code:none}
> Caused by: java.lang.NullPointerException
> at java.util.LinkedList$ListItr.next(LinkedList.java:891) [rt.jar:1.7.0_55]
> at UIGroupMembershipSelector.run(UIGroupMembershipSelector.gtmpl:20) at org.exoplatform.groovyscript.GroovyScript.render(GroovyScript.java:99) [exo.portal.component.scripting-3.8.0.Beta02-SNAPSHOT.jar:3.8.0.Beta02-SNAPSHOT]
> at org.exoplatform.groovyscript.GroovyTemplate.render(GroovyTemplate.java:115) [exo.portal.component.scripting-3.8.0.Beta02-SNAPSHOT.jar:3.8.0.Beta02-SNAPSHOT]
> {code}
> Expected: No NPE
--
This message was sent by Atlassian JIRA
(v6.2.3#6260)
11 years, 10 months