[gatein-issues] [JBoss JIRA] Commented: (GTNPORTAL-1134) Avoid duplicate instantiation of the component org.exoplatform.groovyscript.text.TemplateService under rush condition

Avoid duplicate instantiation of the component org.exoplatform.groovyscript.text.TemplateService under rush condition --------------------------------------------------------------------------------------------------------------------- Key: GTNPORTAL-1134 URL: https://jira.jboss.org/jira/browse/GTNPORTAL-1134 Project: GateIn Portal Issue Type: Feature Request Security Level: Public(Everyone can see) Affects Versions: 3.0.0-GA Environment: GateIn trunk (revision 2755) deployed on EAP 5.0.1, Sun JDK 1.6 Reporter: Marek Posolda Assignee: Julien Viet Fix For: 3.1.0-GA Attachments: exo.kernel.container-2.2.2-GA-SNAPSHOT.jar, exo.kernel.container-2.2.2-GA-SNAPSHOT.jar TemplateService is not initialized during JBoss server startup but it's initialized lazily when first accessed from org.exoplatform.webui.core.lifecycle.Lifecycle.renderTemplate(line 108). Problem can occur if more threads will try to send first HTTP request to GateIn in same time because Lifecycle.renderTemplate is called by more threads concurrently and now TemplateService is constructed independently by more threads in same time. To avoid this issue, TemplateService should implement Startable interface, so that it will be started directly during GateIn boot. This can be usually seen in server log during startup of performance test: [JBoss] 03:35:19,457 INFO [ExoCacheFactoryImpl] The configuration template will be used for the the cache 'TemplateService'. [JBoss] 03:35:19,528 INFO [ExoCacheFactoryImpl] The cache 'TemplateService' will be created with 'class org.exoplatform.commons.cache.SimpleExoCacheCreator'. [JBoss] 03:35:19,658 INFO [ExoCacheFactoryImpl] The configuration template will be used for the the cache 'TemplateService'. [JBoss] 03:35:19,706 INFO [ExoCacheFactoryImpl] The cache 'TemplateService' will be created with 'class org.exoplatform.commons.cache.SimpleExoCacheCreator'. [JBoss] 03:35:19,734 INFO [ExoCacheFactoryImpl] The configuration template will be used for the the cache 'TemplateService'. [JBoss] 03:35:19,759 INFO [ExoCacheFactoryImpl] The cache 'TemplateService' will be created with 'class org.exoplatform.commons.cache.SimpleExoCacheCreator'. [JBoss] 03:35:19,798 INFO [ExoCacheFactoryImpl] The configuration template will be used for the the cache 'TemplateService'. [JBoss] 03:35:19,861 INFO [ExoCacheFactoryImpl] The cache 'TemplateService' will be created with 'class org.exoplatform.commons.cache.SimpleExoCacheCreator'. [JBoss] 03:35:19,891 INFO [ExoCacheFactoryImpl] The configuration template will be used for the the cache 'TemplateService'. [JBoss] 03:35:20,039 INFO [ExoCacheFactoryImpl] The cache 'TemplateService' will be created with 'class org.exoplatform.commons.cache.SimpleExoCacheCreator'. [JBoss] 03:35:20,072 INFO [ExoCacheFactoryImpl] The configuration template will be used for the the cache 'TemplateService'. [JBoss] 03:35:20,105 INFO [ExoCacheFactoryImpl] The cache 'TemplateService' will be created with 'class org.exoplatform.commons.cache.SimpleExoCacheCreator'. [JBoss] 03:35:20,143 INFO [ExoCacheFactoryImpl] The configuration template will be used for the the cache 'TemplateService'. [JBoss] 03:35:20,278 INFO [ExoCacheFactoryImpl] The cache 'TemplateService' will be created with 'class org.exoplatform.commons.cache.SimpleExoCacheCreator'. [JBoss] 03:35:20,313 INFO [ExoCacheFactoryImpl] The configuration template will be used for the the cache 'TemplateService'. [JBoss] 03:35:20,459 INFO [ExoCacheFactoryImpl] The cache 'TemplateService' will be created with 'class org.exoplatform.commons.cache.SimpleExoCacheCreator'. [JBoss] 03:35:20,491 INFO [ExoCacheFactoryImpl] The configuration template will be used for the the cache 'TemplateService'. [JBoss] 03:35:20,602 INFO [ExoCacheFactoryImpl] The cache 'TemplateService' will be created with 'class org.exoplatform.commons.cache.SimpleExoCacheCreator'. [JBoss] 03:35:20,645 INFO [ExoCacheFactoryImpl] The configuration template will be used for the the cache 'TemplateService'. [JBoss] 03:35:20,818 INFO [ExoCacheFactoryImpl] The cache 'TemplateService' will be created with 'class org.exoplatform.commons.cache.SimpleExoCacheCreator'. [JBoss] 03:35:20,861 INFO [ExoCacheFactoryImpl] The configuration template will be used for the the cache 'TemplateService'. [JBoss] 03:35:21,026 INFO [ExoCacheFactoryImpl] The cache 'TemplateService' will be created with 'class org.exoplatform.commons.cache.SimpleExoCacheCreator'. [JBoss] 03:35:21,059 INFO [ExoCacheFactoryImpl] The configuration template will be used for the the cache 'TemplateService'. [JBoss] 03:35:21,092 INFO [ExoCacheFactoryImpl] The cache 'TemplateService' will be created with 'class org.exoplatform.commons.cache.SimpleExoCacheCreator'. [JBoss] 03:35:21,145 INFO [ExoCacheFactoryImpl] The configuration template will be used for the the cache 'TemplateService'. [JBoss] 03:35:21,281 INFO [ExoCacheFactoryImpl] The cache 'TemplateService' will be created with 'class org.exoplatform.commons.cache.SimpleExoCacheCreator'. [JBoss] 03:35:21,396 INFO [ExoCacheFactoryImpl] The configuration template will be used for the the cache 'TemplateService'. [JBoss] 03:35:21,425 INFO [ExoCacheFactoryImpl] The cache 'TemplateService' will be created with 'class org.exoplatform.commons.cache.SimpleExoCacheCreator'. [JBoss] 03:35:21,452 INFO [ExoCacheFactoryImpl] The configuration template will be used for the the cache 'TemplateService'. [JBoss] 03:35:21,537 INFO [ExoCacheFactoryImpl] The cache 'TemplateService' will be created with 'class org.exoplatform.commons.cache.SimpleExoCacheCreator'. [JBoss] 03:35:21,594 INFO [ExoCacheFactoryImpl] The configuration template will be used for the the cache 'TemplateService'. .............................