[gatein-issues] [JBoss JIRA] (GTNPORTAL-2496) Invalid encoding in gadget source not handled properly
[
https://issues.jboss.org/browse/GTNPORTAL-2496?page=com.atlassian.jira.pl...
]
Peter Palaga updated GTNPORTAL-2496:
------------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/gatein/gatein-portal/pull/77
LocalGadgetData.setSource(String) tried to detect the encoding of the gadget XML source.
The funny thing was that the XML source was already there as a java.lang.String so after
all there was no need to detect its real encoding.
However the declared XML encoding should be used when storing the XML string in JCR so
that XML parsers do not get confused when they read it out again.
I found no way how the declared encoding could reliably be retrieved out of an XML
document. SAXParser/Locator2 return null when used with Reader and get wholly confused
when used with an InputStream where the real and declared encoding differ. It was similar
with XMLStreamReader. So I have written org.exoplatform.commons.xml.XMLDeclarationParser
which is able to extract the declared encoding.
Invalid encoding in gadget source not handled properly
------------------------------------------------------
Key: GTNPORTAL-2496
URL: https://issues.jboss.org/browse/GTNPORTAL-2496
Project: GateIn Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Reporter: Peter Palaga
Assignee: Peter Palaga
Originally reported by Miroslav Cupák on 2012-03-13 21:51:51 EDT:
Description of problem:
Invalid encoding in gadget source leads to SAXParseException and an "Unknown
error" message. The exception should be caught and a proper error message should be
displayed.
More specifically, there are two different error messages you can get depending on how
you mess up the encoding. You can either run into "org.xml.sax.SAXParseException:
Content is not allowed in prolog." (with e.g. "UTF-16" as the encoding) or
"org.xml.sax.SAXParseException: Invalid encoding name" (with e.g.
"UsadfTF-8" as the encoding).
Steps to Reproduce:
1. Sign in as "root".
2. Go to "Group" > "Administration" > "Application
Registry" and switch to "Gadget".
3. Try to create a gadget with an invalid encoding as described above.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira