[gatein-issues] [JBoss JIRA] (GTNPORTAL-3110) IDM DAO classes are only catching IdentityExceptions
[
https://issues.jboss.org/browse/GTNPORTAL-3110?page=com.atlassian.jira.pl...
]
Boubaker Khanfir commented on GTNPORTAL-3110:
---------------------------------------------
I think that we have a regression here. Any exception from IDM operations will cause a
rollback without throwing an exception. That's what was fixed here:
GTNPORTAL-3243
IMO, we have to throw an exception at the end of "recoverFromIDMError" method.
Should I open a new issue for that ?
Fix Version should be for 3.5+
IDM DAO classes are only catching IdentityExceptions
----------------------------------------------------
Key: GTNPORTAL-3110
URL: https://issues.jboss.org/browse/GTNPORTAL-3110
Project: GateIn Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Identity integration
Affects Versions: 3.6.0.Beta02
Reporter: Martin Weiler
Assignee: Marek Posolda
Fix For: 3.6.0.Final
In some IDM DAO classes, such as GroupDAOImpl, MembershipDAOImpl and UserProfileDAOImpl
all IDM calls are wrapped with try..catch(Exception e) blocks, which ensures that not only
IdentityException, but also Hibernate exceptions are caught and recovered with
rollback().
But in UserDAOImpl only "IdentityException e" instances are caught. So
HibernateException are not handled, which can result in transaction errors. Additionally,
in MembershipTypeDAOImpl the IDM calls are not wrapped with any catch blocks, which also
needs to be fixed.
--
This message was sent by Atlassian JIRA
(v6.2.3#6260)