[gatein-issues] [JBoss JIRA] Resolved: (GTNWSRP-146) Handle resource urls better when dealing with wsrp v1

Handle resource urls better when dealing with wsrp v1 ----------------------------------------------------- Key: GTNWSRP-146 URL: https://jira.jboss.org/browse/GTNWSRP-146 Project: GateIn WSRP Issue Type: Bug Affects Versions: 2.0.0-CR01 Reporter: Matt Wringe Assignee: Chris Laprun Fix For: 2.0.0-GA For wsrp v1, the resource url needs to contain a resource-url and requiresRewrite parameters. For wsrp v2, the resource url needs to conains either a resource-id, or a resource-url and requiredRewrite On the producer side when a portlet creates a javax.portlet.ResourceURL, we convert this over to a WSRPResourceURL. We run into a situation here where the portlet ResourceURL does not have the concept of a resource-url, but rather a resource-id. Because of this we are currently always setting the resource-id for a WSRPResourceURL and never setting the resource-url. This causes us to create invalid WSRPResourceURLs for the v1 case. Our implementation of the v1 wsrp producer is just a wrapper around the wsrp v2 version. Since these are not separate versions, we cannot easily have separate producer behaviours for the different versions without a lot of effort. We could potentially also set the resource-url from the portlet's ResourceURL resource-id, but this would require the portlet to be specifically designed to work around the wsrp v1 limitation. I believe we used to have something like this for the portletbridge case, but I couldn't really find anything during a quick search. This hack maybe better than nothing, but I don't think there is any better way to attempt to handle the resource-url issue with portlets. Please note that the consumer will handle the resource url properly, the issue is with the producer creating a proper url in the first place. If the portlet also creates the wsrp url itself (using the spec) it should also work fine. The issue is with how do we correctly parse the portlet ResourceURL to create a wsrp one.