[gatein-issues] [JBoss JIRA] Commented: (GTNPORTAL-1357) A template caching issue with a custom resource resolver
[
https://jira.jboss.org/browse/GTNPORTAL-1357?page=com.atlassian.jira.plug...
]
Minh Hoang TO commented on GTNPORTAL-1357:
------------------------------------------
public ResourceKey createResourceKey(String url)
{
return new ResourceKey(hashCode(), url);
}
The Javadoc helps only if developers read it. There are two aimable solutions
1. Make the method getResourceKey abstract
2. Replace hashCode() with this.getClass().hashCode()
A template caching issue with a custom resource resolver
--------------------------------------------------------
Key: GTNPORTAL-1357
URL: https://jira.jboss.org/browse/GTNPORTAL-1357
Project: GateIn Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 3.1.0-GA
Reporter: Trong Tran
Assignee: Vu Viet Phuong
Fix For: 3.2.0-GA
Attachments: 2010-07-29-GTNPORTAL-1357.patch
Original Estimate: 4 hours
Remaining Estimate: 4 hours
Since GateIn 3.1, We changed a bit on template caching mechanism that the template
resource key are combination of ResourceResolver#hashCode() + templateURL
Unfortunately if a third party is using a custom ResourceResolver which is created newly
for each request, that is the resource key will be always different in each request and it
raises up a memory leak and a performance issues
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira