[gatein-issues] [JBoss JIRA] (GTNPC-82) Potential concurency issues in FederatingPortletInvokerService and ContainerPortletInvoker

[ https://issues.jboss.org/browse/GTNPC-82?page=com.atlassian.jira.plugin.s... ] Nicolas Filotto updated GTNPC-82: --------------------------------- Description: While debugging to undestand why the PC could not find my portlets, I found the next potential concurrency issues : # In FederatingPortletInvokerService.getOrResolveFederatedInvoker() the invokerCache is directly modified instead of being recreated from scratch and reassigned which could cause HashMap corruptions under heavy load # In ContainerPortletInvoker: The methods addPortletContainer and removePortletContainer should be synchronized to prevent any modification loss in case of concurrent modifications. Moreover the variable portlets should be volatile for the same reason This must be seen as a feedback based on my experience, you are free to resolve it as won't fix if you don't find it relevant. was: While debugging to undestand why the PC could not find my portlets, I found the next potential concurrency issues : # In FederatingPortletInvokerService.getOrResolveFederatedInvoker() the invokerCache is directly modified instead of being recreated from scratch an reassigned which could cause HashMap corruptions under heavy load # In ContainerPortletInvoker: The methods addPortletContainer and removePortletContainer should be synchronized to prevent any modification loss in case of concurrent modifications. Moreover the variable portlets should be volatile for the same reason This must be seen as a feedback you are free to resolve it as won't fix if you don't find it relevant. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira