[gatein-issues] [JBoss JIRA] (GTNPORTAL-2673) Gatein master Unit tests fails in GateIn Portal Component Portal Data on openjdk7

[ https://issues.jboss.org/browse/GTNPORTAL-2673?page=com.atlassian.jira.pl... ] Minh Hoang TO commented on GTNPORTAL-2673: ------------------------------------------ It is true that GadgetTokenInfoService is not thread-safe. By the way, deleteToken/cleanExpiredTokens won't cause issue in reality as long as API caller does not attempt to use the returned object carelessly. For this issue, i prefer correcting the test than adding concurrency stuff to the service {code:java} GadgetToken token = service.deleteToken(tokenIndex); assertEquals(token.getAccessToken(), "accessToken0"); assertEquals(token.getSessionHandle(), "sessionHandle0"); assertEquals(token.getTokenSecret(), "tokenSecret0"); {code} should become {code:java} GadgetToken token = service.deleteToken(tokenIndex); if(token != null) { assertEquals(token.getAccessToken(), "accessToken0"); assertEquals(token.getSessionHandle(), "sessionHandle0"); assertEquals(token.getTokenSecret(), "tokenSecret0"); } {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira