Portal mode transition in UIPortalComposer should not be hardcoded ------------------------------------------------------------------ Key: GTNPORTAL-1210 URL: https://jira.jboss.org/jira/browse/GTNPORTAL-1210 Project: GateIn Portal Issue Type: Task Reporter: Minh Hoang TO Priority: Minor / Swicth to Porlets Tab if (portalMode % 2 == 0) { uiPortalApp.setModeState(UIPortalApplication.APP_VIEW_EDIT_MODE); Util.showComponentEditInViewMode(UIPortlet.class); } I'm talking about portal mode transition in UIPortalComposer. There should not be hardcoded check like portalMode % 2 == 0 . A switch/case on portalMode is better as it makes the code easier to understand and easier to refactor. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira