Potential concurrency issues in FederatingPortletInvokerService and ContainerPortletInvoker ------------------------------------------------------------------------------------------- Key: GTNPC-82 URL: https://issues.jboss.org/browse/GTNPC-82 Project: GateIn Portlet Container Issue Type: Quality Risk Affects Versions: 2.3.0-GA Reporter: Nicolas Filotto Assignee: Julien Viet Fix For: 2.4.1.CR03 Attachments: GTNPC-82.patch While debugging to undestand why the PC could not find my portlets, I found the next potential concurrency issues : # In FederatingPortletInvokerService.getOrResolveFederatedInvoker() the invokerCache is directly modified instead of being recreated from scratch and reassigned which could cause HashMap corruptions under heavy load # In ContainerPortletInvoker: The methods addPortletContainer and removePortletContainer should be synchronized to prevent any modification loss in case of concurrent modifications. Moreover the variable portlets should be volatile for the same reason This must be seen as a feedback based on my experience, you are free to resolve it as won't fix if you don't find it relevant.