[JBoss JIRA] Created: (GTNPORTAL-1541) Concurreny problem - NullPointerException in BreadcumbsPortlet during performance test
7:03 a.m.
Concurreny problem - NullPointerException in BreadcumbsPortlet during performance test
--------------------------------------------------------------------------------------
Key: GTNPORTAL-1541
URL: https://jira.jboss.org/browse/GTNPORTAL-1541
Project: GateIn Portal
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: WebUI
Affects Versions: 3.1.0-GA
Environment: GateIn trunk (revision 4282) on EAP5
Reporter: Marek Posolda
Sometimes during performance test, I am seeing NPE exception in server log, thrown from
UIBreadcumbsPortlet. Exception stacktrace is:
2010-10-06 09:11:15,589 ERROR
[org.exoplatform.webui.application.portlet.PortletApplicationController]
(http-127.0.0.1-8080-4) Error while rendering the porlet
java.lang.NullPointerException
at
org.exoplatform.portal.webui.component.UIBreadcumbsPortlet.loadSelectedPath(UIBreadcumbsPortlet.java:69)
at
org.exoplatform.portal.webui.component.UIBreadcumbsPortlet.renderChildren(UIBreadcumbsPortlet.java:89)
at
org.exoplatform.webui.core.lifecycle.UIApplicationLifecycle.processRender(UIApplicationLifecycle.java:73)
at
org.exoplatform.webui.core.lifecycle.UIApplicationLifecycle.processRender(UIApplicationLifecycle.java:31)
at org.exoplatform.webui.core.UIComponent.processRender(UIComponent.java:144)
at
org.exoplatform.webui.core.UIPortletApplication.processRender(UIPortletApplication.java:146)
at
org.exoplatform.webui.application.portlet.PortletApplication.render(PortletApplication.java:253)
at
org.exoplatform.webui.application.portlet.PortletApplicationController.render(PortletApplicationController.java:110)
at
org.gatein.pc.portlet.impl.jsr168.PortletContainerImpl$Invoker.doFilter(PortletContainerImpl.java:569)
Whole test log is attached in related issue JBEPP-459 for completeness. It is not occuring
in every performance test but only sometimes, so concurreny issue came to my mind first.
I did more investigation and I founded that the cause of problem is in thread-unsafe call
of method "getUIComponentEventConfig" on class
"org.exoplatform.webui.config.Component".
Problem can be seen if client1 calls this method and eventsMap is null -> eventsMap is
going to initialize during this call.
But when client2 calls this method before initialization of map by client1 is finished,
then problem can happen because eventsMap is not fully initialized for client2 ->
client2 can't find ChangePageNode event -> listener
UIPageActionListener.ChangePageNodeActionListener is not called for client2 -> UIPortal
of client2 has unitialized variables selectedNode and selectedPath ->
NullPointerException is thrown for client2 during rendering of BreadcumbsPortlet, because
UIPortal.selectedPath is null.
Steps to reproduce (with usage of Eclispe IDE):
- Add breakpoint to class org.exoplatform.webui.config.Component to line 184 (after call
of eventMap = new HashMap<String, Event>() )
- Open browser1 and go to localhost:8080/portal/public/classic . Client will be stopped on
breakpoint
- Open browser2 and go to localhost:8080/portal/public/classic . This client is not seeing
ChangePageNode event and so NPE is thrown for him in UIBreadcumbsPortlet.
Note: Method getUIComponentEventConfig is called many times during single HTTP request. So
is it possible to fix this issue by other way that full initialization of this method?
Because it can have bad impact on performance. I wonder if it's possible to
initialize eventsMap in constructor of Component class (only suggestion)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:48 a.m.
New subject: [JBoss JIRA] Updated: (GTNPORTAL-1541) Concurreny problem - NullPointerException in BreadcumbsPortlet during performance test
[
https://jira.jboss.org/browse/GTNPORTAL-1541?page=com.atlassian.jira.plug...
]
Khoi Nguyen updated GTNPORTAL-1541:
-----------------------------------
Original Estimate: 6 hours
Remaining Estimate: 6 hours
Labels: portal-s41 (was: )
Concurreny problem - NullPointerException in BreadcumbsPortlet during
performance test
--------------------------------------------------------------------------------------
Key: GTNPORTAL-1541
URL: https://jira.jboss.org/browse/GTNPORTAL-1541
Project: GateIn Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: WebUI
Affects Versions: 3.1.0-GA
Environment: GateIn trunk (revision 4282) on EAP5
Reporter: Marek Posolda
Original Estimate: 6 hours
Remaining Estimate: 6 hours
Sometimes during performance test, I am seeing NPE exception in server log, thrown from
UIBreadcumbsPortlet. Exception stacktrace is:
2010-10-06 09:11:15,589 ERROR
[org.exoplatform.webui.application.portlet.PortletApplicationController]
(http-127.0.0.1-8080-4) Error while rendering the porlet
java.lang.NullPointerException
at
org.exoplatform.portal.webui.component.UIBreadcumbsPortlet.loadSelectedPath(UIBreadcumbsPortlet.java:69)
at
org.exoplatform.portal.webui.component.UIBreadcumbsPortlet.renderChildren(UIBreadcumbsPortlet.java:89)
at
org.exoplatform.webui.core.lifecycle.UIApplicationLifecycle.processRender(UIApplicationLifecycle.java:73)
at
org.exoplatform.webui.core.lifecycle.UIApplicationLifecycle.processRender(UIApplicationLifecycle.java:31)
at org.exoplatform.webui.core.UIComponent.processRender(UIComponent.java:144)
at
org.exoplatform.webui.core.UIPortletApplication.processRender(UIPortletApplication.java:146)
at
org.exoplatform.webui.application.portlet.PortletApplication.render(PortletApplication.java:253)
at
org.exoplatform.webui.application.portlet.PortletApplicationController.render(PortletApplicationController.java:110)
at
org.gatein.pc.portlet.impl.jsr168.PortletContainerImpl$Invoker.doFilter(PortletContainerImpl.java:569)
Whole test log is attached in related issue JBEPP-459 for completeness. It is not
occuring in every performance test but only sometimes, so concurreny issue came to my mind
first.
I did more investigation and I founded that the cause of problem is in thread-unsafe call
of method "getUIComponentEventConfig" on class
"org.exoplatform.webui.config.Component".
Problem can be seen if client1 calls this method and eventsMap is null -> eventsMap is
going to initialize during this call.
But when client2 calls this method before initialization of map by client1 is finished,
then problem can happen because eventsMap is not fully initialized for client2 ->
client2 can't find ChangePageNode event -> listener
UIPageActionListener.ChangePageNodeActionListener is not called for client2 -> UIPortal
of client2 has unitialized variables selectedNode and selectedPath ->
NullPointerException is thrown for client2 during rendering of BreadcumbsPortlet, because
UIPortal.selectedPath is null.
Steps to reproduce (with usage of Eclispe IDE):
- Add breakpoint to class org.exoplatform.webui.config.Component to line 184 (after call
of eventMap = new HashMap<String, Event>() )
- Open browser1 and go to localhost:8080/portal/public/classic . Client will be stopped
on breakpoint
- Open browser2 and go to localhost:8080/portal/public/classic . This client is not
seeing ChangePageNode event and so NPE is thrown for him in UIBreadcumbsPortlet.
Note: Method getUIComponentEventConfig is called many times during single HTTP request.
So is it possible to fix this issue by other way that full initialization of this method?
Because it can have bad impact on performance. I wonder if it's possible to
initialize eventsMap in constructor of Component class (only suggestion)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:23 a.m.
New subject: [JBoss JIRA] Assigned: (GTNPORTAL-1541) Concurreny problem - NullPointerException in BreadcumbsPortlet during performance test
[
https://jira.jboss.org/browse/GTNPORTAL-1541?page=com.atlassian.jira.plug...
]
Khoi Nguyen reassigned GTNPORTAL-1541:
--------------------------------------
Assignee: Khoi Nguyen
Concurreny problem - NullPointerException in BreadcumbsPortlet during
performance test
--------------------------------------------------------------------------------------
Key: GTNPORTAL-1541
URL: https://jira.jboss.org/browse/GTNPORTAL-1541
Project: GateIn Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: WebUI
Affects Versions: 3.1.0-GA
Environment: GateIn trunk (revision 4282) on EAP5
Reporter: Marek Posolda
Assignee: Khoi Nguyen
Original Estimate: 6 hours
Remaining Estimate: 6 hours
Sometimes during performance test, I am seeing NPE exception in server log, thrown from
UIBreadcumbsPortlet. Exception stacktrace is:
2010-10-06 09:11:15,589 ERROR
[org.exoplatform.webui.application.portlet.PortletApplicationController]
(http-127.0.0.1-8080-4) Error while rendering the porlet
java.lang.NullPointerException
at
org.exoplatform.portal.webui.component.UIBreadcumbsPortlet.loadSelectedPath(UIBreadcumbsPortlet.java:69)
at
org.exoplatform.portal.webui.component.UIBreadcumbsPortlet.renderChildren(UIBreadcumbsPortlet.java:89)
at
org.exoplatform.webui.core.lifecycle.UIApplicationLifecycle.processRender(UIApplicationLifecycle.java:73)
at
org.exoplatform.webui.core.lifecycle.UIApplicationLifecycle.processRender(UIApplicationLifecycle.java:31)
at org.exoplatform.webui.core.UIComponent.processRender(UIComponent.java:144)
at
org.exoplatform.webui.core.UIPortletApplication.processRender(UIPortletApplication.java:146)
at
org.exoplatform.webui.application.portlet.PortletApplication.render(PortletApplication.java:253)
at
org.exoplatform.webui.application.portlet.PortletApplicationController.render(PortletApplicationController.java:110)
at
org.gatein.pc.portlet.impl.jsr168.PortletContainerImpl$Invoker.doFilter(PortletContainerImpl.java:569)
Whole test log is attached in related issue JBEPP-459 for completeness. It is not
occuring in every performance test but only sometimes, so concurreny issue came to my mind
first.
I did more investigation and I founded that the cause of problem is in thread-unsafe call
of method "getUIComponentEventConfig" on class
"org.exoplatform.webui.config.Component".
Problem can be seen if client1 calls this method and eventsMap is null -> eventsMap is
going to initialize during this call.
But when client2 calls this method before initialization of map by client1 is finished,
then problem can happen because eventsMap is not fully initialized for client2 ->
client2 can't find ChangePageNode event -> listener
UIPageActionListener.ChangePageNodeActionListener is not called for client2 -> UIPortal
of client2 has unitialized variables selectedNode and selectedPath ->
NullPointerException is thrown for client2 during rendering of BreadcumbsPortlet, because
UIPortal.selectedPath is null.
Steps to reproduce (with usage of Eclispe IDE):
- Add breakpoint to class org.exoplatform.webui.config.Component to line 184 (after call
of eventMap = new HashMap<String, Event>() )
- Open browser1 and go to localhost:8080/portal/public/classic . Client will be stopped
on breakpoint
- Open browser2 and go to localhost:8080/portal/public/classic . This client is not
seeing ChangePageNode event and so NPE is thrown for him in UIBreadcumbsPortlet.
Note: Method getUIComponentEventConfig is called many times during single HTTP request.
So is it possible to fix this issue by other way that full initialization of this method?
Because it can have bad impact on performance. I wonder if it's possible to
initialize eventsMap in constructor of Component class (only suggestion)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:48 p.m.
New subject: [JBoss JIRA] Assigned: (GTNPORTAL-1541) Concurreny problem - NullPointerException in BreadcumbsPortlet during performance test
[
https://jira.jboss.org/browse/GTNPORTAL-1541?page=com.atlassian.jira.plug...
]
Minh Hoang TO reassigned GTNPORTAL-1541:
----------------------------------------
Assignee: Minh Hoang TO (was: Khoi Nguyen)
Concurreny problem - NullPointerException in BreadcumbsPortlet during
performance test
--------------------------------------------------------------------------------------
Key: GTNPORTAL-1541
URL: https://jira.jboss.org/browse/GTNPORTAL-1541
Project: GateIn Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: WebUI
Affects Versions: 3.1.0-GA
Environment: GateIn trunk (revision 4282) on EAP5
Reporter: Marek Posolda
Assignee: Minh Hoang TO
Original Estimate: 6 hours
Remaining Estimate: 6 hours
Sometimes during performance test, I am seeing NPE exception in server log, thrown from
UIBreadcumbsPortlet. Exception stacktrace is:
2010-10-06 09:11:15,589 ERROR
[org.exoplatform.webui.application.portlet.PortletApplicationController]
(http-127.0.0.1-8080-4) Error while rendering the porlet
java.lang.NullPointerException
at
org.exoplatform.portal.webui.component.UIBreadcumbsPortlet.loadSelectedPath(UIBreadcumbsPortlet.java:69)
at
org.exoplatform.portal.webui.component.UIBreadcumbsPortlet.renderChildren(UIBreadcumbsPortlet.java:89)
at
org.exoplatform.webui.core.lifecycle.UIApplicationLifecycle.processRender(UIApplicationLifecycle.java:73)
at
org.exoplatform.webui.core.lifecycle.UIApplicationLifecycle.processRender(UIApplicationLifecycle.java:31)
at org.exoplatform.webui.core.UIComponent.processRender(UIComponent.java:144)
at
org.exoplatform.webui.core.UIPortletApplication.processRender(UIPortletApplication.java:146)
at
org.exoplatform.webui.application.portlet.PortletApplication.render(PortletApplication.java:253)
at
org.exoplatform.webui.application.portlet.PortletApplicationController.render(PortletApplicationController.java:110)
at
org.gatein.pc.portlet.impl.jsr168.PortletContainerImpl$Invoker.doFilter(PortletContainerImpl.java:569)
Whole test log is attached in related issue JBEPP-459 for completeness. It is not
occuring in every performance test but only sometimes, so concurreny issue came to my mind
first.
I did more investigation and I founded that the cause of problem is in thread-unsafe call
of method "getUIComponentEventConfig" on class
"org.exoplatform.webui.config.Component".
Problem can be seen if client1 calls this method and eventsMap is null -> eventsMap is
going to initialize during this call.
But when client2 calls this method before initialization of map by client1 is finished,
then problem can happen because eventsMap is not fully initialized for client2 ->
client2 can't find ChangePageNode event -> listener
UIPageActionListener.ChangePageNodeActionListener is not called for client2 -> UIPortal
of client2 has unitialized variables selectedNode and selectedPath ->
NullPointerException is thrown for client2 during rendering of BreadcumbsPortlet, because
UIPortal.selectedPath is null.
Steps to reproduce (with usage of Eclispe IDE):
- Add breakpoint to class org.exoplatform.webui.config.Component to line 184 (after call
of eventMap = new HashMap<String, Event>() )
- Open browser1 and go to localhost:8080/portal/public/classic . Client will be stopped
on breakpoint
- Open browser2 and go to localhost:8080/portal/public/classic . This client is not
seeing ChangePageNode event and so NPE is thrown for him in UIBreadcumbsPortlet.
Note: Method getUIComponentEventConfig is called many times during single HTTP request.
So is it possible to fix this issue by other way that full initialization of this method?
Because it can have bad impact on performance. I wonder if it's possible to
initialize eventsMap in constructor of Component class (only suggestion)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:29 a.m.
New subject: [JBoss JIRA] Work started: (GTNPORTAL-1541) Concurreny problem - NullPointerException in BreadcumbsPortlet during performance test
[
https://jira.jboss.org/browse/GTNPORTAL-1541?page=com.atlassian.jira.plug...
]
Work on GTNPORTAL-1541 started by Minh Hoang TO.
Concurreny problem - NullPointerException in BreadcumbsPortlet during
performance test
--------------------------------------------------------------------------------------
Key: GTNPORTAL-1541
URL: https://jira.jboss.org/browse/GTNPORTAL-1541
Project: GateIn Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: WebUI
Affects Versions: 3.1.0-GA
Environment: GateIn trunk (revision 4282) on EAP5
Reporter: Marek Posolda
Assignee: Minh Hoang TO
Original Estimate: 6 hours
Remaining Estimate: 6 hours
Sometimes during performance test, I am seeing NPE exception in server log, thrown from
UIBreadcumbsPortlet. Exception stacktrace is:
2010-10-06 09:11:15,589 ERROR
[org.exoplatform.webui.application.portlet.PortletApplicationController]
(http-127.0.0.1-8080-4) Error while rendering the porlet
java.lang.NullPointerException
at
org.exoplatform.portal.webui.component.UIBreadcumbsPortlet.loadSelectedPath(UIBreadcumbsPortlet.java:69)
at
org.exoplatform.portal.webui.component.UIBreadcumbsPortlet.renderChildren(UIBreadcumbsPortlet.java:89)
at
org.exoplatform.webui.core.lifecycle.UIApplicationLifecycle.processRender(UIApplicationLifecycle.java:73)
at
org.exoplatform.webui.core.lifecycle.UIApplicationLifecycle.processRender(UIApplicationLifecycle.java:31)
at org.exoplatform.webui.core.UIComponent.processRender(UIComponent.java:144)
at
org.exoplatform.webui.core.UIPortletApplication.processRender(UIPortletApplication.java:146)
at
org.exoplatform.webui.application.portlet.PortletApplication.render(PortletApplication.java:253)
at
org.exoplatform.webui.application.portlet.PortletApplicationController.render(PortletApplicationController.java:110)
at
org.gatein.pc.portlet.impl.jsr168.PortletContainerImpl$Invoker.doFilter(PortletContainerImpl.java:569)
Whole test log is attached in related issue JBEPP-459 for completeness. It is not
occuring in every performance test but only sometimes, so concurreny issue came to my mind
first.
I did more investigation and I founded that the cause of problem is in thread-unsafe call
of method "getUIComponentEventConfig" on class
"org.exoplatform.webui.config.Component".
Problem can be seen if client1 calls this method and eventsMap is null -> eventsMap is
going to initialize during this call.
But when client2 calls this method before initialization of map by client1 is finished,
then problem can happen because eventsMap is not fully initialized for client2 ->
client2 can't find ChangePageNode event -> listener
UIPageActionListener.ChangePageNodeActionListener is not called for client2 -> UIPortal
of client2 has unitialized variables selectedNode and selectedPath ->
NullPointerException is thrown for client2 during rendering of BreadcumbsPortlet, because
UIPortal.selectedPath is null.
Steps to reproduce (with usage of Eclispe IDE):
- Add breakpoint to class org.exoplatform.webui.config.Component to line 184 (after call
of eventMap = new HashMap<String, Event>() )
- Open browser1 and go to localhost:8080/portal/public/classic . Client will be stopped
on breakpoint
- Open browser2 and go to localhost:8080/portal/public/classic . This client is not
seeing ChangePageNode event and so NPE is thrown for him in UIBreadcumbsPortlet.
Note: Method getUIComponentEventConfig is called many times during single HTTP request.
So is it possible to fix this issue by other way that full initialization of this method?
Because it can have bad impact on performance. I wonder if it's possible to
initialize eventsMap in constructor of Component class (only suggestion)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:32 a.m.
New subject: [JBoss JIRA] Updated: (GTNPORTAL-1541) Concurreny problem - NullPointerException in BreadcumbsPortlet during performance test
[
https://jira.jboss.org/browse/GTNPORTAL-1541?page=com.atlassian.jira.plug...
]
Minh Hoang TO updated GTNPORTAL-1541:
-------------------------------------
Attachment: GTNPORTAL-1541-01112010
Concurreny problem - NullPointerException in BreadcumbsPortlet during
performance test
--------------------------------------------------------------------------------------
Key: GTNPORTAL-1541
URL: https://jira.jboss.org/browse/GTNPORTAL-1541
Project: GateIn Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: WebUI
Affects Versions: 3.1.0-GA
Environment: GateIn trunk (revision 4282) on EAP5
Reporter: Marek Posolda
Assignee: Minh Hoang TO
Attachments: GTNPORTAL-1541-01112010
Original Estimate: 6 hours
Remaining Estimate: 6 hours
Sometimes during performance test, I am seeing NPE exception in server log, thrown from
UIBreadcumbsPortlet. Exception stacktrace is:
2010-10-06 09:11:15,589 ERROR
[org.exoplatform.webui.application.portlet.PortletApplicationController]
(http-127.0.0.1-8080-4) Error while rendering the porlet
java.lang.NullPointerException
at
org.exoplatform.portal.webui.component.UIBreadcumbsPortlet.loadSelectedPath(UIBreadcumbsPortlet.java:69)
at
org.exoplatform.portal.webui.component.UIBreadcumbsPortlet.renderChildren(UIBreadcumbsPortlet.java:89)
at
org.exoplatform.webui.core.lifecycle.UIApplicationLifecycle.processRender(UIApplicationLifecycle.java:73)
at
org.exoplatform.webui.core.lifecycle.UIApplicationLifecycle.processRender(UIApplicationLifecycle.java:31)
at org.exoplatform.webui.core.UIComponent.processRender(UIComponent.java:144)
at
org.exoplatform.webui.core.UIPortletApplication.processRender(UIPortletApplication.java:146)
at
org.exoplatform.webui.application.portlet.PortletApplication.render(PortletApplication.java:253)
at
org.exoplatform.webui.application.portlet.PortletApplicationController.render(PortletApplicationController.java:110)
at
org.gatein.pc.portlet.impl.jsr168.PortletContainerImpl$Invoker.doFilter(PortletContainerImpl.java:569)
Whole test log is attached in related issue JBEPP-459 for completeness. It is not
occuring in every performance test but only sometimes, so concurreny issue came to my mind
first.
I did more investigation and I founded that the cause of problem is in thread-unsafe call
of method "getUIComponentEventConfig" on class
"org.exoplatform.webui.config.Component".
Problem can be seen if client1 calls this method and eventsMap is null -> eventsMap is
going to initialize during this call.
But when client2 calls this method before initialization of map by client1 is finished,
then problem can happen because eventsMap is not fully initialized for client2 ->
client2 can't find ChangePageNode event -> listener
UIPageActionListener.ChangePageNodeActionListener is not called for client2 -> UIPortal
of client2 has unitialized variables selectedNode and selectedPath ->
NullPointerException is thrown for client2 during rendering of BreadcumbsPortlet, because
UIPortal.selectedPath is null.
Steps to reproduce (with usage of Eclispe IDE):
- Add breakpoint to class org.exoplatform.webui.config.Component to line 184 (after call
of eventMap = new HashMap<String, Event>() )
- Open browser1 and go to localhost:8080/portal/public/classic . Client will be stopped
on breakpoint
- Open browser2 and go to localhost:8080/portal/public/classic . This client is not
seeing ChangePageNode event and so NPE is thrown for him in UIBreadcumbsPortlet.
Note: Method getUIComponentEventConfig is called many times during single HTTP request.
So is it possible to fix this issue by other way that full initialization of this method?
Because it can have bad impact on performance. I wonder if it's possible to
initialize eventsMap in constructor of Component class (only suggestion)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:34 a.m.
New subject: [JBoss JIRA] Updated: (GTNPORTAL-1541) Concurreny problem - NullPointerException in BreadcumbsPortlet during performance test
[
https://jira.jboss.org/browse/GTNPORTAL-1541?page=com.atlassian.jira.plug...
]
Minh Hoang TO updated GTNPORTAL-1541:
-------------------------------------
Attachment: .classpath
Concurreny problem - NullPointerException in BreadcumbsPortlet during
performance test
--------------------------------------------------------------------------------------
Key: GTNPORTAL-1541
URL: https://jira.jboss.org/browse/GTNPORTAL-1541
Project: GateIn Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: WebUI
Affects Versions: 3.1.0-GA
Environment: GateIn trunk (revision 4282) on EAP5
Reporter: Marek Posolda
Assignee: Minh Hoang TO
Attachments: .classpath, GTNPORTAL-1541-01112010
Original Estimate: 6 hours
Remaining Estimate: 6 hours
Sometimes during performance test, I am seeing NPE exception in server log, thrown from
UIBreadcumbsPortlet. Exception stacktrace is:
2010-10-06 09:11:15,589 ERROR
[org.exoplatform.webui.application.portlet.PortletApplicationController]
(http-127.0.0.1-8080-4) Error while rendering the porlet
java.lang.NullPointerException
at
org.exoplatform.portal.webui.component.UIBreadcumbsPortlet.loadSelectedPath(UIBreadcumbsPortlet.java:69)
at
org.exoplatform.portal.webui.component.UIBreadcumbsPortlet.renderChildren(UIBreadcumbsPortlet.java:89)
at
org.exoplatform.webui.core.lifecycle.UIApplicationLifecycle.processRender(UIApplicationLifecycle.java:73)
at
org.exoplatform.webui.core.lifecycle.UIApplicationLifecycle.processRender(UIApplicationLifecycle.java:31)
at org.exoplatform.webui.core.UIComponent.processRender(UIComponent.java:144)
at
org.exoplatform.webui.core.UIPortletApplication.processRender(UIPortletApplication.java:146)
at
org.exoplatform.webui.application.portlet.PortletApplication.render(PortletApplication.java:253)
at
org.exoplatform.webui.application.portlet.PortletApplicationController.render(PortletApplicationController.java:110)
at
org.gatein.pc.portlet.impl.jsr168.PortletContainerImpl$Invoker.doFilter(PortletContainerImpl.java:569)
Whole test log is attached in related issue JBEPP-459 for completeness. It is not
occuring in every performance test but only sometimes, so concurreny issue came to my mind
first.
I did more investigation and I founded that the cause of problem is in thread-unsafe call
of method "getUIComponentEventConfig" on class
"org.exoplatform.webui.config.Component".
Problem can be seen if client1 calls this method and eventsMap is null -> eventsMap is
going to initialize during this call.
But when client2 calls this method before initialization of map by client1 is finished,
then problem can happen because eventsMap is not fully initialized for client2 ->
client2 can't find ChangePageNode event -> listener
UIPageActionListener.ChangePageNodeActionListener is not called for client2 -> UIPortal
of client2 has unitialized variables selectedNode and selectedPath ->
NullPointerException is thrown for client2 during rendering of BreadcumbsPortlet, because
UIPortal.selectedPath is null.
Steps to reproduce (with usage of Eclispe IDE):
- Add breakpoint to class org.exoplatform.webui.config.Component to line 184 (after call
of eventMap = new HashMap<String, Event>() )
- Open browser1 and go to localhost:8080/portal/public/classic . Client will be stopped
on breakpoint
- Open browser2 and go to localhost:8080/portal/public/classic . This client is not
seeing ChangePageNode event and so NPE is thrown for him in UIBreadcumbsPortlet.
Note: Method getUIComponentEventConfig is called many times during single HTTP request.
So is it possible to fix this issue by other way that full initialization of this method?
Because it can have bad impact on performance. I wonder if it's possible to
initialize eventsMap in constructor of Component class (only suggestion)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:34 a.m.
New subject: [JBoss JIRA] Commented: (GTNPORTAL-1541) Concurreny problem - NullPointerException in BreadcumbsPortlet during performance test
[
https://jira.jboss.org/browse/GTNPORTAL-1541?page=com.atlassian.jira.plug...
]
Minh Hoang TO commented on GTNPORTAL-1541:
------------------------------------------
In the attached patch, i added double-check pattern into the method
getUIComponentEventConfig()
Concurreny problem - NullPointerException in BreadcumbsPortlet during
performance test
--------------------------------------------------------------------------------------
Key: GTNPORTAL-1541
URL: https://jira.jboss.org/browse/GTNPORTAL-1541
Project: GateIn Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: WebUI
Affects Versions: 3.1.0-GA
Environment: GateIn trunk (revision 4282) on EAP5
Reporter: Marek Posolda
Assignee: Minh Hoang TO
Attachments: .classpath, GTNPORTAL-1541-01112010
Original Estimate: 6 hours
Remaining Estimate: 6 hours
Sometimes during performance test, I am seeing NPE exception in server log, thrown from
UIBreadcumbsPortlet. Exception stacktrace is:
2010-10-06 09:11:15,589 ERROR
[org.exoplatform.webui.application.portlet.PortletApplicationController]
(http-127.0.0.1-8080-4) Error while rendering the porlet
java.lang.NullPointerException
at
org.exoplatform.portal.webui.component.UIBreadcumbsPortlet.loadSelectedPath(UIBreadcumbsPortlet.java:69)
at
org.exoplatform.portal.webui.component.UIBreadcumbsPortlet.renderChildren(UIBreadcumbsPortlet.java:89)
at
org.exoplatform.webui.core.lifecycle.UIApplicationLifecycle.processRender(UIApplicationLifecycle.java:73)
at
org.exoplatform.webui.core.lifecycle.UIApplicationLifecycle.processRender(UIApplicationLifecycle.java:31)
at org.exoplatform.webui.core.UIComponent.processRender(UIComponent.java:144)
at
org.exoplatform.webui.core.UIPortletApplication.processRender(UIPortletApplication.java:146)
at
org.exoplatform.webui.application.portlet.PortletApplication.render(PortletApplication.java:253)
at
org.exoplatform.webui.application.portlet.PortletApplicationController.render(PortletApplicationController.java:110)
at
org.gatein.pc.portlet.impl.jsr168.PortletContainerImpl$Invoker.doFilter(PortletContainerImpl.java:569)
Whole test log is attached in related issue JBEPP-459 for completeness. It is not
occuring in every performance test but only sometimes, so concurreny issue came to my mind
first.
I did more investigation and I founded that the cause of problem is in thread-unsafe call
of method "getUIComponentEventConfig" on class
"org.exoplatform.webui.config.Component".
Problem can be seen if client1 calls this method and eventsMap is null -> eventsMap is
going to initialize during this call.
But when client2 calls this method before initialization of map by client1 is finished,
then problem can happen because eventsMap is not fully initialized for client2 ->
client2 can't find ChangePageNode event -> listener
UIPageActionListener.ChangePageNodeActionListener is not called for client2 -> UIPortal
of client2 has unitialized variables selectedNode and selectedPath ->
NullPointerException is thrown for client2 during rendering of BreadcumbsPortlet, because
UIPortal.selectedPath is null.
Steps to reproduce (with usage of Eclispe IDE):
- Add breakpoint to class org.exoplatform.webui.config.Component to line 184 (after call
of eventMap = new HashMap<String, Event>() )
- Open browser1 and go to localhost:8080/portal/public/classic . Client will be stopped
on breakpoint
- Open browser2 and go to localhost:8080/portal/public/classic . This client is not
seeing ChangePageNode event and so NPE is thrown for him in UIBreadcumbsPortlet.
Note: Method getUIComponentEventConfig is called many times during single HTTP request.
So is it possible to fix this issue by other way that full initialization of this method?
Because it can have bad impact on performance. I wonder if it's possible to
initialize eventsMap in constructor of Component class (only suggestion)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:44 a.m.
New subject: [JBoss JIRA] Updated: (GTNPORTAL-1541) Concurreny problem - NullPointerException in BreadcumbsPortlet during performance test
[
https://jira.jboss.org/browse/GTNPORTAL-1541?page=com.atlassian.jira.plug...
]
Minh Hoang TO updated GTNPORTAL-1541:
-------------------------------------
Attachment: GTNPORTAL-1541-01-11-2010.patch
Concurreny problem - NullPointerException in BreadcumbsPortlet during
performance test
--------------------------------------------------------------------------------------
Key: GTNPORTAL-1541
URL: https://jira.jboss.org/browse/GTNPORTAL-1541
Project: GateIn Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: WebUI
Affects Versions: 3.1.0-GA
Environment: GateIn trunk (revision 4282) on EAP5
Reporter: Marek Posolda
Assignee: Minh Hoang TO
Attachments: .classpath, GTNPORTAL-1541-01-11-2010.patch,
GTNPORTAL-1541-01112010
Original Estimate: 6 hours
Remaining Estimate: 6 hours
Sometimes during performance test, I am seeing NPE exception in server log, thrown from
UIBreadcumbsPortlet. Exception stacktrace is:
2010-10-06 09:11:15,589 ERROR
[org.exoplatform.webui.application.portlet.PortletApplicationController]
(http-127.0.0.1-8080-4) Error while rendering the porlet
java.lang.NullPointerException
at
org.exoplatform.portal.webui.component.UIBreadcumbsPortlet.loadSelectedPath(UIBreadcumbsPortlet.java:69)
at
org.exoplatform.portal.webui.component.UIBreadcumbsPortlet.renderChildren(UIBreadcumbsPortlet.java:89)
at
org.exoplatform.webui.core.lifecycle.UIApplicationLifecycle.processRender(UIApplicationLifecycle.java:73)
at
org.exoplatform.webui.core.lifecycle.UIApplicationLifecycle.processRender(UIApplicationLifecycle.java:31)
at org.exoplatform.webui.core.UIComponent.processRender(UIComponent.java:144)
at
org.exoplatform.webui.core.UIPortletApplication.processRender(UIPortletApplication.java:146)
at
org.exoplatform.webui.application.portlet.PortletApplication.render(PortletApplication.java:253)
at
org.exoplatform.webui.application.portlet.PortletApplicationController.render(PortletApplicationController.java:110)
at
org.gatein.pc.portlet.impl.jsr168.PortletContainerImpl$Invoker.doFilter(PortletContainerImpl.java:569)
Whole test log is attached in related issue JBEPP-459 for completeness. It is not
occuring in every performance test but only sometimes, so concurreny issue came to my mind
first.
I did more investigation and I founded that the cause of problem is in thread-unsafe call
of method "getUIComponentEventConfig" on class
"org.exoplatform.webui.config.Component".
Problem can be seen if client1 calls this method and eventsMap is null -> eventsMap is
going to initialize during this call.
But when client2 calls this method before initialization of map by client1 is finished,
then problem can happen because eventsMap is not fully initialized for client2 ->
client2 can't find ChangePageNode event -> listener
UIPageActionListener.ChangePageNodeActionListener is not called for client2 -> UIPortal
of client2 has unitialized variables selectedNode and selectedPath ->
NullPointerException is thrown for client2 during rendering of BreadcumbsPortlet, because
UIPortal.selectedPath is null.
Steps to reproduce (with usage of Eclispe IDE):
- Add breakpoint to class org.exoplatform.webui.config.Component to line 184 (after call
of eventMap = new HashMap<String, Event>() )
- Open browser1 and go to localhost:8080/portal/public/classic . Client will be stopped
on breakpoint
- Open browser2 and go to localhost:8080/portal/public/classic . This client is not
seeing ChangePageNode event and so NPE is thrown for him in UIBreadcumbsPortlet.
Note: Method getUIComponentEventConfig is called many times during single HTTP request.
So is it possible to fix this issue by other way that full initialization of this method?
Because it can have bad impact on performance. I wonder if it's possible to
initialize eventsMap in constructor of Component class (only suggestion)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:22 a.m.
New subject: [JBoss JIRA] Updated: (GTNPORTAL-1541) Concurreny problem - NullPointerException in BreadcumbsPortlet during performance test
[
https://jira.jboss.org/browse/GTNPORTAL-1541?page=com.atlassian.jira.plug...
]
Minh Hoang TO updated GTNPORTAL-1541:
-------------------------------------
Labels: portal-s41 worked (was: portal-s41)
Concurreny problem - NullPointerException in BreadcumbsPortlet during
performance test
--------------------------------------------------------------------------------------
Key: GTNPORTAL-1541
URL: https://jira.jboss.org/browse/GTNPORTAL-1541
Project: GateIn Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: WebUI
Affects Versions: 3.1.0-GA
Environment: GateIn trunk (revision 4282) on EAP5
Reporter: Marek Posolda
Assignee: Minh Hoang TO
Attachments: .classpath, GTNPORTAL-1541-01-11-2010.patch,
GTNPORTAL-1541-01112010
Original Estimate: 6 hours
Remaining Estimate: 6 hours
Sometimes during performance test, I am seeing NPE exception in server log, thrown from
UIBreadcumbsPortlet. Exception stacktrace is:
2010-10-06 09:11:15,589 ERROR
[org.exoplatform.webui.application.portlet.PortletApplicationController]
(http-127.0.0.1-8080-4) Error while rendering the porlet
java.lang.NullPointerException
at
org.exoplatform.portal.webui.component.UIBreadcumbsPortlet.loadSelectedPath(UIBreadcumbsPortlet.java:69)
at
org.exoplatform.portal.webui.component.UIBreadcumbsPortlet.renderChildren(UIBreadcumbsPortlet.java:89)
at
org.exoplatform.webui.core.lifecycle.UIApplicationLifecycle.processRender(UIApplicationLifecycle.java:73)
at
org.exoplatform.webui.core.lifecycle.UIApplicationLifecycle.processRender(UIApplicationLifecycle.java:31)
at org.exoplatform.webui.core.UIComponent.processRender(UIComponent.java:144)
at
org.exoplatform.webui.core.UIPortletApplication.processRender(UIPortletApplication.java:146)
at
org.exoplatform.webui.application.portlet.PortletApplication.render(PortletApplication.java:253)
at
org.exoplatform.webui.application.portlet.PortletApplicationController.render(PortletApplicationController.java:110)
at
org.gatein.pc.portlet.impl.jsr168.PortletContainerImpl$Invoker.doFilter(PortletContainerImpl.java:569)
Whole test log is attached in related issue JBEPP-459 for completeness. It is not
occuring in every performance test but only sometimes, so concurreny issue came to my mind
first.
I did more investigation and I founded that the cause of problem is in thread-unsafe call
of method "getUIComponentEventConfig" on class
"org.exoplatform.webui.config.Component".
Problem can be seen if client1 calls this method and eventsMap is null -> eventsMap is
going to initialize during this call.
But when client2 calls this method before initialization of map by client1 is finished,
then problem can happen because eventsMap is not fully initialized for client2 ->
client2 can't find ChangePageNode event -> listener
UIPageActionListener.ChangePageNodeActionListener is not called for client2 -> UIPortal
of client2 has unitialized variables selectedNode and selectedPath ->
NullPointerException is thrown for client2 during rendering of BreadcumbsPortlet, because
UIPortal.selectedPath is null.
Steps to reproduce (with usage of Eclispe IDE):
- Add breakpoint to class org.exoplatform.webui.config.Component to line 184 (after call
of eventMap = new HashMap<String, Event>() )
- Open browser1 and go to localhost:8080/portal/public/classic . Client will be stopped
on breakpoint
- Open browser2 and go to localhost:8080/portal/public/classic . This client is not
seeing ChangePageNode event and so NPE is thrown for him in UIBreadcumbsPortlet.
Note: Method getUIComponentEventConfig is called many times during single HTTP request.
So is it possible to fix this issue by other way that full initialization of this method?
Because it can have bad impact on performance. I wonder if it's possible to
initialize eventsMap in constructor of Component class (only suggestion)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:35 a.m.
New subject: [JBoss JIRA] Updated: (GTNPORTAL-1541) Concurreny problem - NullPointerException in BreadcumbsPortlet during performance test
[
https://jira.jboss.org/browse/GTNPORTAL-1541?page=com.atlassian.jira.plug...
]
Minh Hoang TO updated GTNPORTAL-1541:
-------------------------------------
Labels: portal-s41 worked patch_proposed (was: portal-s41 worked)
Concurreny problem - NullPointerException in BreadcumbsPortlet during
performance test
--------------------------------------------------------------------------------------
Key: GTNPORTAL-1541
URL: https://jira.jboss.org/browse/GTNPORTAL-1541
Project: GateIn Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: WebUI
Affects Versions: 3.1.0-GA
Environment: GateIn trunk (revision 4282) on EAP5
Reporter: Marek Posolda
Assignee: Minh Hoang TO
Attachments: .classpath, GTNPORTAL-1541-01-11-2010.patch,
GTNPORTAL-1541-01112010
Original Estimate: 6 hours
Remaining Estimate: 6 hours
Sometimes during performance test, I am seeing NPE exception in server log, thrown from
UIBreadcumbsPortlet. Exception stacktrace is:
2010-10-06 09:11:15,589 ERROR
[org.exoplatform.webui.application.portlet.PortletApplicationController]
(http-127.0.0.1-8080-4) Error while rendering the porlet
java.lang.NullPointerException
at
org.exoplatform.portal.webui.component.UIBreadcumbsPortlet.loadSelectedPath(UIBreadcumbsPortlet.java:69)
at
org.exoplatform.portal.webui.component.UIBreadcumbsPortlet.renderChildren(UIBreadcumbsPortlet.java:89)
at
org.exoplatform.webui.core.lifecycle.UIApplicationLifecycle.processRender(UIApplicationLifecycle.java:73)
at
org.exoplatform.webui.core.lifecycle.UIApplicationLifecycle.processRender(UIApplicationLifecycle.java:31)
at org.exoplatform.webui.core.UIComponent.processRender(UIComponent.java:144)
at
org.exoplatform.webui.core.UIPortletApplication.processRender(UIPortletApplication.java:146)
at
org.exoplatform.webui.application.portlet.PortletApplication.render(PortletApplication.java:253)
at
org.exoplatform.webui.application.portlet.PortletApplicationController.render(PortletApplicationController.java:110)
at
org.gatein.pc.portlet.impl.jsr168.PortletContainerImpl$Invoker.doFilter(PortletContainerImpl.java:569)
Whole test log is attached in related issue JBEPP-459 for completeness. It is not
occuring in every performance test but only sometimes, so concurreny issue came to my mind
first.
I did more investigation and I founded that the cause of problem is in thread-unsafe call
of method "getUIComponentEventConfig" on class
"org.exoplatform.webui.config.Component".
Problem can be seen if client1 calls this method and eventsMap is null -> eventsMap is
going to initialize during this call.
But when client2 calls this method before initialization of map by client1 is finished,
then problem can happen because eventsMap is not fully initialized for client2 ->
client2 can't find ChangePageNode event -> listener
UIPageActionListener.ChangePageNodeActionListener is not called for client2 -> UIPortal
of client2 has unitialized variables selectedNode and selectedPath ->
NullPointerException is thrown for client2 during rendering of BreadcumbsPortlet, because
UIPortal.selectedPath is null.
Steps to reproduce (with usage of Eclispe IDE):
- Add breakpoint to class org.exoplatform.webui.config.Component to line 184 (after call
of eventMap = new HashMap<String, Event>() )
- Open browser1 and go to localhost:8080/portal/public/classic . Client will be stopped
on breakpoint
- Open browser2 and go to localhost:8080/portal/public/classic . This client is not
seeing ChangePageNode event and so NPE is thrown for him in UIBreadcumbsPortlet.
Note: Method getUIComponentEventConfig is called many times during single HTTP request.
So is it possible to fix this issue by other way that full initialization of this method?
Because it can have bad impact on performance. I wonder if it's possible to
initialize eventsMap in constructor of Component class (only suggestion)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:03 p.m.
New subject: [JBoss JIRA] Updated: (GTNPORTAL-1541) Concurreny problem - NullPointerException in BreadcumbsPortlet during performance test
[
https://jira.jboss.org/browse/GTNPORTAL-1541?page=com.atlassian.jira.plug...
]
Minh Hoang TO updated GTNPORTAL-1541:
-------------------------------------
Labels: portal-s41 worked (was: portal-s41 worked patch_proposed)
Concurreny problem - NullPointerException in BreadcumbsPortlet during
performance test
--------------------------------------------------------------------------------------
Key: GTNPORTAL-1541
URL: https://jira.jboss.org/browse/GTNPORTAL-1541
Project: GateIn Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: WebUI
Affects Versions: 3.1.0-GA
Environment: GateIn trunk (revision 4282) on EAP5
Reporter: Marek Posolda
Assignee: Minh Hoang TO
Attachments: .classpath, GTNPORTAL-1541-01-11-2010.patch,
GTNPORTAL-1541-01112010
Original Estimate: 6 hours
Remaining Estimate: 6 hours
Sometimes during performance test, I am seeing NPE exception in server log, thrown from
UIBreadcumbsPortlet. Exception stacktrace is:
2010-10-06 09:11:15,589 ERROR
[org.exoplatform.webui.application.portlet.PortletApplicationController]
(http-127.0.0.1-8080-4) Error while rendering the porlet
java.lang.NullPointerException
at
org.exoplatform.portal.webui.component.UIBreadcumbsPortlet.loadSelectedPath(UIBreadcumbsPortlet.java:69)
at
org.exoplatform.portal.webui.component.UIBreadcumbsPortlet.renderChildren(UIBreadcumbsPortlet.java:89)
at
org.exoplatform.webui.core.lifecycle.UIApplicationLifecycle.processRender(UIApplicationLifecycle.java:73)
at
org.exoplatform.webui.core.lifecycle.UIApplicationLifecycle.processRender(UIApplicationLifecycle.java:31)
at org.exoplatform.webui.core.UIComponent.processRender(UIComponent.java:144)
at
org.exoplatform.webui.core.UIPortletApplication.processRender(UIPortletApplication.java:146)
at
org.exoplatform.webui.application.portlet.PortletApplication.render(PortletApplication.java:253)
at
org.exoplatform.webui.application.portlet.PortletApplicationController.render(PortletApplicationController.java:110)
at
org.gatein.pc.portlet.impl.jsr168.PortletContainerImpl$Invoker.doFilter(PortletContainerImpl.java:569)
Whole test log is attached in related issue JBEPP-459 for completeness. It is not
occuring in every performance test but only sometimes, so concurreny issue came to my mind
first.
I did more investigation and I founded that the cause of problem is in thread-unsafe call
of method "getUIComponentEventConfig" on class
"org.exoplatform.webui.config.Component".
Problem can be seen if client1 calls this method and eventsMap is null -> eventsMap is
going to initialize during this call.
But when client2 calls this method before initialization of map by client1 is finished,
then problem can happen because eventsMap is not fully initialized for client2 ->
client2 can't find ChangePageNode event -> listener
UIPageActionListener.ChangePageNodeActionListener is not called for client2 -> UIPortal
of client2 has unitialized variables selectedNode and selectedPath ->
NullPointerException is thrown for client2 during rendering of BreadcumbsPortlet, because
UIPortal.selectedPath is null.
Steps to reproduce (with usage of Eclispe IDE):
- Add breakpoint to class org.exoplatform.webui.config.Component to line 184 (after call
of eventMap = new HashMap<String, Event>() )
- Open browser1 and go to localhost:8080/portal/public/classic . Client will be stopped
on breakpoint
- Open browser2 and go to localhost:8080/portal/public/classic . This client is not
seeing ChangePageNode event and so NPE is thrown for him in UIBreadcumbsPortlet.
Note: Method getUIComponentEventConfig is called many times during single HTTP request.
So is it possible to fix this issue by other way that full initialization of this method?
Because it can have bad impact on performance. I wonder if it's possible to
initialize eventsMap in constructor of Component class (only suggestion)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:49 p.m.
New subject: [JBoss JIRA] Resolved: (GTNPORTAL-1541) Concurreny problem - NullPointerException in BreadcumbsPortlet during performance test
[
https://jira.jboss.org/browse/GTNPORTAL-1541?page=com.atlassian.jira.plug...
]
Trong Tran resolved GTNPORTAL-1541.
-----------------------------------
Fix Version/s: 3.2.0-GA
Resolution: Done
Concurreny problem - NullPointerException in BreadcumbsPortlet during
performance test
--------------------------------------------------------------------------------------
Key: GTNPORTAL-1541
URL: https://jira.jboss.org/browse/GTNPORTAL-1541
Project: GateIn Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: WebUI
Affects Versions: 3.1.0-GA
Environment: GateIn trunk (revision 4282) on EAP5
Reporter: Marek Posolda
Assignee: Minh Hoang TO
Fix For: 3.2.0-GA
Attachments: .classpath, GTNPORTAL-1541-01-11-2010.patch,
GTNPORTAL-1541-01112010
Original Estimate: 6 hours
Remaining Estimate: 6 hours
Sometimes during performance test, I am seeing NPE exception in server log, thrown from
UIBreadcumbsPortlet. Exception stacktrace is:
2010-10-06 09:11:15,589 ERROR
[org.exoplatform.webui.application.portlet.PortletApplicationController]
(http-127.0.0.1-8080-4) Error while rendering the porlet
java.lang.NullPointerException
at
org.exoplatform.portal.webui.component.UIBreadcumbsPortlet.loadSelectedPath(UIBreadcumbsPortlet.java:69)
at
org.exoplatform.portal.webui.component.UIBreadcumbsPortlet.renderChildren(UIBreadcumbsPortlet.java:89)
at
org.exoplatform.webui.core.lifecycle.UIApplicationLifecycle.processRender(UIApplicationLifecycle.java:73)
at
org.exoplatform.webui.core.lifecycle.UIApplicationLifecycle.processRender(UIApplicationLifecycle.java:31)
at org.exoplatform.webui.core.UIComponent.processRender(UIComponent.java:144)
at
org.exoplatform.webui.core.UIPortletApplication.processRender(UIPortletApplication.java:146)
at
org.exoplatform.webui.application.portlet.PortletApplication.render(PortletApplication.java:253)
at
org.exoplatform.webui.application.portlet.PortletApplicationController.render(PortletApplicationController.java:110)
at
org.gatein.pc.portlet.impl.jsr168.PortletContainerImpl$Invoker.doFilter(PortletContainerImpl.java:569)
Whole test log is attached in related issue JBEPP-459 for completeness. It is not
occuring in every performance test but only sometimes, so concurreny issue came to my mind
first.
I did more investigation and I founded that the cause of problem is in thread-unsafe call
of method "getUIComponentEventConfig" on class
"org.exoplatform.webui.config.Component".
Problem can be seen if client1 calls this method and eventsMap is null -> eventsMap is
going to initialize during this call.
But when client2 calls this method before initialization of map by client1 is finished,
then problem can happen because eventsMap is not fully initialized for client2 ->
client2 can't find ChangePageNode event -> listener
UIPageActionListener.ChangePageNodeActionListener is not called for client2 -> UIPortal
of client2 has unitialized variables selectedNode and selectedPath ->
NullPointerException is thrown for client2 during rendering of BreadcumbsPortlet, because
UIPortal.selectedPath is null.
Steps to reproduce (with usage of Eclispe IDE):
- Add breakpoint to class org.exoplatform.webui.config.Component to line 184 (after call
of eventMap = new HashMap<String, Event>() )
- Open browser1 and go to localhost:8080/portal/public/classic . Client will be stopped
on breakpoint
- Open browser2 and go to localhost:8080/portal/public/classic . This client is not
seeing ChangePageNode event and so NPE is thrown for him in UIBreadcumbsPortlet.
Note: Method getUIComponentEventConfig is called many times during single HTTP request.
So is it possible to fix this issue by other way that full initialization of this method?
Because it can have bad impact on performance. I wonder if it's possible to
initialize eventsMap in constructor of Component class (only suggestion)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:52 a.m.
New subject: [JBoss JIRA] Reopened: (GTNPORTAL-1541) Concurreny problem - NullPointerException in BreadcumbsPortlet during performance test
[
https://jira.jboss.org/browse/GTNPORTAL-1541?page=com.atlassian.jira.plug...
]
Marek Posolda reopened GTNPORTAL-1541:
--------------------------------------
I am reopening issue because sometimes I am still seeing the problem and exceptions in
log.
Problem can occur when client1 go to synchronize block and create eventMap, but client2 is
not forced to go to synchronized block and he can see eventMap before its fully
initialized by client1. This means that client2 is not seeing listener and this listener
is not called for him.
Concurreny problem - NullPointerException in BreadcumbsPortlet during
performance test
--------------------------------------------------------------------------------------
Key: GTNPORTAL-1541
URL: https://jira.jboss.org/browse/GTNPORTAL-1541
Project: GateIn Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: WebUI
Affects Versions: 3.1.0-GA
Environment: GateIn trunk (revision 4282) on EAP5
Reporter: Marek Posolda
Assignee: Minh Hoang TO
Labels: portal-s41, worked
Fix For: 3.2.0-GA
Attachments: .classpath, GTNPORTAL-1541-01-11-2010.patch,
GTNPORTAL-1541-01112010
Original Estimate: 6 hours
Remaining Estimate: 6 hours
Sometimes during performance test, I am seeing NPE exception in server log, thrown from
UIBreadcumbsPortlet. Exception stacktrace is:
2010-10-06 09:11:15,589 ERROR
[org.exoplatform.webui.application.portlet.PortletApplicationController]
(http-127.0.0.1-8080-4) Error while rendering the porlet
java.lang.NullPointerException
at
org.exoplatform.portal.webui.component.UIBreadcumbsPortlet.loadSelectedPath(UIBreadcumbsPortlet.java:69)
at
org.exoplatform.portal.webui.component.UIBreadcumbsPortlet.renderChildren(UIBreadcumbsPortlet.java:89)
at
org.exoplatform.webui.core.lifecycle.UIApplicationLifecycle.processRender(UIApplicationLifecycle.java:73)
at
org.exoplatform.webui.core.lifecycle.UIApplicationLifecycle.processRender(UIApplicationLifecycle.java:31)
at org.exoplatform.webui.core.UIComponent.processRender(UIComponent.java:144)
at
org.exoplatform.webui.core.UIPortletApplication.processRender(UIPortletApplication.java:146)
at
org.exoplatform.webui.application.portlet.PortletApplication.render(PortletApplication.java:253)
at
org.exoplatform.webui.application.portlet.PortletApplicationController.render(PortletApplicationController.java:110)
at
org.gatein.pc.portlet.impl.jsr168.PortletContainerImpl$Invoker.doFilter(PortletContainerImpl.java:569)
Whole test log is attached in related issue JBEPP-459 for completeness. It is not
occuring in every performance test but only sometimes, so concurreny issue came to my mind
first.
I did more investigation and I founded that the cause of problem is in thread-unsafe call
of method "getUIComponentEventConfig" on class
"org.exoplatform.webui.config.Component".
Problem can be seen if client1 calls this method and eventsMap is null -> eventsMap is
going to initialize during this call.
But when client2 calls this method before initialization of map by client1 is finished,
then problem can happen because eventsMap is not fully initialized for client2 ->
client2 can't find ChangePageNode event -> listener
UIPageActionListener.ChangePageNodeActionListener is not called for client2 -> UIPortal
of client2 has unitialized variables selectedNode and selectedPath ->
NullPointerException is thrown for client2 during rendering of BreadcumbsPortlet, because
UIPortal.selectedPath is null.
Steps to reproduce (with usage of Eclispe IDE):
- Add breakpoint to class org.exoplatform.webui.config.Component to line 184 (after call
of eventMap = new HashMap<String, Event>() )
- Open browser1 and go to localhost:8080/portal/public/classic . Client will be stopped
on breakpoint
- Open browser2 and go to localhost:8080/portal/public/classic . This client is not
seeing ChangePageNode event and so NPE is thrown for him in UIBreadcumbsPortlet.
Note: Method getUIComponentEventConfig is called many times during single HTTP request.
So is it possible to fix this issue by other way that full initialization of this method?
Because it can have bad impact on performance. I wonder if it's possible to
initialize eventsMap in constructor of Component class (only suggestion)
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:58 a.m.
New subject: [JBoss JIRA] Updated: (GTNPORTAL-1541) Concurreny problem - NullPointerException in BreadcumbsPortlet during performance test
[
https://jira.jboss.org/browse/GTNPORTAL-1541?page=com.atlassian.jira.plug...
]
Marek Posolda updated GTNPORTAL-1541:
-------------------------------------
Attachment: concurrentReadUnitTest.zip
I am attaching unit test in file concurrentReadUnitTest.zip. It contains directory
"test" and it can be simply unpacked to webui/portal/src directory (Right now
webui/portal project does not contains any unit tests).
Sometimes this test is passing for me but sometimes it fails. Behaviour is non
deterministic because of concurrency.
I hope it can help you to better ilustrate the problem.
Concurreny problem - NullPointerException in BreadcumbsPortlet during
performance test
--------------------------------------------------------------------------------------
Key: GTNPORTAL-1541
URL: https://jira.jboss.org/browse/GTNPORTAL-1541
Project: GateIn Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: WebUI
Affects Versions: 3.1.0-GA
Environment: GateIn trunk (revision 4282) on EAP5
Reporter: Marek Posolda
Assignee: Minh Hoang TO
Labels: portal-s41, worked
Fix For: 3.2.0-GA
Attachments: .classpath, concurrentReadUnitTest.zip,
GTNPORTAL-1541-01-11-2010.patch, GTNPORTAL-1541-01112010
Original Estimate: 6 hours
Remaining Estimate: 6 hours
Sometimes during performance test, I am seeing NPE exception in server log, thrown from
UIBreadcumbsPortlet. Exception stacktrace is:
2010-10-06 09:11:15,589 ERROR
[org.exoplatform.webui.application.portlet.PortletApplicationController]
(http-127.0.0.1-8080-4) Error while rendering the porlet
java.lang.NullPointerException
at
org.exoplatform.portal.webui.component.UIBreadcumbsPortlet.loadSelectedPath(UIBreadcumbsPortlet.java:69)
at
org.exoplatform.portal.webui.component.UIBreadcumbsPortlet.renderChildren(UIBreadcumbsPortlet.java:89)
at
org.exoplatform.webui.core.lifecycle.UIApplicationLifecycle.processRender(UIApplicationLifecycle.java:73)
at
org.exoplatform.webui.core.lifecycle.UIApplicationLifecycle.processRender(UIApplicationLifecycle.java:31)
at org.exoplatform.webui.core.UIComponent.processRender(UIComponent.java:144)
at
org.exoplatform.webui.core.UIPortletApplication.processRender(UIPortletApplication.java:146)
at
org.exoplatform.webui.application.portlet.PortletApplication.render(PortletApplication.java:253)
at
org.exoplatform.webui.application.portlet.PortletApplicationController.render(PortletApplicationController.java:110)
at
org.gatein.pc.portlet.impl.jsr168.PortletContainerImpl$Invoker.doFilter(PortletContainerImpl.java:569)
Whole test log is attached in related issue JBEPP-459 for completeness. It is not
occuring in every performance test but only sometimes, so concurreny issue came to my mind
first.
I did more investigation and I founded that the cause of problem is in thread-unsafe call
of method "getUIComponentEventConfig" on class
"org.exoplatform.webui.config.Component".
Problem can be seen if client1 calls this method and eventsMap is null -> eventsMap is
going to initialize during this call.
But when client2 calls this method before initialization of map by client1 is finished,
then problem can happen because eventsMap is not fully initialized for client2 ->
client2 can't find ChangePageNode event -> listener
UIPageActionListener.ChangePageNodeActionListener is not called for client2 -> UIPortal
of client2 has unitialized variables selectedNode and selectedPath ->
NullPointerException is thrown for client2 during rendering of BreadcumbsPortlet, because
UIPortal.selectedPath is null.
Steps to reproduce (with usage of Eclispe IDE):
- Add breakpoint to class org.exoplatform.webui.config.Component to line 184 (after call
of eventMap = new HashMap<String, Event>() )
- Open browser1 and go to localhost:8080/portal/public/classic . Client will be stopped
on breakpoint
- Open browser2 and go to localhost:8080/portal/public/classic . This client is not
seeing ChangePageNode event and so NPE is thrown for him in UIBreadcumbsPortlet.
Note: Method getUIComponentEventConfig is called many times during single HTTP request.
So is it possible to fix this issue by other way that full initialization of this method?
Because it can have bad impact on performance. I wonder if it's possible to
initialize eventsMap in constructor of Component class (only suggestion)
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:54 a.m.
New subject: [JBoss JIRA] Commented: (GTNPORTAL-1541) Concurreny problem - NullPointerException in BreadcumbsPortlet during performance test
[
https://jira.jboss.org/browse/GTNPORTAL-1541?page=com.atlassian.jira.plug...
]
Minh Hoang TO commented on GTNPORTAL-1541:
------------------------------------------
I got an article explaining why double-check could still fail
http://www.ibm.com/developerworks/java/library/j-dcl.html
Concurreny problem - NullPointerException in BreadcumbsPortlet during
performance test
--------------------------------------------------------------------------------------
Key: GTNPORTAL-1541
URL: https://jira.jboss.org/browse/GTNPORTAL-1541
Project: GateIn Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: WebUI
Affects Versions: 3.1.0-GA
Environment: GateIn trunk (revision 4282) on EAP5
Reporter: Marek Posolda
Assignee: Minh Hoang TO
Labels: portal-s41, worked
Fix For: 3.2.0-GA
Attachments: .classpath, concurrentReadUnitTest.zip,
GTNPORTAL-1541-01-11-2010.patch, GTNPORTAL-1541-01112010
Original Estimate: 6 hours
Remaining Estimate: 6 hours
Sometimes during performance test, I am seeing NPE exception in server log, thrown from
UIBreadcumbsPortlet. Exception stacktrace is:
2010-10-06 09:11:15,589 ERROR
[org.exoplatform.webui.application.portlet.PortletApplicationController]
(http-127.0.0.1-8080-4) Error while rendering the porlet
java.lang.NullPointerException
at
org.exoplatform.portal.webui.component.UIBreadcumbsPortlet.loadSelectedPath(UIBreadcumbsPortlet.java:69)
at
org.exoplatform.portal.webui.component.UIBreadcumbsPortlet.renderChildren(UIBreadcumbsPortlet.java:89)
at
org.exoplatform.webui.core.lifecycle.UIApplicationLifecycle.processRender(UIApplicationLifecycle.java:73)
at
org.exoplatform.webui.core.lifecycle.UIApplicationLifecycle.processRender(UIApplicationLifecycle.java:31)
at org.exoplatform.webui.core.UIComponent.processRender(UIComponent.java:144)
at
org.exoplatform.webui.core.UIPortletApplication.processRender(UIPortletApplication.java:146)
at
org.exoplatform.webui.application.portlet.PortletApplication.render(PortletApplication.java:253)
at
org.exoplatform.webui.application.portlet.PortletApplicationController.render(PortletApplicationController.java:110)
at
org.gatein.pc.portlet.impl.jsr168.PortletContainerImpl$Invoker.doFilter(PortletContainerImpl.java:569)
Whole test log is attached in related issue JBEPP-459 for completeness. It is not
occuring in every performance test but only sometimes, so concurreny issue came to my mind
first.
I did more investigation and I founded that the cause of problem is in thread-unsafe call
of method "getUIComponentEventConfig" on class
"org.exoplatform.webui.config.Component".
Problem can be seen if client1 calls this method and eventsMap is null -> eventsMap is
going to initialize during this call.
But when client2 calls this method before initialization of map by client1 is finished,
then problem can happen because eventsMap is not fully initialized for client2 ->
client2 can't find ChangePageNode event -> listener
UIPageActionListener.ChangePageNodeActionListener is not called for client2 -> UIPortal
of client2 has unitialized variables selectedNode and selectedPath ->
NullPointerException is thrown for client2 during rendering of BreadcumbsPortlet, because
UIPortal.selectedPath is null.
Steps to reproduce (with usage of Eclispe IDE):
- Add breakpoint to class org.exoplatform.webui.config.Component to line 184 (after call
of eventMap = new HashMap<String, Event>() )
- Open browser1 and go to localhost:8080/portal/public/classic . Client will be stopped
on breakpoint
- Open browser2 and go to localhost:8080/portal/public/classic . This client is not
seeing ChangePageNode event and so NPE is thrown for him in UIBreadcumbsPortlet.
Note: Method getUIComponentEventConfig is called many times during single HTTP request.
So is it possible to fix this issue by other way that full initialization of this method?
Because it can have bad impact on performance. I wonder if it's possible to
initialize eventsMap in constructor of Component class (only suggestion)
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:31 a.m.
New subject: [JBoss JIRA] Updated: (GTNPORTAL-1541) Concurreny problem - NullPointerException in BreadcumbsPortlet during performance test
[
https://jira.jboss.org/browse/GTNPORTAL-1541?page=com.atlassian.jira.plug...
]
Minh Hoang TO updated GTNPORTAL-1541:
-------------------------------------
Labels: portal-s41 portal-s43 worked (was: portal-s41 worked)
Assignee should apply the JUnit tests for concurrency handling in UIComponent layer
Concurreny problem - NullPointerException in BreadcumbsPortlet during
performance test
--------------------------------------------------------------------------------------
Key: GTNPORTAL-1541
URL: https://jira.jboss.org/browse/GTNPORTAL-1541
Project: GateIn Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: WebUI
Affects Versions: 3.1.0-GA
Environment: GateIn trunk (revision 4282) on EAP5
Reporter: Marek Posolda
Assignee: Minh Hoang TO
Labels: portal-s41, portal-s43, worked
Fix For: 3.2.0-GA
Attachments: .classpath, concurrentReadUnitTest.zip,
GTNPORTAL-1541-01-11-2010.patch, GTNPORTAL-1541-01112010
Original Estimate: 6 hours
Remaining Estimate: 6 hours
Sometimes during performance test, I am seeing NPE exception in server log, thrown from
UIBreadcumbsPortlet. Exception stacktrace is:
2010-10-06 09:11:15,589 ERROR
[org.exoplatform.webui.application.portlet.PortletApplicationController]
(http-127.0.0.1-8080-4) Error while rendering the porlet
java.lang.NullPointerException
at
org.exoplatform.portal.webui.component.UIBreadcumbsPortlet.loadSelectedPath(UIBreadcumbsPortlet.java:69)
at
org.exoplatform.portal.webui.component.UIBreadcumbsPortlet.renderChildren(UIBreadcumbsPortlet.java:89)
at
org.exoplatform.webui.core.lifecycle.UIApplicationLifecycle.processRender(UIApplicationLifecycle.java:73)
at
org.exoplatform.webui.core.lifecycle.UIApplicationLifecycle.processRender(UIApplicationLifecycle.java:31)
at org.exoplatform.webui.core.UIComponent.processRender(UIComponent.java:144)
at
org.exoplatform.webui.core.UIPortletApplication.processRender(UIPortletApplication.java:146)
at
org.exoplatform.webui.application.portlet.PortletApplication.render(PortletApplication.java:253)
at
org.exoplatform.webui.application.portlet.PortletApplicationController.render(PortletApplicationController.java:110)
at
org.gatein.pc.portlet.impl.jsr168.PortletContainerImpl$Invoker.doFilter(PortletContainerImpl.java:569)
Whole test log is attached in related issue JBEPP-459 for completeness. It is not
occuring in every performance test but only sometimes, so concurreny issue came to my mind
first.
I did more investigation and I founded that the cause of problem is in thread-unsafe call
of method "getUIComponentEventConfig" on class
"org.exoplatform.webui.config.Component".
Problem can be seen if client1 calls this method and eventsMap is null -> eventsMap is
going to initialize during this call.
But when client2 calls this method before initialization of map by client1 is finished,
then problem can happen because eventsMap is not fully initialized for client2 ->
client2 can't find ChangePageNode event -> listener
UIPageActionListener.ChangePageNodeActionListener is not called for client2 -> UIPortal
of client2 has unitialized variables selectedNode and selectedPath ->
NullPointerException is thrown for client2 during rendering of BreadcumbsPortlet, because
UIPortal.selectedPath is null.
Steps to reproduce (with usage of Eclispe IDE):
- Add breakpoint to class org.exoplatform.webui.config.Component to line 184 (after call
of eventMap = new HashMap<String, Event>() )
- Open browser1 and go to localhost:8080/portal/public/classic . Client will be stopped
on breakpoint
- Open browser2 and go to localhost:8080/portal/public/classic . This client is not
seeing ChangePageNode event and so NPE is thrown for him in UIBreadcumbsPortlet.
Note: Method getUIComponentEventConfig is called many times during single HTTP request.
So is it possible to fix this issue by other way that full initialization of this method?
Because it can have bad impact on performance. I wonder if it's possible to
initialize eventsMap in constructor of Component class (only suggestion)
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:36 p.m.
New subject: [JBoss JIRA] Commented: (GTNPORTAL-1541) Concurreny problem - NullPointerException in BreadcumbsPortlet during performance test
[
https://jira.jboss.org/browse/GTNPORTAL-1541?page=com.atlassian.jira.plug...
]
Minh Hoang TO commented on GTNPORTAL-1541:
------------------------------------------
JUnit tests applied
Concurreny problem - NullPointerException in BreadcumbsPortlet during
performance test
--------------------------------------------------------------------------------------
Key: GTNPORTAL-1541
URL: https://jira.jboss.org/browse/GTNPORTAL-1541
Project: GateIn Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: WebUI
Affects Versions: 3.1.0-GA
Environment: GateIn trunk (revision 4282) on EAP5
Reporter: Marek Posolda
Assignee: Minh Hoang TO
Labels: portal-s41, portal-s43, worked
Fix For: 3.2.0-GA
Attachments: .classpath, concurrentReadUnitTest.zip,
GTNPORTAL-1541-01-11-2010.patch, GTNPORTAL-1541-01112010
Original Estimate: 6 hours
Remaining Estimate: 6 hours
Sometimes during performance test, I am seeing NPE exception in server log, thrown from
UIBreadcumbsPortlet. Exception stacktrace is:
2010-10-06 09:11:15,589 ERROR
[org.exoplatform.webui.application.portlet.PortletApplicationController]
(http-127.0.0.1-8080-4) Error while rendering the porlet
java.lang.NullPointerException
at
org.exoplatform.portal.webui.component.UIBreadcumbsPortlet.loadSelectedPath(UIBreadcumbsPortlet.java:69)
at
org.exoplatform.portal.webui.component.UIBreadcumbsPortlet.renderChildren(UIBreadcumbsPortlet.java:89)
at
org.exoplatform.webui.core.lifecycle.UIApplicationLifecycle.processRender(UIApplicationLifecycle.java:73)
at
org.exoplatform.webui.core.lifecycle.UIApplicationLifecycle.processRender(UIApplicationLifecycle.java:31)
at org.exoplatform.webui.core.UIComponent.processRender(UIComponent.java:144)
at
org.exoplatform.webui.core.UIPortletApplication.processRender(UIPortletApplication.java:146)
at
org.exoplatform.webui.application.portlet.PortletApplication.render(PortletApplication.java:253)
at
org.exoplatform.webui.application.portlet.PortletApplicationController.render(PortletApplicationController.java:110)
at
org.gatein.pc.portlet.impl.jsr168.PortletContainerImpl$Invoker.doFilter(PortletContainerImpl.java:569)
Whole test log is attached in related issue JBEPP-459 for completeness. It is not
occuring in every performance test but only sometimes, so concurreny issue came to my mind
first.
I did more investigation and I founded that the cause of problem is in thread-unsafe call
of method "getUIComponentEventConfig" on class
"org.exoplatform.webui.config.Component".
Problem can be seen if client1 calls this method and eventsMap is null -> eventsMap is
going to initialize during this call.
But when client2 calls this method before initialization of map by client1 is finished,
then problem can happen because eventsMap is not fully initialized for client2 ->
client2 can't find ChangePageNode event -> listener
UIPageActionListener.ChangePageNodeActionListener is not called for client2 -> UIPortal
of client2 has unitialized variables selectedNode and selectedPath ->
NullPointerException is thrown for client2 during rendering of BreadcumbsPortlet, because
UIPortal.selectedPath is null.
Steps to reproduce (with usage of Eclispe IDE):
- Add breakpoint to class org.exoplatform.webui.config.Component to line 184 (after call
of eventMap = new HashMap<String, Event>() )
- Open browser1 and go to localhost:8080/portal/public/classic . Client will be stopped
on breakpoint
- Open browser2 and go to localhost:8080/portal/public/classic . This client is not
seeing ChangePageNode event and so NPE is thrown for him in UIBreadcumbsPortlet.
Note: Method getUIComponentEventConfig is called many times during single HTTP request.
So is it possible to fix this issue by other way that full initialization of this method?
Because it can have bad impact on performance. I wonder if it's possible to
initialize eventsMap in constructor of Component class (only suggestion)
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:14 a.m.
New subject: [JBoss JIRA] Commented: (GTNPORTAL-1541) Concurreny problem - NullPointerException in BreadcumbsPortlet during performance test
[
https://jira.jboss.org/browse/GTNPORTAL-1541?page=com.atlassian.jira.plug...
]
Minh Hoang TO commented on GTNPORTAL-1541:
------------------------------------------
I added the volatile specifier on eventMap field to avoid reordering issue which prevent
double-check from working properly
Concurreny problem - NullPointerException in BreadcumbsPortlet during
performance test
--------------------------------------------------------------------------------------
Key: GTNPORTAL-1541
URL: https://jira.jboss.org/browse/GTNPORTAL-1541
Project: GateIn Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: WebUI
Affects Versions: 3.1.0-GA
Environment: GateIn trunk (revision 4282) on EAP5
Reporter: Marek Posolda
Assignee: Minh Hoang TO
Labels: portal-s41, portal-s43, worked
Fix For: 3.2.0-GA
Attachments: .classpath, concurrentReadUnitTest.zip,
GTNPORTAL-1541-01-11-2010.patch, GTNPORTAL-1541-01112010
Original Estimate: 6 hours
Remaining Estimate: 6 hours
Sometimes during performance test, I am seeing NPE exception in server log, thrown from
UIBreadcumbsPortlet. Exception stacktrace is:
2010-10-06 09:11:15,589 ERROR
[org.exoplatform.webui.application.portlet.PortletApplicationController]
(http-127.0.0.1-8080-4) Error while rendering the porlet
java.lang.NullPointerException
at
org.exoplatform.portal.webui.component.UIBreadcumbsPortlet.loadSelectedPath(UIBreadcumbsPortlet.java:69)
at
org.exoplatform.portal.webui.component.UIBreadcumbsPortlet.renderChildren(UIBreadcumbsPortlet.java:89)
at
org.exoplatform.webui.core.lifecycle.UIApplicationLifecycle.processRender(UIApplicationLifecycle.java:73)
at
org.exoplatform.webui.core.lifecycle.UIApplicationLifecycle.processRender(UIApplicationLifecycle.java:31)
at org.exoplatform.webui.core.UIComponent.processRender(UIComponent.java:144)
at
org.exoplatform.webui.core.UIPortletApplication.processRender(UIPortletApplication.java:146)
at
org.exoplatform.webui.application.portlet.PortletApplication.render(PortletApplication.java:253)
at
org.exoplatform.webui.application.portlet.PortletApplicationController.render(PortletApplicationController.java:110)
at
org.gatein.pc.portlet.impl.jsr168.PortletContainerImpl$Invoker.doFilter(PortletContainerImpl.java:569)
Whole test log is attached in related issue JBEPP-459 for completeness. It is not
occuring in every performance test but only sometimes, so concurreny issue came to my mind
first.
I did more investigation and I founded that the cause of problem is in thread-unsafe call
of method "getUIComponentEventConfig" on class
"org.exoplatform.webui.config.Component".
Problem can be seen if client1 calls this method and eventsMap is null -> eventsMap is
going to initialize during this call.
But when client2 calls this method before initialization of map by client1 is finished,
then problem can happen because eventsMap is not fully initialized for client2 ->
client2 can't find ChangePageNode event -> listener
UIPageActionListener.ChangePageNodeActionListener is not called for client2 -> UIPortal
of client2 has unitialized variables selectedNode and selectedPath ->
NullPointerException is thrown for client2 during rendering of BreadcumbsPortlet, because
UIPortal.selectedPath is null.
Steps to reproduce (with usage of Eclispe IDE):
- Add breakpoint to class org.exoplatform.webui.config.Component to line 184 (after call
of eventMap = new HashMap<String, Event>() )
- Open browser1 and go to localhost:8080/portal/public/classic . Client will be stopped
on breakpoint
- Open browser2 and go to localhost:8080/portal/public/classic . This client is not
seeing ChangePageNode event and so NPE is thrown for him in UIBreadcumbsPortlet.
Note: Method getUIComponentEventConfig is called many times during single HTTP request.
So is it possible to fix this issue by other way that full initialization of this method?
Because it can have bad impact on performance. I wonder if it's possible to
initialize eventsMap in constructor of Component class (only suggestion)
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:16 a.m.
New subject: [JBoss JIRA] Resolved: (GTNPORTAL-1541) Concurreny problem - NullPointerException in BreadcumbsPortlet during performance test
[
https://jira.jboss.org/browse/GTNPORTAL-1541?page=com.atlassian.jira.plug...
]
Minh Hoang TO resolved GTNPORTAL-1541.
--------------------------------------
Resolution: Done
Concurreny problem - NullPointerException in BreadcumbsPortlet during
performance test
--------------------------------------------------------------------------------------
Key: GTNPORTAL-1541
URL: https://jira.jboss.org/browse/GTNPORTAL-1541
Project: GateIn Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: WebUI
Affects Versions: 3.1.0-GA
Environment: GateIn trunk (revision 4282) on EAP5
Reporter: Marek Posolda
Assignee: Minh Hoang TO
Labels: portal-s41, portal-s43, worked
Fix For: 3.2.0-GA
Attachments: .classpath, concurrentReadUnitTest.zip,
GTNPORTAL-1541-01-11-2010.patch, GTNPORTAL-1541-01112010
Original Estimate: 6 hours
Remaining Estimate: 6 hours
Sometimes during performance test, I am seeing NPE exception in server log, thrown from
UIBreadcumbsPortlet. Exception stacktrace is:
2010-10-06 09:11:15,589 ERROR
[org.exoplatform.webui.application.portlet.PortletApplicationController]
(http-127.0.0.1-8080-4) Error while rendering the porlet
java.lang.NullPointerException
at
org.exoplatform.portal.webui.component.UIBreadcumbsPortlet.loadSelectedPath(UIBreadcumbsPortlet.java:69)
at
org.exoplatform.portal.webui.component.UIBreadcumbsPortlet.renderChildren(UIBreadcumbsPortlet.java:89)
at
org.exoplatform.webui.core.lifecycle.UIApplicationLifecycle.processRender(UIApplicationLifecycle.java:73)
at
org.exoplatform.webui.core.lifecycle.UIApplicationLifecycle.processRender(UIApplicationLifecycle.java:31)
at org.exoplatform.webui.core.UIComponent.processRender(UIComponent.java:144)
at
org.exoplatform.webui.core.UIPortletApplication.processRender(UIPortletApplication.java:146)
at
org.exoplatform.webui.application.portlet.PortletApplication.render(PortletApplication.java:253)
at
org.exoplatform.webui.application.portlet.PortletApplicationController.render(PortletApplicationController.java:110)
at
org.gatein.pc.portlet.impl.jsr168.PortletContainerImpl$Invoker.doFilter(PortletContainerImpl.java:569)
Whole test log is attached in related issue JBEPP-459 for completeness. It is not
occuring in every performance test but only sometimes, so concurreny issue came to my mind
first.
I did more investigation and I founded that the cause of problem is in thread-unsafe call
of method "getUIComponentEventConfig" on class
"org.exoplatform.webui.config.Component".
Problem can be seen if client1 calls this method and eventsMap is null -> eventsMap is
going to initialize during this call.
But when client2 calls this method before initialization of map by client1 is finished,
then problem can happen because eventsMap is not fully initialized for client2 ->
client2 can't find ChangePageNode event -> listener
UIPageActionListener.ChangePageNodeActionListener is not called for client2 -> UIPortal
of client2 has unitialized variables selectedNode and selectedPath ->
NullPointerException is thrown for client2 during rendering of BreadcumbsPortlet, because
UIPortal.selectedPath is null.
Steps to reproduce (with usage of Eclispe IDE):
- Add breakpoint to class org.exoplatform.webui.config.Component to line 184 (after call
of eventMap = new HashMap<String, Event>() )
- Open browser1 and go to localhost:8080/portal/public/classic . Client will be stopped
on breakpoint
- Open browser2 and go to localhost:8080/portal/public/classic . This client is not
seeing ChangePageNode event and so NPE is thrown for him in UIBreadcumbsPortlet.
Note: Method getUIComponentEventConfig is called many times during single HTTP request.
So is it possible to fix this issue by other way that full initialization of this method?
Because it can have bad impact on performance. I wonder if it's possible to
initialize eventsMap in constructor of Component class (only suggestion)
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5143
days inactive
5200
days old
19 comments
4 participants
participants (4)
-
Khoi Nguyen (JIRA) -
Marek Posolda (JIRA)
-
Minh Hoang TO (JIRA)
-
Trong Tran (JIRA)