[ https://issues.jboss.org/browse/GTNPORTAL-1823?page=com.atlassian.jira.pl... ] Takayuki Konishi updated GTNPORTAL-1823: ---------------------------------------- Description: Fail to create one page when creating two new pages at the same time. And "Page not found" is shown as a result for the failed page. It seems a timing issue. In plain GateIn, you can reproduce it easily just after start GateIn. WCM have been deployed, you can reploduce it easily at any time. This bug does not depend on user accounts are same or not, nor entry points of pages are same or not. was: Fail to create one page when creating two new pages at the same time. And "Page not found" is shown as a result for the failed page. It seems a timing issue. Steps to Reproduce: 1. start JBossAS 2. access /portal 3. login as root 4. click "Site Editor" - "Add New Page" 5. follow the "Page Creation Wizard" and wait before "Finish" 6. Open another web browser and do the same thing(2-5) except for node name. Please set different node name. 7. Click "Finish" icons on two browsers at the same time. 8. One window shows new node, but the other window shows "page not found" and the node is not created. was: 1. start JBossAS 2. access /portal 3. login as root 4. click "Site Editor" - "Add New Page" 5. follow the "Page Creation Wizard" and wait before "Finish" 6. Open other web browser and do same thing(2-5) except for node name. Please set something other node name. 7. Click "Finish" icons on two browser window at the same time. 8. One window show new node, but another window show "page not found" and the node is not created. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/GTNPORTAL-1823?page=com.atlassian.jira.pl... ] Toshiya Kobayashi commented on GTNPORTAL-1823: ---------------------------------------------- This is a similar issue which is reported in GTNPORTAL-1090 But in this case, we don't access the same resource (2 different pages creation). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/GTNPORTAL-1823?page=com.atlassian.jira.pl... ] Marko Strukelj commented on GTNPORTAL-1823: ------------------------------------------- I took a look, and here's my analysis: When a new page is added to the portal by two conversations in parallel, a concurrency issue ensues, which causes only one page to be added to navigation, even though both pages are created (this is visible in portal’s navigation if logging in with a fresh session). Also, at the end of Add New Page wizard one of the conversations often produces an empty page with an error message: 'This node does not have any pages.'. There is a test case that can be used to reproduce the issue. The test is based on HtmlUnit so it doesn’t require UI + Firefox as Selenium tests do, and is therefore quick to run, and truly cross-platform. Test is available here: http://anonsvn.jboss.org/repos/gatein/portal/trunk/testsuite/htmlunit-tests/ To execute: mvn integration-test -Phtmlunit -Dtest=Test_GTNPORTAL_1823_FailToCreatePage -Dtest.dumpPageOnFail=true (The last parameter is optional - @see WebHelper#initFromProps() for all the options). At the end of Add New Page when Finish button is pressed, action request is performed, which later makes a redirect to newly created page. Even if we serialize all requests (i.e. at servlet filter level via synchronized block) only one child node is added to navigation. That makes me think that the race condition is not a consequence of missing synchronization blocks, but a result of caching the page navigation and performing the update by adding the new node to stale navigation and saving that to storage - thereby overwriting any changes made in between. A different test where a call to Finish has 5 seconds delay between the two conversations while they both start at the same time, reveals that both wizard conversations complete successfully. But each conversation only sees its own page node in the navigation - the second conversation overwrites the first one’s navigation. I suspect that occasional page with error message (condition that the above mentioned test looks for specifically) occurs when the second conversation’s Finish action is performed right after first conversation’s Finish action, but finishes (and overwrites navigation) before first conversation’s redirected newly added page is fully rendered (but has already begun rendering) - meaning that navigation node to which first conversation is redirected disappears in the middle of processing. I suggest someone with intimate knowledge of how navigation works (and should work) looks into this, and provides a proper fix. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/GTNPORTAL-1823?page=com.atlassian.jira.pl... ] Marko Strukelj commented on GTNPORTAL-1823: ------------------------------------------- Ah, I meant to say: Test_GTNPORTAL_1823_FailToCreatePageNavNode test ... -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/GTNPORTAL-1823?page=com.atlassian.jira.pl... ] Toshiya Kobayashi commented on GTNPORTAL-1823: ---------------------------------------------- Each session(= browser) has its own navigation state(UIPortalApplication->UIPortal->PageNavigation instance) and it is persisted by 'Finish' of page-creation-wizard (or other navigation edit). Even if PageNavigation is persisted by one session, the other session doesn't reload the persisted state and keeps rendering its own stale navigation until re-login or opening 'Edit Navigation'. Hence, I may say this issue is not page-creation-wizard conversation wide, but session wide. It seems to be the matter of atomicity design. I uploaded a patch for EPP 5.1.0 which forces reloading just before saving PageNavigation. It passes Test_GTNPORTAL_1823_FailToCreatePageNavNode but not sure if it's a correct fix. Please review it. # I think synchronization is still required to avoid concurrency issues -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/GTNPORTAL-1823?page=com.atlassian.jira.pl... ] Toshiya Kobayashi commented on GTNPORTAL-1823: ---------------------------------------------- just in case, GTNPORTAL-1823_temporary.patch can be applied to gatein trunk as well. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/GTNPORTAL-1823?page=com.atlassian.jira.pl... ] Trong Tran commented on GTNPORTAL-1823: --------------------------------------- I just amended the patch from Toshiya with a small bug fix and attached the new one GTNPORTAL-1823.patch I think we can apply this apply for solving this specific case. To solve completely concurrency issues, it could be done in a different and better way which probably requires a lot of work in WebUI and underlying services as well. (it should be done later) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/GTNPORTAL-1823?page=com.atlassian.jira.pl... ] Toshiya Kobayashi commented on GTNPORTAL-1823: ---------------------------------------------- Thanks Trong, Here is a short summary: - GTNPORTAL-1823.patch solves an atomicity issue in PageNavigation overwriting (Test_GTNPORTAL_1823_FailToCreatePageNavNode) - Attached CreatePageSynchronizationFilter.zip solves a concurrency issue in PageNavigation overwriting (Test_GTNPORTAL_1823_FailToCreatePage). This filter is just a quick workaround hence a proper fix to code base would be required. - Above 2 fixes are focused on page creation but there should be some more atomicity/concurency issues involving other navigation operations. (e.g. 'Save' in 'Edit navigation' may overwrite other's updates). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/GTNPORTAL-1823?page=com.atlassian.jira.pl... ] Trong Tran commented on GTNPORTAL-1823: --------------------------------------- Hi Toshiya, The cache problem in navigation portlet is a known issue recently. I created an other issue GTNPORTAL-1840 for that -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/GTNPORTAL-1823?page=com.atlassian.jira.pl... ] Trong Tran commented on GTNPORTAL-1823: --------------------------------------- you are right, Toshiya. I'm going to fix that :-) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/GTNPORTAL-1823?page=com.atlassian.jira.pl... ] Toshiya Kobayashi updated GTNPORTAL-1823: ----------------------------------------- Attachment: SetCharacterEncodingFilter.zip -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/GTNPORTAL-1823?page=com.atlassian.jira.pl... ] Toshiya Kobayashi commented on GTNPORTAL-1823: ---------------------------------------------- Thanks Trong! My customer and I confirmed the fix works nicely. Could you commit the patch to trunk? And it would be great if you raise a new JIRA for the complete fix -> "To solve completely concurrency issues, it could be done in a different and better way which probably requires a lot of work in WebUI and underlying services as well. (it should be done later)" so that we can close this JIRA for this specific issue. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/GTNPORTAL-1823?page=com.atlassian.jira.pl... ] Work on GTNPORTAL-1823 started by Toshiya Kobayashi. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/GTNPORTAL-1823?page=com.atlassian.jira.pl... ] Toshiya Kobayashi commented on GTNPORTAL-1823: ---------------------------------------------- I've committed GTNPORTAL-1823_1.patch. Now this issue is resolved partially. - The navigation overwriting issue is resolved (Test_GTNPORTAL_1823_FailToCreatePageNavNode) - The cuncurrent access to page creation 'Finish' is not resolved in code base yet but can be worked around by CreatePageSynchronizationFilter/SetCharacterEncodingFilter (Test_GTNPORTAL_1823_FailToCreatePage) - The other cuncurrency issues should be considered maybe in another JIRA I keep this JIRA open for now. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/GTNPORTAL-1823?page=com.atlassian.jira.pl... ] Toshiya Kobayashi commented on GTNPORTAL-1823: ---------------------------------------------- Hi Trong, According to your statement: I'm assigning you again. If you need any help, please let me know. Thanks, -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira