[JBoss JIRA] Created: (GTNPORTAL-1025) Don't show site editor menu when user does not have right to add new page
10:35 p.m.
Don't show site editor menu when user does not have right to add new page
-------------------------------------------------------------------------
Key: GTNPORTAL-1025
URL: https://jira.jboss.org/jira/browse/GTNPORTAL-1025
Project: GateIn Portal
Issue Type: Bug
Security Level: Public (Everyone can see)
Reporter: Hang Nguyen
Fix For: 3.1.0-GA
Steps:
- Create new user with membership is not "Manager"
- Add new page for portal
- Login by root
- Go to edit navigation
- Create new node & select added page for that node
- Login by new user
=> Don't show site menu item ( It must be displayed : Edit page and edit layout of
page).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:37 p.m.
New subject: [JBoss JIRA] Updated: (GTNPORTAL-1025) Don't show site editor menu when user does not have right to add new page
[
https://jira.jboss.org/jira/browse/GTNPORTAL-1025?page=com.atlassian.jira...
]
Hang Nguyen updated GTNPORTAL-1025:
-----------------------------------
Fix Version/s: (was: 3.1.0-GA)
Affects Version/s: 3.0.0-GA
Don't show site editor menu when user does not have right to add
new page
-------------------------------------------------------------------------
Key: GTNPORTAL-1025
URL: https://jira.jboss.org/jira/browse/GTNPORTAL-1025
Project: GateIn Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 3.0.0-GA
Reporter: Hang Nguyen
Steps:
- Create new user with membership is not "Manager"
- Add new page for portal
- Login by root
- Go to edit navigation
- Create new node & select added page for that node
- Login by new user
=> Don't show site menu item ( It must be displayed : Edit page and edit layout of
page).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:39 p.m.
New subject: [JBoss JIRA] Updated: (GTNPORTAL-1025) Don't show site editor menu when user does not have right to add new page
[
https://jira.jboss.org/jira/browse/GTNPORTAL-1025?page=com.atlassian.jira...
]
Minh Hoang TO updated GTNPORTAL-1025:
-------------------------------------
Assignee: Minh Hoang TO
Don't show site editor menu when user does not have right to add
new page
-------------------------------------------------------------------------
Key: GTNPORTAL-1025
URL: https://jira.jboss.org/jira/browse/GTNPORTAL-1025
Project: GateIn Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 3.0.0-GA
Reporter: Hang Nguyen
Assignee: Minh Hoang TO
Steps:
- Create new user with membership is not "Manager"
- Add new page for portal
- Login by root
- Go to edit navigation
- Create new node & select added page for that node
- Login by new user
=> Don't show site menu item ( It must be displayed : Edit page and edit layout of
page).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:46 a.m.
New subject: [JBoss JIRA] Commented: (GTNPORTAL-1025) Don't show site editor menu when user does not have right to add new page
[
https://jira.jboss.org/jira/browse/GTNPORTAL-1025?page=com.atlassian.jira...
]
Trong Tran commented on GTNPORTAL-1025:
---------------------------------------
I'm not sure to understand the step. Please update and provide more information
Don't show site editor menu when user does not have right to add
new page
-------------------------------------------------------------------------
Key: GTNPORTAL-1025
URL: https://jira.jboss.org/jira/browse/GTNPORTAL-1025
Project: GateIn Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 3.0.0-GA
Reporter: Hang Nguyen
Assignee: Minh Hoang TO
Steps:
- Create new user with membership is not "Manager"
- Add new page for portal
- Login by root
- Go to edit navigation
- Create new node & select added page for that node
- Login by new user
=> Don't show site menu item ( It must be displayed : Edit page and edit layout of
page).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:54 a.m.
New subject: [JBoss JIRA] Commented: (GTNPORTAL-1025) Don't show site editor menu when user does not have right to add new page
[
https://jira.jboss.org/jira/browse/GTNPORTAL-1025?page=com.atlassian.jira...
]
Hang Nguyen commented on GTNPORTAL-1025:
----------------------------------------
Steps:
- Create new user with membership is not "Manager" ( platform/administration)
- Add new page for portal ( Manage page)
- Login by root
- Go to Site
- Click edit navigation
- Choose page node and right click
- Create new node & select added page for that node
- Login by new user
- View page created above
=> In Site menu item only show Edit page --> ( It must be displayed : Edit page and
edit layout of page).
Don't show site editor menu when user does not have right to add
new page
-------------------------------------------------------------------------
Key: GTNPORTAL-1025
URL: https://jira.jboss.org/jira/browse/GTNPORTAL-1025
Project: GateIn Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 3.0.0-GA
Reporter: Hang Nguyen
Assignee: Minh Hoang TO
Steps:
- Create new user with membership is not "Manager"
- Add new page for portal
- Login by root
- Go to edit navigation
- Create new node & select added page for that node
- Login by new user
=> Don't show site menu item ( It must be displayed : Edit page and edit layout of
page).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:37 a.m.
New subject: [JBoss JIRA] Updated: (GTNPORTAL-1025) Don't show site editor menu when user does not have right to add new page
[
https://jira.jboss.org/jira/browse/GTNPORTAL-1025?page=com.atlassian.jira...
]
Trong Tran updated GTNPORTAL-1025:
----------------------------------
Fix Version/s: 3.1.0-GA
Original Estimate: 4 hours
Remaining Estimate: 4 hours
Labels: sprint_32 (was: )
Don't show site editor menu when user does not have right to add
new page
-------------------------------------------------------------------------
Key: GTNPORTAL-1025
URL: https://jira.jboss.org/jira/browse/GTNPORTAL-1025
Project: GateIn Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 3.0.0-GA
Reporter: Hang Nguyen
Assignee: Minh Hoang TO
Fix For: 3.1.0-GA
Original Estimate: 4 hours
Remaining Estimate: 4 hours
Steps:
- Create new user with membership is not "Manager"
- Add new page for portal
- Login by root
- Go to edit navigation
- Create new node & select added page for that node
- Login by new user
=> Don't show site menu item ( It must be displayed : Edit page and edit layout of
page).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:28 p.m.
New subject: [JBoss JIRA] Work started: (GTNPORTAL-1025) Don't show site editor menu when user does not have right to add new page
[
https://jira.jboss.org/jira/browse/GTNPORTAL-1025?page=com.atlassian.jira...
]
Work on GTNPORTAL-1025 started by Minh Hoang TO.
Don't show site editor menu when user does not have right to add
new page
-------------------------------------------------------------------------
Key: GTNPORTAL-1025
URL: https://jira.jboss.org/jira/browse/GTNPORTAL-1025
Project: GateIn Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 3.0.0-GA
Reporter: Hang Nguyen
Assignee: Minh Hoang TO
Fix For: 3.1.0-GA
Original Estimate: 4 hours
Remaining Estimate: 4 hours
Steps:
- Create new user with membership is not "Manager"
- Add new page for portal
- Login by root
- Go to edit navigation
- Create new node & select added page for that node
- Login by new user
=> Don't show site menu item ( It must be displayed : Edit page and edit layout of
page).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:14 a.m.
New subject: [JBoss JIRA] Commented: (GTNPORTAL-1025) Don't show site editor menu when user does not have right to add new page
[
https://jira.jboss.org/jira/browse/GTNPORTAL-1025?page=com.atlassian.jira...
]
Minh Hoang TO commented on GTNPORTAL-1025:
------------------------------------------
One thing we need to be clear about the various types of 'edit permissions' on a
site:
1. Layout-related edit permission (typically the Edit Inline), which is checked with the
PortalConfig object
2. Navigation-related edit permission (typically the Add New Page), which is checked with
the PageNavigation object
For a site of type 'group', those two edit permission imply each other, as the
concept of PortalConfig for 'group' site does not really exist
For a site of type 'portal', those ones are not necessarily identical. The
problem here is that we coincide (1) and (2) in numbers of senarios.
Don't show site editor menu when user does not have right to add
new page
-------------------------------------------------------------------------
Key: GTNPORTAL-1025
URL: https://jira.jboss.org/jira/browse/GTNPORTAL-1025
Project: GateIn Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 3.0.0-GA
Reporter: Hang Nguyen
Assignee: Minh Hoang TO
Fix For: 3.1.0-GA
Original Estimate: 4 hours
Remaining Estimate: 4 hours
Steps:
- Create new user with membership is not "Manager"
- Add new page for portal
- Login by root
- Go to edit navigation
- Create new node & select added page for that node
- Login by new user
=> Don't show site menu item ( It must be displayed : Edit page and edit layout of
page).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:30 a.m.
New subject: [JBoss JIRA] Commented: (GTNPORTAL-1025) Don't show site editor menu when user does not have right to add new page
[
https://jira.jboss.org/jira/browse/GTNPORTAL-1025?page=com.atlassian.jira...
]
Minh Hoang TO commented on GTNPORTAL-1025:
------------------------------------------
UserACL userACL = uicomp.getApplicationComponent(UserACL.class);
if (!userACL.hasEditPermission(portalConfig))
{
uiApplication.addMessage(new
ApplicationMessage("UISiteManagement.msg.Invalid-editPermission", null));;
return;
}
Above is the check edit permission i cited from EditNavigationActionListener in
UISiteManagement.java, the permission check MUST BE DONE ON PageNavigation and NOT ON THE
PortalConfig ( which must be used with EditLayoutActionListener)
Let 's see what has been happening:
1. There is not yet a clear and non disputable spec on the stuff ( i refer to a
wiki-page)
2. Testers/new developers run tests on EditLayoutActionListener and think that nothing is
wrong ( which is wrong in fact), then testers/developers base on those test result to
update sniff tests and to write analogous code.
Don't show site editor menu when user does not have right to add
new page
-------------------------------------------------------------------------
Key: GTNPORTAL-1025
URL: https://jira.jboss.org/jira/browse/GTNPORTAL-1025
Project: GateIn Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 3.0.0-GA
Reporter: Hang Nguyen
Assignee: Minh Hoang TO
Fix For: 3.1.0-GA
Original Estimate: 4 hours
Remaining Estimate: 4 hours
Steps:
- Create new user with membership is not "Manager"
- Add new page for portal
- Login by root
- Go to edit navigation
- Create new node & select added page for that node
- Login by new user
=> Don't show site menu item ( It must be displayed : Edit page and edit layout of
page).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:58 a.m.
New subject: [JBoss JIRA] Commented: (GTNPORTAL-1025) Don't show site editor menu when user does not have right to add new page
[
https://jira.jboss.org/jira/browse/GTNPORTAL-1025?page=com.atlassian.jira...
]
Minh Hoang TO commented on GTNPORTAL-1025:
------------------------------------------
I updated the groovy template (UIAdminToolbar.gtmpl) which used to coincide two type of
edit permissions on PageNavigation and on PortalConfig. I did this according to a
temporary agreement ( if i remember well) on 'dynamic admin toolbar' , resulted
from the lack of clear spec
Don't show site editor menu when user does not have right to add
new page
-------------------------------------------------------------------------
Key: GTNPORTAL-1025
URL: https://jira.jboss.org/jira/browse/GTNPORTAL-1025
Project: GateIn Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 3.0.0-GA
Reporter: Hang Nguyen
Assignee: Minh Hoang TO
Fix For: 3.1.0-GA
Original Estimate: 4 hours
Remaining Estimate: 4 hours
Steps:
- Create new user with membership is not "Manager"
- Add new page for portal
- Login by root
- Go to edit navigation
- Create new node & select added page for that node
- Login by new user
=> Don't show site menu item ( It must be displayed : Edit page and edit layout of
page).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:58 a.m.
New subject: [JBoss JIRA] Resolved: (GTNPORTAL-1025) Don't show site editor menu when user does not have right to add new page
[
https://jira.jboss.org/jira/browse/GTNPORTAL-1025?page=com.atlassian.jira...
]
Minh Hoang TO resolved GTNPORTAL-1025.
--------------------------------------
Resolution: Done
Don't show site editor menu when user does not have right to add
new page
-------------------------------------------------------------------------
Key: GTNPORTAL-1025
URL: https://jira.jboss.org/jira/browse/GTNPORTAL-1025
Project: GateIn Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 3.0.0-GA
Reporter: Hang Nguyen
Assignee: Minh Hoang TO
Fix For: 3.1.0-GA
Original Estimate: 4 hours
Remaining Estimate: 4 hours
Steps:
- Create new user with membership is not "Manager"
- Add new page for portal
- Login by root
- Go to edit navigation
- Create new node & select added page for that node
- Login by new user
=> Don't show site menu item ( It must be displayed : Edit page and edit layout of
page).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:05 p.m.
New subject: [JBoss JIRA] Closed: (GTNPORTAL-1025) Don't show site editor menu when user does not have right to add new page
[
https://jira.jboss.org/browse/GTNPORTAL-1025?page=com.atlassian.jira.plug...
]
Hang Nguyen closed GTNPORTAL-1025.
----------------------------------
Don't show site editor menu when user does not have right to add
new page
-------------------------------------------------------------------------
Key: GTNPORTAL-1025
URL: https://jira.jboss.org/browse/GTNPORTAL-1025
Project: GateIn Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 3.0.0-GA
Reporter: Hang Nguyen
Assignee: Minh Hoang TO
Fix For: 3.1.0-CR01
Original Estimate: 4 hours
Remaining Estimate: 4 hours
Steps:
- Create new user with membership is not "Manager"
- Add new page for portal
- Login by root
- Go to edit navigation
- Create new node & select added page for that node
- Login by new user
=> Don't show site menu item ( It must be displayed : Edit page and edit layout of
page).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5155
days inactive
5204
days old
11 comments
3 participants
participants (3)
-
Hang Nguyen (JIRA) -
Minh Hoang TO (JIRA)
-
Trong Tran (JIRA)