[ https://jira.jboss.org/jira/browse/GTNPORTAL-511?page=com.atlassian.jira.... ] jerem j updated GTNPORTAL-511: ------------------------------ Summary: userPref of gadgets are not sometime not saved correctly (was: userPref of gadgets are not saved anymore) Description: Every call to gadgets.Prefs.set generate a call to save the data in the backend (an action in the dashboard portlet). To save we send all the set of preferences. The jira gadget call this API multiple times in a very short time. So there is multiple ajax request sent to the backend but not in a precise order. So it might happen that the first request arrive the last one, and so old preferences are saved. ref: http://code.google.com/apis/gadgets/docs/reference/#gadgets.Prefs.set http://jira4j.exoplatform.org/rest/gadgets/1.0/g/com.atlassian.jira.gadge... I'm going to do some more research to know how to fix this. was: The users preferences of the gadgets are not saved anymore. The following url is called in Ajax, but an html page is returned : http://localhost:8080/portal/private/classic/Tab_0?portal:componentId=27e... After reloading the page, the preferences are lost. You can try with http://jira4j.exoplatform.org/rest/gadgets/1.0/g/com.atlassian.jira.gadge... The URL to call is generated in ExoBasedUserPrefStore.js. There is probably something wrong there. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/GTNPORTAL-511?page=com.atlassian.jira.... ] jerem j updated GTNPORTAL-511: ------------------------------ Original Estimate: 3 days (was: 2 days) Remaining Estimate: 3 days (was: 2 days) Description: Every call to gadgets.Prefs.set generate a call to save the data in the backend (an action in the dashboard portlet). To save we send all the set of preferences. The jira gadget call this API multiple times in a very short time. So there is multiple ajax request sent to the backend but not in a precise order. So it might happen that the first request arrive the last one, and so old preferences are saved. To fix: In the file Gadgets.js, function "gadgets.IfrGadgetService.prototype.setUserPref", prefs is updated with all the name/value, and ALL the prefs object is saved. Instead of saving all the preferences, we should only save the updated preferences. In org.exoplatform.portal.pom.spi.gadget.Gadget it will be needed to be able to add preference by name, something like : public void setUserPref(String name, String value) code : Gadgets.js: http://fisheye.exoplatform.org/browse/projects/portal/trunk/web/eXoResour... ExoBasedUserPrefStore.js: http://fisheye.exoplatform.org/browse/projects/portal/trunk/web/eXoResour... links: API doc about adgets.Prefs.set: http://code.google.com/apis/gadgets/docs/reference/#gadgets.Prefs.set Jira gadget to test: http://jira4j.exoplatform.org/rest/gadgets/1.0/g/com.atlassian.jira.gadge... was: Every call to gadgets.Prefs.set generate a call to save the data in the backend (an action in the dashboard portlet). To save we send all the set of preferences. The jira gadget call this API multiple times in a very short time. So there is multiple ajax request sent to the backend but not in a precise order. So it might happen that the first request arrive the last one, and so old preferences are saved. To fix: In the file Gadgets.js, function "gadgets.IfrGadgetService.prototype.setUserPref", prefs is updated with all the name/value, and ALL the prefs object is saved. Instead of saving all the preferences, we should only save the updated preferences. code : Gadgets.js: http://fisheye.exoplatform.org/browse/projects/portal/trunk/web/eXoResour... ExoBasedUserPrefStore.js: http://fisheye.exoplatform.org/browse/projects/portal/trunk/web/eXoResour... links: API doc about adgets.Prefs.set: http://code.google.com/apis/gadgets/docs/reference/#gadgets.Prefs.set Jira gadget to test: http://jira4j.exoplatform.org/rest/gadgets/1.0/g/com.atlassian.jira.gadge... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/GTNPORTAL-511?page=com.atlassian.jira.... ] Julien Viet reassigned GTNPORTAL-511: ------------------------------------- Assignee: Julien Viet -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/GTNPORTAL-511?page=com.atlassian.jira.... ] jerem j commented on GTNPORTAL-511: ----------------------------------- I'm now getting an error from the JCR (see stacktrace.txt in attachment). If I put back the synchronized, it's working, but as you said, it might not be the most efficient solution. Do you have another idea? Would it be possible to block only 1 gadgets for 1 user (instead of all of them for all user) when writing properties? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/GTNPORTAL-511?page=com.atlassian.jira.... ] Julien Viet commented on GTNPORTAL-511: --------------------------------------- it looks like a severe JCR error. I suspect it is because of concurrency issue in JCR but I am not sure. I will spend some time to reproduce it in a unit test in order to work on an appropriate fix. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/GTNPORTAL-511?page=com.atlassian.jira.... ] Thomas Heute updated GTNPORTAL-511: ----------------------------------- Fix Version/s: 4.0.0 (was: 3.2.0-GA) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira