9:53 p.m.
kien nguyen created GTNPORTAL-2373:
--------------------------------------
Summary: groovy template should not print "null" string when
variable is null
Key: GTNPORTAL-2373
URL: https://issues.jboss.org/browse/GTNPORTAL-2373
Project: GateIn Portal
Issue Type: Enhancement
Security Level: Public (Everyone can see)
Reporter: kien nguyen
Priority: Minor
Fix For: 3.3.0.Final
In .gtmpl file, I use: <input class="key" type="text"
name="key" value="${key}"/>
And if "key" variable is null, I will get "null" string in input like:
<input type="text" name="key" value="null">
I think it should not be, we should print nothing when variable is null, for example:
<input type="text" name="key" value>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:41 a.m.
[
https://issues.jboss.org/browse/GTNPORTAL-2373?page=com.atlassian.jira.pl...
]
kien nguyen updated GTNPORTAL-2373:
-----------------------------------
Attachment: GTNPORTAL-2373.patch
groovy template should not print "null" string when
variable is null
--------------------------------------------------------------------
Key: GTNPORTAL-2373
URL: https://issues.jboss.org/browse/GTNPORTAL-2373
Project: GateIn Portal
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Reporter: kien nguyen
Priority: Minor
Fix For: 3.3.0.Final
Attachments: GTNPORTAL-2373.patch
In .gtmpl file, I use: <input class="key" type="text"
name="key" value="${key}"/>
And if "key" variable is null, I will get "null" string in input
like: <input type="text" name="key" value="null">
I think it should not be, we should print nothing when variable is null, for example:
<input type="text" name="key" value>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:13 a.m.
[
https://issues.jboss.org/browse/GTNPORTAL-2373?page=com.atlassian.jira.pl...
]
RH Bugzilla Integration updated GTNPORTAL-2373:
-----------------------------------------------
Bugzilla Update: Perform
groovy template should not print "null" string when
variable is null
--------------------------------------------------------------------
Key: GTNPORTAL-2373
URL: https://issues.jboss.org/browse/GTNPORTAL-2373
Project: GateIn Portal
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Reporter: kien nguyen
Priority: Minor
Fix For: 3.3.0.Final
Attachments: GTNPORTAL-2373.patch
In .gtmpl file, I use: <input class="key" type="text"
name="key" value="${key}"/>
And if "key" variable is null, I will get "null" string in input
like: <input type="text" name="key" value="null">
I think it should not be, we should print nothing when variable is null, for example:
<input type="text" name="key" value>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:13 a.m.
[
https://issues.jboss.org/browse/GTNPORTAL-2373?page=com.atlassian.jira.pl...
]
RH Bugzilla Integration updated GTNPORTAL-2373:
-----------------------------------------------
Bugzilla References: https://bugzilla.redhat.com/show_bug.cgi?id=824863
groovy template should not print "null" string when
variable is null
--------------------------------------------------------------------
Key: GTNPORTAL-2373
URL: https://issues.jboss.org/browse/GTNPORTAL-2373
Project: GateIn Portal
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Reporter: kien nguyen
Priority: Minor
Fix For: 3.3.0.Final
Attachments: GTNPORTAL-2373.patch
In .gtmpl file, I use: <input class="key" type="text"
name="key" value="${key}"/>
And if "key" variable is null, I will get "null" string in input
like: <input type="text" name="key" value="null">
I think it should not be, we should print nothing when variable is null, for example:
<input type="text" name="key" value>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:06 a.m.
[
https://issues.jboss.org/browse/GTNPORTAL-2373?page=com.atlassian.jira.pl...
]
RH Bugzilla Integration commented on GTNPORTAL-2373:
----------------------------------------------------
Honza Fnukal <hfnukal(a)redhat.com> made a comment on [bug
824863|https://bugzilla.redhat.com/show_bug.cgi?id=824863]
In .gtmpl file, I use: <input class="key" type="text"
name="key" value="${key}"/>
And if "key" variable is null, I will get "null" string in input like:
<input type="text" name="key" value="null">
I think it should not be, we should print nothing when variable is null, for example:
<input type="text" name="key" value>
groovy template should not print "null" string when
variable is null
--------------------------------------------------------------------
Key: GTNPORTAL-2373
URL: https://issues.jboss.org/browse/GTNPORTAL-2373
Project: GateIn Portal
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Reporter: kien nguyen
Priority: Minor
Fix For: 3.3.0.Final
Attachments: GTNPORTAL-2373.patch
In .gtmpl file, I use: <input class="key" type="text"
name="key" value="${key}"/>
And if "key" variable is null, I will get "null" string in input
like: <input type="text" name="key" value="null">
I think it should not be, we should print nothing when variable is null, for example:
<input type="text" name="key" value>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:06 a.m.
[
https://issues.jboss.org/browse/GTNPORTAL-2373?page=com.atlassian.jira.pl...
]
RH Bugzilla Integration commented on GTNPORTAL-2373:
----------------------------------------------------
Honza Fnukal <hfnukal(a)redhat.com> changed the Status of [bug
824863|https://bugzilla.redhat.com/show_bug.cgi?id=824863] from ASSIGNED to ON_QA
groovy template should not print "null" string when
variable is null
--------------------------------------------------------------------
Key: GTNPORTAL-2373
URL: https://issues.jboss.org/browse/GTNPORTAL-2373
Project: GateIn Portal
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Reporter: kien nguyen
Priority: Minor
Fix For: 3.3.0.Final
Attachments: GTNPORTAL-2373.patch
In .gtmpl file, I use: <input class="key" type="text"
name="key" value="${key}"/>
And if "key" variable is null, I will get "null" string in input
like: <input type="text" name="key" value="null">
I think it should not be, we should print nothing when variable is null, for example:
<input type="text" name="key" value>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:06 a.m.
[
https://issues.jboss.org/browse/GTNPORTAL-2373?page=com.atlassian.jira.pl...
]
RH Bugzilla Integration commented on GTNPORTAL-2373:
----------------------------------------------------
Honza Fnukal <hfnukal(a)redhat.com> changed the Status of [bug
824863|https://bugzilla.redhat.com/show_bug.cgi?id=824863] from NEW to ASSIGNED
groovy template should not print "null" string when
variable is null
--------------------------------------------------------------------
Key: GTNPORTAL-2373
URL: https://issues.jboss.org/browse/GTNPORTAL-2373
Project: GateIn Portal
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Reporter: kien nguyen
Priority: Minor
Fix For: 3.3.0.Final
Attachments: GTNPORTAL-2373.patch
In .gtmpl file, I use: <input class="key" type="text"
name="key" value="${key}"/>
And if "key" variable is null, I will get "null" string in input
like: <input type="text" name="key" value="null">
I think it should not be, we should print nothing when variable is null, for example:
<input type="text" name="key" value>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:57 a.m.
[
https://issues.jboss.org/browse/GTNPORTAL-2373?page=com.atlassian.jira.pl...
]
Thomas Heute updated GTNPORTAL-2373:
------------------------------------
Fix Version/s: 3.4.0.Final
(was: 3.3.0.Final)
groovy template should not print "null" string when
variable is null
--------------------------------------------------------------------
Key: GTNPORTAL-2373
URL: https://issues.jboss.org/browse/GTNPORTAL-2373
Project: GateIn Portal
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Reporter: kien nguyen
Priority: Minor
Fix For: 3.4.0.Final
Attachments: GTNPORTAL-2373.patch
In .gtmpl file, I use: <input class="key" type="text"
name="key" value="${key}"/>
And if "key" variable is null, I will get "null" string in input
like: <input type="text" name="key" value="null">
I think it should not be, we should print nothing when variable is null, for example:
<input type="text" name="key" value>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:36 a.m.
[
https://issues.jboss.org/browse/GTNPORTAL-2373?page=com.atlassian.jira.pl...
]
RH Bugzilla Integration commented on GTNPORTAL-2373:
----------------------------------------------------
Honza Fnukal <hfnukal(a)redhat.com> made a comment on [bug
824863|https://bugzilla.redhat.com/show_bug.cgi?id=824863]
Technical note added. If any revisions are required, please edit the "Technical
Notes" field
accordingly. All revisions will be proofread by the Engineering Content Services
team.
New Contents:
C: GTMPL template prints null, when key was not definned
C: Non valid string shown on page
R: Use empty string
F: Returning empty string instead of null.
groovy template should not print "null" string when
variable is null
--------------------------------------------------------------------
Key: GTNPORTAL-2373
URL: https://issues.jboss.org/browse/GTNPORTAL-2373
Project: GateIn Portal
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Reporter: kien nguyen
Priority: Minor
Fix For: 3.4.0.Final
Attachments: GTNPORTAL-2373.patch
In .gtmpl file, I use: <input class="key" type="text"
name="key" value="${key}"/>
And if "key" variable is null, I will get "null" string in input
like: <input type="text" name="key" value="null">
I think it should not be, we should print nothing when variable is null, for example:
<input type="text" name="key" value>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 a.m.
[
https://issues.jboss.org/browse/GTNPORTAL-2373?page=com.atlassian.jira.pl...
]
RH Bugzilla Integration commented on GTNPORTAL-2373:
----------------------------------------------------
Viliam Rockai <vrockai(a)redhat.com> made a comment on [bug
824863|https://bugzilla.redhat.com/show_bug.cgi?id=824863]
xercesImpl-2.9.1-patch-01.jar are now used. any ideas how to check if this version has the
right patch in it?
groovy template should not print "null" string when
variable is null
--------------------------------------------------------------------
Key: GTNPORTAL-2373
URL: https://issues.jboss.org/browse/GTNPORTAL-2373
Project: GateIn Portal
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Reporter: kien nguyen
Priority: Minor
Fix For: 3.4.0.Final
Attachments: GTNPORTAL-2373.patch
In .gtmpl file, I use: <input class="key" type="text"
name="key" value="${key}"/>
And if "key" variable is null, I will get "null" string in input
like: <input type="text" name="key" value="null">
I think it should not be, we should print nothing when variable is null, for example:
<input type="text" name="key" value>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:46 a.m.
[
https://issues.jboss.org/browse/GTNPORTAL-2373?page=com.atlassian.jira.pl...
]
Boleslaw Dawidowicz commented on GTNPORTAL-2373:
------------------------------------------------
Kien is the patch commited in gatein? Could you confirm and resolve?
groovy template should not print "null" string when
variable is null
--------------------------------------------------------------------
Key: GTNPORTAL-2373
URL: https://issues.jboss.org/browse/GTNPORTAL-2373
Project: GateIn Portal
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Reporter: kien nguyen
Priority: Minor
Fix For: 3.4.0.Final
Attachments: GTNPORTAL-2373.patch
In .gtmpl file, I use: <input class="key" type="text"
name="key" value="${key}"/>
And if "key" variable is null, I will get "null" string in input
like: <input type="text" name="key" value="null">
I think it should not be, we should print nothing when variable is null, for example:
<input type="text" name="key" value>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:57 a.m.
[
https://issues.jboss.org/browse/GTNPORTAL-2373?page=com.atlassian.jira.pl...
]
RH Bugzilla Integration commented on GTNPORTAL-2373:
----------------------------------------------------
Trang Vu <trangvh(a)exoplatform.com> made a comment on [bug
824863|https://bugzilla.redhat.com/show_bug.cgi?id=824863]
There is a side effect on EPP-SP 5.2.2-ER02, see
https://jira.exoplatform.org/browse/SPUB-191 for the detail.
groovy template should not print "null" string when
variable is null
--------------------------------------------------------------------
Key: GTNPORTAL-2373
URL: https://issues.jboss.org/browse/GTNPORTAL-2373
Project: GateIn Portal
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Reporter: kien nguyen
Priority: Minor
Fix For: 3.4.0.Final
Attachments: GTNPORTAL-2373.patch
In .gtmpl file, I use: <input class="key" type="text"
name="key" value="${key}"/>
And if "key" variable is null, I will get "null" string in input
like: <input type="text" name="key" value="null">
I think it should not be, we should print nothing when variable is null, for example:
<input type="text" name="key" value>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:48 a.m.
[
https://issues.jboss.org/browse/GTNPORTAL-2373?page=com.atlassian.jira.pl...
]
RH Bugzilla Integration commented on GTNPORTAL-2373:
----------------------------------------------------
Michal Vanco <mvanco(a)redhat.com> made a comment on [bug
824863|https://bugzilla.redhat.com/show_bug.cgi?id=824863]
Needs be updated based on https://jira.exoplatform.org/browse/SPUB-191
groovy template should not print "null" string when
variable is null
--------------------------------------------------------------------
Key: GTNPORTAL-2373
URL: https://issues.jboss.org/browse/GTNPORTAL-2373
Project: GateIn Portal
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Reporter: kien nguyen
Priority: Minor
Fix For: 3.4.0.Final
Attachments: GTNPORTAL-2373.patch
In .gtmpl file, I use: <input class="key" type="text"
name="key" value="${key}"/>
And if "key" variable is null, I will get "null" string in input
like: <input type="text" name="key" value="null">
I think it should not be, we should print nothing when variable is null, for example:
<input type="text" name="key" value>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:48 a.m.
[
https://issues.jboss.org/browse/GTNPORTAL-2373?page=com.atlassian.jira.pl...
]
RH Bugzilla Integration commented on GTNPORTAL-2373:
----------------------------------------------------
Michal Vanco <mvanco(a)redhat.com> changed the Status of [bug
824863|https://bugzilla.redhat.com/show_bug.cgi?id=824863] from ON_QA to ASSIGNED
groovy template should not print "null" string when
variable is null
--------------------------------------------------------------------
Key: GTNPORTAL-2373
URL: https://issues.jboss.org/browse/GTNPORTAL-2373
Project: GateIn Portal
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Reporter: kien nguyen
Priority: Minor
Fix For: 3.4.0.Final
Attachments: GTNPORTAL-2373.patch
In .gtmpl file, I use: <input class="key" type="text"
name="key" value="${key}"/>
And if "key" variable is null, I will get "null" string in input
like: <input type="text" name="key" value="null">
I think it should not be, we should print nothing when variable is null, for example:
<input type="text" name="key" value>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:03 a.m.
[
https://issues.jboss.org/browse/GTNPORTAL-2373?page=com.atlassian.jira.pl...
]
RH Bugzilla Integration commented on GTNPORTAL-2373:
----------------------------------------------------
Honza Fnukal <hfnukal(a)redhat.com> made a comment on [bug
824863|https://bugzilla.redhat.com/show_bug.cgi?id=824863]
Updated Signin.xml in branding script.
groovy template should not print "null" string when
variable is null
--------------------------------------------------------------------
Key: GTNPORTAL-2373
URL: https://issues.jboss.org/browse/GTNPORTAL-2373
Project: GateIn Portal
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Reporter: kien nguyen
Priority: Minor
Fix For: 3.4.0.Final
Attachments: GTNPORTAL-2373.patch
In .gtmpl file, I use: <input class="key" type="text"
name="key" value="${key}"/>
And if "key" variable is null, I will get "null" string in input
like: <input type="text" name="key" value="null">
I think it should not be, we should print nothing when variable is null, for example:
<input type="text" name="key" value>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:03 a.m.
[
https://issues.jboss.org/browse/GTNPORTAL-2373?page=com.atlassian.jira.pl...
]
RH Bugzilla Integration commented on GTNPORTAL-2373:
----------------------------------------------------
Honza Fnukal <hfnukal(a)redhat.com> changed the Status of [bug
824863|https://bugzilla.redhat.com/show_bug.cgi?id=824863] from ASSIGNED to ON_QA
groovy template should not print "null" string when
variable is null
--------------------------------------------------------------------
Key: GTNPORTAL-2373
URL: https://issues.jboss.org/browse/GTNPORTAL-2373
Project: GateIn Portal
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Reporter: kien nguyen
Priority: Minor
Fix For: 3.4.0.Final
Attachments: GTNPORTAL-2373.patch
In .gtmpl file, I use: <input class="key" type="text"
name="key" value="${key}"/>
And if "key" variable is null, I will get "null" string in input
like: <input type="text" name="key" value="null">
I think it should not be, we should print nothing when variable is null, for example:
<input type="text" name="key" value>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:02 p.m.
[
https://issues.jboss.org/browse/GTNPORTAL-2373?page=com.atlassian.jira.pl...
]
kien nguyen commented on GTNPORTAL-2373:
----------------------------------------
@Trang Vu: how to verify side effect of https://jira.exoplatform.org/browse/SPUB-191
because the patch has not yet commited on gatein?
groovy template should not print "null" string when
variable is null
--------------------------------------------------------------------
Key: GTNPORTAL-2373
URL: https://issues.jboss.org/browse/GTNPORTAL-2373
Project: GateIn Portal
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Reporter: kien nguyen
Priority: Minor
Fix For: 3.4.0.Final
Attachments: GTNPORTAL-2373.patch
In .gtmpl file, I use: <input class="key" type="text"
name="key" value="${key}"/>
And if "key" variable is null, I will get "null" string in input
like: <input type="text" name="key" value="null">
I think it should not be, we should print nothing when variable is null, for example:
<input type="text" name="key" value>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:57 p.m.
[
https://issues.jboss.org/browse/GTNPORTAL-2373?page=com.atlassian.jira.pl...
]
kien nguyen commented on GTNPORTAL-2373:
----------------------------------------
It seems to the patch had committed on EPP. And now, Groovy engine will render
"" instead of "null", so side effect will occur if your javascript is
only processing by based on "null" value
groovy template should not print "null" string when
variable is null
--------------------------------------------------------------------
Key: GTNPORTAL-2373
URL: https://issues.jboss.org/browse/GTNPORTAL-2373
Project: GateIn Portal
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Reporter: kien nguyen
Priority: Minor
Fix For: 3.4.0.Final
Attachments: GTNPORTAL-2373.patch
In .gtmpl file, I use: <input class="key" type="text"
name="key" value="${key}"/>
And if "key" variable is null, I will get "null" string in input
like: <input type="text" name="key" value="null">
I think it should not be, we should print nothing when variable is null, for example:
<input type="text" name="key" value>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:04 a.m.
[
https://issues.jboss.org/browse/GTNPORTAL-2373?page=com.atlassian.jira.pl...
]
RH Bugzilla Integration commented on GTNPORTAL-2373:
----------------------------------------------------
Trang Vu <trangvh(a)exoplatform.com> made a comment on [bug
824863|https://bugzilla.redhat.com/show_bug.cgi?id=824863]
Customers whose sites are based on ACME portal template will have to update their
Signin.xml manually. We should revert the commit 8713 to avoid such kind of impact.
groovy template should not print "null" string when
variable is null
--------------------------------------------------------------------
Key: GTNPORTAL-2373
URL: https://issues.jboss.org/browse/GTNPORTAL-2373
Project: GateIn Portal
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Reporter: kien nguyen
Priority: Minor
Fix For: 3.4.0.Final
Attachments: GTNPORTAL-2373.patch
In .gtmpl file, I use: <input class="key" type="text"
name="key" value="${key}"/>
And if "key" variable is null, I will get "null" string in input
like: <input type="text" name="key" value="null">
I think it should not be, we should print nothing when variable is null, for example:
<input type="text" name="key" value>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:30 p.m.
[
https://issues.jboss.org/browse/GTNPORTAL-2373?page=com.atlassian.jira.pl...
]
RH Bugzilla Integration commented on GTNPORTAL-2373:
----------------------------------------------------
Jared MORGAN <jmorgan(a)redhat.com> made a comment on [bug
824863|https://bugzilla.redhat.com/show_bug.cgi?id=824863]
Technical note updated. If any revisions are required, please edit the "Technical
Notes" field
accordingly. All revisions will be proofread by the Engineering Content Services
team.
Diffed Contents:
@@ -1,4 +1 @@
-C: GTMPL template prints null, when key was not definned
+If a GateIn Template file (*.gtmpl) contained an <input> directive that declared a
variable as a value, and that variable resolved to null, the word "null" would
be substituted for the value instead of the value parameter being present, but undefined.
For example, <input class="key" type="text"
name="key" value="${key}"/> resolved to <input
class="key" type="text" name="key"
value="null"/>, instead of <input class="key"
type="text" name="key" value/>. The fix corrects the way null
values are handled, and now prints undefined parameters, instead of printing null as the
parameter value.-C: Non valid string shown on page
-R: Use empty string
-F: Returning empty string instead of null.
groovy template should not print "null" string when
variable is null
--------------------------------------------------------------------
Key: GTNPORTAL-2373
URL: https://issues.jboss.org/browse/GTNPORTAL-2373
Project: GateIn Portal
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Reporter: kien nguyen
Priority: Minor
Fix For: 3.4.0.Final
Attachments: GTNPORTAL-2373.patch
In .gtmpl file, I use: <input class="key" type="text"
name="key" value="${key}"/>
And if "key" variable is null, I will get "null" string in input
like: <input type="text" name="key" value="null">
I think it should not be, we should print nothing when variable is null, for example:
<input type="text" name="key" value>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:20 a.m.
[
https://issues.jboss.org/browse/GTNPORTAL-2373?page=com.atlassian.jira.pl...
]
RH Bugzilla Integration commented on GTNPORTAL-2373:
----------------------------------------------------
Jared MORGAN <jmorgan(a)redhat.com> made a comment on [bug
824863|https://bugzilla.redhat.com/show_bug.cgi?id=824863]
Technical note updated. If any revisions are required, please edit the "Technical
Notes" field
accordingly. All revisions will be proofread by the Engineering Content Services
team.
Diffed Contents:
@@ -1 +1 @@
-If a GateIn Template file (*.gtmpl) contained an <input> directive that declared a
variable as a value, and that variable resolved to null, the word "null" would
be substituted for the value instead of the value parameter being present, but undefined.
For example, <input class="key" type="text"
name="key" value="${key}"/> resolved to <input
class="key" type="text" name="key"
value="null"/>, instead of <input class="key"
type="text" name="key" value/>. The fix corrects the way null
values are handled, and now prints undefined parameters, instead of printing null as the
parameter value.+If a GateIn Template file (*.gtmpl) contained an <input>
directive that declared a variable as a value, and that variable resolved to null, the
word "null" would be substituted for the value instead of the value parameter
being present, but undefined. For example, <input class="key"
type="text" name="key" value="${key}"/> resolved to
<input class="key" type="text" name="key"
value="null"/>, instead of <input class="key"
type="text" name="key" value/>. The fix corrects the way null
values are handled, and now prints undefined parameters, instead of printing null as the
parameter value.
groovy template should not print "null" string when
variable is null
--------------------------------------------------------------------
Key: GTNPORTAL-2373
URL: https://issues.jboss.org/browse/GTNPORTAL-2373
Project: GateIn Portal
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Reporter: kien nguyen
Priority: Minor
Fix For: 3.4.0.Final
Attachments: GTNPORTAL-2373.patch
In .gtmpl file, I use: <input class="key" type="text"
name="key" value="${key}"/>
And if "key" variable is null, I will get "null" string in input
like: <input type="text" name="key" value="null">
I think it should not be, we should print nothing when variable is null, for example:
<input type="text" name="key" value>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:05 a.m.
[
https://issues.jboss.org/browse/GTNPORTAL-2373?page=com.atlassian.jira.pl...
]
RH Bugzilla Integration commented on GTNPORTAL-2373:
----------------------------------------------------
Michal Vanco <mvanco(a)redhat.com> changed the Status of [bug
824863|https://bugzilla.redhat.com/show_bug.cgi?id=824863] from ON_QA to VERIFIED
groovy template should not print "null" string when
variable is null
--------------------------------------------------------------------
Key: GTNPORTAL-2373
URL: https://issues.jboss.org/browse/GTNPORTAL-2373
Project: GateIn Portal
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Reporter: kien nguyen
Priority: Minor
Fix For: 3.4.0.Final
Attachments: GTNPORTAL-2373.patch
In .gtmpl file, I use: <input class="key" type="text"
name="key" value="${key}"/>
And if "key" variable is null, I will get "null" string in input
like: <input type="text" name="key" value="null">
I think it should not be, we should print nothing when variable is null, for example:
<input type="text" name="key" value>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:21 p.m.
[
https://issues.jboss.org/browse/GTNPORTAL-2373?page=com.atlassian.jira.pl...
]
kien nguyen commented on GTNPORTAL-2373:
----------------------------------------
Some side effect of https://jira.exoplatform.org/browse/SPUB-191 are resolved and patch
was committed in EPP. The patch need to be committed in GateIn
groovy template should not print "null" string when
variable is null
--------------------------------------------------------------------
Key: GTNPORTAL-2373
URL: https://issues.jboss.org/browse/GTNPORTAL-2373
Project: GateIn Portal
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Reporter: kien nguyen
Priority: Minor
Fix For: 3.4.0.Final
Attachments: GTNPORTAL-2373.patch
In .gtmpl file, I use: <input class="key" type="text"
name="key" value="${key}"/>
And if "key" variable is null, I will get "null" string in input
like: <input type="text" name="key" value="null">
I think it should not be, we should print nothing when variable is null, for example:
<input type="text" name="key" value>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:26 p.m.
[
https://issues.jboss.org/browse/GTNPORTAL-2373?page=com.atlassian.jira.pl...
]
Trong Tran updated GTNPORTAL-2373:
----------------------------------
Labels: portal-s68 (was: )
groovy template should not print "null" string when
variable is null
--------------------------------------------------------------------
Key: GTNPORTAL-2373
URL: https://issues.jboss.org/browse/GTNPORTAL-2373
Project: GateIn Portal
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Reporter: kien nguyen
Priority: Minor
Labels: portal-s68
Fix For: 3.4.0.Final
Attachments: GTNPORTAL-2373.patch
In .gtmpl file, I use: <input class="key" type="text"
name="key" value="${key}"/>
And if "key" variable is null, I will get "null" string in input
like: <input type="text" name="key" value="null">
I think it should not be, we should print nothing when variable is null, for example:
<input type="text" name="key" value>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:08 a.m.
[
https://issues.jboss.org/browse/GTNPORTAL-2373?page=com.atlassian.jira.pl...
]
Vu Viet Phuong updated GTNPORTAL-2373:
--------------------------------------
Original Estimate: 2 hours
Remaining Estimate: 2 hours
Bugzilla References: https://bugzilla.redhat.com/show_bug.cgi?id=824863 (was:
https://bugzilla.redhat.com/show_bug.cgi?id=824863)
Backport from https://bugzilla.redhat.com/show_bug.cgi?id=824863
groovy template should not print "null" string when
variable is null
--------------------------------------------------------------------
Key: GTNPORTAL-2373
URL: https://issues.jboss.org/browse/GTNPORTAL-2373
Project: GateIn Portal
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Reporter: kien nguyen
Priority: Minor
Labels: portal-s68
Fix For: 3.4.0.Final
Attachments: GTNPORTAL-2373.patch
Original Estimate: 2 hours
Remaining Estimate: 2 hours
In .gtmpl file, I use: <input class="key" type="text"
name="key" value="${key}"/>
And if "key" variable is null, I will get "null" string in input
like: <input type="text" name="key" value="null">
I think it should not be, we should print nothing when variable is null, for example:
<input type="text" name="key" value>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:18 p.m.
[
https://issues.jboss.org/browse/GTNPORTAL-2373?page=com.atlassian.jira.pl...
]
kien nguyen reassigned GTNPORTAL-2373:
--------------------------------------
Assignee: kien nguyen
groovy template should not print "null" string when
variable is null
--------------------------------------------------------------------
Key: GTNPORTAL-2373
URL: https://issues.jboss.org/browse/GTNPORTAL-2373
Project: GateIn Portal
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Reporter: kien nguyen
Assignee: kien nguyen
Priority: Minor
Labels: portal-s68
Fix For: 3.4.0.Final
Attachments: GTNPORTAL-2373.patch
Original Estimate: 2 hours
Remaining Estimate: 2 hours
In .gtmpl file, I use: <input class="key" type="text"
name="key" value="${key}"/>
And if "key" variable is null, I will get "null" string in input
like: <input type="text" name="key" value="null">
I think it should not be, we should print nothing when variable is null, for example:
<input type="text" name="key" value>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:18 p.m.
[
https://issues.jboss.org/browse/GTNPORTAL-2373?page=com.atlassian.jira.pl...
]
kien nguyen updated GTNPORTAL-2373:
-----------------------------------
Labels: portal-s68 worked (was: portal-s68)
groovy template should not print "null" string when
variable is null
--------------------------------------------------------------------
Key: GTNPORTAL-2373
URL: https://issues.jboss.org/browse/GTNPORTAL-2373
Project: GateIn Portal
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Reporter: kien nguyen
Assignee: kien nguyen
Priority: Minor
Labels: portal-s68, worked
Fix For: 3.4.0.Final
Attachments: GTNPORTAL-2373.patch
Original Estimate: 2 hours
Remaining Estimate: 2 hours
In .gtmpl file, I use: <input class="key" type="text"
name="key" value="${key}"/>
And if "key" variable is null, I will get "null" string in input
like: <input type="text" name="key" value="null">
I think it should not be, we should print nothing when variable is null, for example:
<input type="text" name="key" value>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:56 a.m.
[
https://issues.jboss.org/browse/GTNPORTAL-2373?page=com.atlassian.jira.pl...
]
kien nguyen updated GTNPORTAL-2373:
-----------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/gatein/gatein-portal/pull/119
groovy template should not print "null" string when
variable is null
--------------------------------------------------------------------
Key: GTNPORTAL-2373
URL: https://issues.jboss.org/browse/GTNPORTAL-2373
Project: GateIn Portal
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Reporter: kien nguyen
Assignee: kien nguyen
Priority: Minor
Labels: portal-s68, worked
Fix For: 3.4.0.Final
Attachments: GTNPORTAL-2373.patch
Original Estimate: 2 hours
Remaining Estimate: 2 hours
In .gtmpl file, I use: <input class="key" type="text"
name="key" value="${key}"/>
And if "key" variable is null, I will get "null" string in input
like: <input type="text" name="key" value="null">
I think it should not be, we should print nothing when variable is null, for example:
<input type="text" name="key" value>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:45 p.m.
[
https://issues.jboss.org/browse/GTNPORTAL-2373?page=com.atlassian.jira.pl...
]
Boleslaw Dawidowicz updated GTNPORTAL-2373:
-------------------------------------------
Fix Version/s: 3.5.0.Beta01
(was: 3.4.0.Final)
groovy template should not print "null" string when
variable is null
--------------------------------------------------------------------
Key: GTNPORTAL-2373
URL: https://issues.jboss.org/browse/GTNPORTAL-2373
Project: GateIn Portal
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Reporter: kien nguyen
Assignee: kien nguyen
Priority: Minor
Labels: portal-s68, worked
Fix For: 3.5.0.Beta01
Attachments: GTNPORTAL-2373.patch
Original Estimate: 2 hours
Remaining Estimate: 2 hours
In .gtmpl file, I use: <input class="key" type="text"
name="key" value="${key}"/>
And if "key" variable is null, I will get "null" string in input
like: <input type="text" name="key" value="null">
I think it should not be, we should print nothing when variable is null, for example:
<input type="text" name="key" value>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:42 a.m.
[
https://issues.jboss.org/browse/GTNPORTAL-2373?page=com.atlassian.jira.pl...
]
Trong Tran commented on GTNPORTAL-2373:
---------------------------------------
printing "null" is an expected behavior from Groovy template engine world. I
don't really like to change this default behavior ( And I can see that JSP syntax does
the same. )
For me, the proper fix is to check non-NULL value before printing if we don't want to
write "null". So I prefer to take "Won't Fix" for this.
WDYT ?
groovy template should not print "null" string when
variable is null
--------------------------------------------------------------------
Key: GTNPORTAL-2373
URL: https://issues.jboss.org/browse/GTNPORTAL-2373
Project: GateIn Portal
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Reporter: kien nguyen
Assignee: kien nguyen
Priority: Minor
Labels: portal-s68, worked
Fix For: 3.5.0.Beta01
Attachments: GTNPORTAL-2373.patch
Original Estimate: 2 hours
Remaining Estimate: 2 hours
In .gtmpl file, I use: <input class="key" type="text"
name="key" value="${key}"/>
And if "key" variable is null, I will get "null" string in input
like: <input type="text" name="key" value="null">
I think it should not be, we should print nothing when variable is null, for example:
<input type="text" name="key" value>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:46 a.m.
[
https://issues.jboss.org/browse/GTNPORTAL-2373?page=com.atlassian.jira.pl...
]
Trong Tran updated GTNPORTAL-2373:
----------------------------------
Status: Open (was: Pull Request Sent)
Git Pull Request: https://github.com/gatein/gatein-portal/pull/119 (was:
https://github.com/gatein/gatein-portal/pull/119)
groovy template should not print "null" string when
variable is null
--------------------------------------------------------------------
Key: GTNPORTAL-2373
URL: https://issues.jboss.org/browse/GTNPORTAL-2373
Project: GateIn Portal
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Reporter: kien nguyen
Assignee: kien nguyen
Priority: Minor
Labels: portal-s68, worked
Fix For: 3.5.0.Beta01
Attachments: GTNPORTAL-2373.patch
Original Estimate: 2 hours
Remaining Estimate: 2 hours
In .gtmpl file, I use: <input class="key" type="text"
name="key" value="${key}"/>
And if "key" variable is null, I will get "null" string in input
like: <input type="text" name="key" value="null">
I think it should not be, we should print nothing when variable is null, for example:
<input type="text" name="key" value>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:46 a.m.
[
https://issues.jboss.org/browse/GTNPORTAL-2373?page=com.atlassian.jira.pl...
]
Trong Tran resolved GTNPORTAL-2373.
-----------------------------------
Resolution: Won't Fix
groovy template should not print "null" string when
variable is null
--------------------------------------------------------------------
Key: GTNPORTAL-2373
URL: https://issues.jboss.org/browse/GTNPORTAL-2373
Project: GateIn Portal
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Reporter: kien nguyen
Assignee: kien nguyen
Priority: Minor
Labels: portal-s68, worked
Fix For: 3.5.0.Beta01
Attachments: GTNPORTAL-2373.patch
Original Estimate: 2 hours
Remaining Estimate: 2 hours
In .gtmpl file, I use: <input class="key" type="text"
name="key" value="${key}"/>
And if "key" variable is null, I will get "null" string in input
like: <input type="text" name="key" value="null">
I think it should not be, we should print nothing when variable is null, for example:
<input type="text" name="key" value>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4240
days inactive
4452
days old
31 comments
6 participants
participants (6)
-
Boleslaw Dawidowicz (JIRA) -
kien nguyen (JIRA)
-
RH Bugzilla Integration (JIRA)
-
Thomas Heute (JIRA)
-
Trong Tran (JIRA)
-
Vu Viet Phuong (JIRA)