[ https://issues.jboss.org/browse/GTNWCI-30?page=com.atlassian.jira.plugin.... ] Trong Tran commented on GTNWCI-30: ---------------------------------- IMO, it would make more sense to introduce Credential interface in GateIn Common component which will be used in both WCI and GateIn itself. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/GTNWCI-30?page=com.atlassian.jira.plugin.... ] kien nguyen updated GTNWCI-30: ------------------------------ Description: We have object org.gatein.wci.security.Credentials. The Credentials are using in "login" function of WCIController, WCILoginController and some token services of GateIn such as CookieTokenService. However, token services are not appropriate to make extension for another kind of credentials that are not username/password. In my case, when I integrate OAuth within GateIn, my credentials are not username/password. They are another information such as consumer key, current logged user, etc. So I think better way we should abstract Credentials OR the Credentials object can extend from an abstract object (org.exoplatform.services.security.Credential). In every implementation, it itself will indicate detail information of Credentials object. See javax.jcr.Credentials object for reference design was: We have object org.gatein.wci.security.Credentials. The Credentials are using in "login" function of WCIController, WCILoginController and some token services of GateIn such as CookieTokenService. However, token services are difficulty to make extension for another kind of credentials that are not username/password. In my case, when I integrate OAuth within GateIn, my credentials are not username/password. They are another information such as consumer key, current logged user, etc. So I think better way we should abstract Credentials OR the Credentials object can extend from an abstract object (org.exoplatform.services.security.Credential). In every implementation, it itself will indicate detail information of Credentials object. See javax.jcr.Credentials object for reference design -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira