IDM DAO classes are only catching IdentityExceptions ---------------------------------------------------- Key: GTNPORTAL-3110 URL: https://issues.jboss.org/browse/GTNPORTAL-3110 Project: GateIn Portal Issue Type: Bug Security Level: Public(Everyone can see) Components: Identity integration Affects Versions: 3.6.0.Beta02 Reporter: Martin Weiler Assignee: Marek Posolda Fix For: 3.6.0.Final In some IDM DAO classes, such as GroupDAOImpl, MembershipDAOImpl and UserProfileDAOImpl all IDM calls are wrapped with try..catch(Exception e) blocks, which ensures that not only IdentityException, but also Hibernate exceptions are caught and recovered with rollback(). But in UserDAOImpl only "IdentityException e" instances are caught. So HibernateException are not handled, which can result in transaction errors. Additionally, in MembershipTypeDAOImpl the IDM calls are not wrapped with any catch blocks, which also needs to be fixed.