[ https://jira.jboss.org/jira/browse/GTNWCI-11?page=com.atlassian.jira.plug... ] Phan Chuong updated GTNWCI-11: ------------------------------ Description: I'm working on eXo WCM, which based on eXo DMS, and of course, based on GateIn Portal. This is the application's order when run eXo WCM with GateIn: ||Application||Portal||DMS||WCM|| |dms-extension| . | x | . | |ecm| . | x | . | |exoadmin| x | . | . | |eXoGadgets| x | . | . | |portal| x | . | . | |presentation| . | . | x | |formgenerator| . | . | x | |eXoDMSGadgets| . | x | . | |starter| x | . | . | |searches| . | . | x | |integration| x | . | . | |rest| x | . | . | |eXoGadgetServer| x | . | . | |newsletter| . | . | x | |eXoDMSResources| . | x | . | |eXoWCMResources| . | . | x | |dashboard| x | . | . | |web| x | . | . | |eXoResources| x | . | . | |ecm-wcm-extension| . | . | x | This made a blocker bug in eXo WCM: almost javascript is ignored because eXo object (which is initialized in eXo.js, belong to eXoResources) is not exist when other object which need it is initialized. For example: in dms-extension, there is an object which call eXo, but at that time, eXo object is not exist, so the javascript in dms-extension is died. What we need is make sure all portal's component is deploy first, then DMS, then WCM, like this ||Application||Portal||DMS||WCM|| |exoadmin| x | . | . | |eXoGadgets| x | . | . | |portal| x | . | . | |starter| x | . | . | |integration| x | . | . | |rest| x | . | . | |eXoGadgetServer| x | . | . | |dashboard| x | . | . | |web| x | . | . | |eXoResources| x | . | . | |dms-extension| . | x | . | |ecm| . | x | . | |eXoDMSGadgets| . | x | . | |eXoDMSResources| . | x | . | |searches| . | . | x | |presentation| . | . | x | |formgenerator| . | . | x | |newsletter| . | . | x | |eXoWCMResources| . | . | x | |ecm-wcm-extension| . | . | x | So i added a new method in TC6ServletContainerContext: {code} private Container[] sortChildren(Host host) { Container[] containers = host.findChildren(); List<Container> unsortedContainers = Arrays.asList(containers); Collections.sort(unsortedContainers, new Comparator<Container>() { public int compare(Container c1, Container c2) { String priority1 = ((StandardContext) c1).getServletContext().getInitParameter("priority"); String priority2 = ((StandardContext) c2).getServletContext().getInitParameter("priority"); if ("null".equals(priority1) || priority1 == null) priority1 = "0"; if ("null".equals(priority2) || priority2 == null) priority2 = "0"; int p1 = Integer.parseInt(priority1); int p2 = Integer.parseInt(priority2); if (p1 > p2) return 1; else return -1; }; }); return unsortedContainers.toArray(new Container[containers.length]); } {code} and in TC6ServletContainerContext.registerHost(Host host) {panel:title=TC6ServletContainerContext.registerHost(Host host)| borderStyle=dashed| borderColor=#ccc| titleBGColor=#F7D6C1| bgColor=#FFFFCE} //Container[] childrenContainers = host.findChildren(); Container[] childrenContainers = sortChildren(host); {code} was: I'm working on eXo WCM, which based on eXo DMS, and of course, based on GateIn Portal. This is the application's order when run eXo WCM with GateIn: ||Application||Portal||DMS||WCM|| |dms-extension| . | x | . | |ecm| . | x | . | |exoadmin| x | . | . | |eXoGadgets| x | . | . | |portal| x | . | . | |presentation| . | . | x | |formgenerator| . | . | x | |eXoDMSGadgets| . | x | . | |starter| x | . | . | |searches| . | . | x | |integration| x | . | . | |rest| x | . | . | |eXoGadgetServer| x | . | . | |newsletter| . | . | x | |eXoDMSResources| . | x | . | |eXoWCMResources| . | . | x | |dashboard| x | . | . | |web| x | . | . | |eXoResources| x | . | . | |ecm-wcm-extension| . | . | x | This made a blocker bug in eXo WCM: almost javascript is ignored because eXo object (which is initialized in eXo.js, belong to eXoResources) is not exist when other object which need it is initialized. For example: in dms-extension, there is an object which call eXo, but at that time, eXo object is not exist, so the javascript in dms-extension is died. What we need is make sure all portal's component is deploy first, then DMS, then WCM, like this ||Application||Portal||DMS||WCM|| |exoadmin| x | . | . | |eXoGadgets| x | . | . | |portal| x | . | . | |starter| x | . | . | |integration| x | . | . | |rest| x | . | . | |eXoGadgetServer| x | . | . | |dashboard| x | . | . | |web| x | . | . | |eXoResources| x | . | . | |dms-extension| . | x | . | |ecm| . | x | . | |eXoDMSGadgets| . | x | . | |eXoDMSResources| . | x | . | |searches| . | . | x | |presentation| . | . | x | |formgenerator| . | . | x | |newsletter| . | . | x | |eXoWCMResources| . | . | x | |ecm-wcm-extension| . | . | x | So i added a new method in TC6ServletContainerContext: {panel:title=TC6ServletContainerContext.sortChildren()| borderStyle=dashed| borderColor=#ccc| titleBGColor=#F7D6C1| bgColor=#FFFFCE} private Container[] sortChildren(Host host) { Container[] containers = host.findChildren(); List<Container> unsortedContainers = Arrays.asList(containers); Collections.sort(unsortedContainers, new Comparator<Container>() { public int compare(Container c1, Container c2) { String priority1 = ((StandardContext) c1).getServletContext().getInitParameter("priority"); String priority2 = ((StandardContext) c2).getServletContext().getInitParameter("priority"); if ("null".equals(priority1) || priority1 == null) priority1 = "0"; if ("null".equals(priority2) || priority2 == null) priority2 = "0"; int p1 = Integer.parseInt(priority1); int p2 = Integer.parseInt(priority2); if (p1 > p2) return 1; else return -1; }; }); return unsortedContainers.toArray(new Container[containers.length]); } {code} and in TC6ServletContainerContext.registerHost(Host host) {panel:title=TC6ServletContainerContext.registerHost(Host host)| borderStyle=dashed| borderColor=#ccc| titleBGColor=#F7D6C1| bgColor=#FFFFCE} //Container[] childrenContainers = host.findChildren(); Container[] childrenContainers = sortChildren(host); {code} -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/GTNWCI-11?page=com.atlassian.jira.plug... ] Phan Chuong updated GTNWCI-11: ------------------------------ Description: I'm working on eXo WCM, which based on eXo DMS, and of course, based on GateIn Portal. This is the application's order when run eXo WCM with GateIn: dms-extension - DMS ecm - DMS exoadmin - PORTAL eXoGadgets - PORTAL portal - PORTAL presentation - WCM formgenerator - WCM eXoDMSGadgets - DMS starter - PORTAL searches - WCM integration - PORTAL rest - PORTAL eXoGadgetServer - PORTAL newsletter - WCM eXoDMSResources - DMS eXoWCMResources - WCM dashboard - PORTAL web - PORTAL eXoResources - PORTAL ecm-wcm-extension - WCM This made a blocker bug in eXo WCM: almost javascript is ignored because eXo object (which is initialized in eXo.js, belong to eXoResources) is not exist when other object which need it is initialized. For example: in dms-extension, there is an object which call eXo, but at that time, eXo object is not exist, so the javascript in dms-extension is died. What we need is make sure all portal's component is deploy first, then DMS, then WCM, like this exoadmin - PORTAL eXoGadgets - PORTAL portal - PORTAL starter - PORTAL integration - PORTAL rest - PORTAL eXoGadgetServer - PORTAL dashboard - PORTAL web - PORTAL eXoResources - PORTAL dms-extension - DMS ecm - DMS eXoDMSGadgets - DMS eXoDMSResources - DMS presentation - WCM formgenerator - WCM searches - WCM newsletter - WCM eXoWCMResources - WCM ecm-wcm-extension - WCM So i added a new method in TC6ServletContainerContext: private Container[] sortChildren(Host host) { Container[] containers = host.findChildren(); List<Container> unsortedContainers = Arrays.asList(containers); Collections.sort(unsortedContainers, new Comparator<Container>() { public int compare(Container c1, Container c2) { String priority1 = ((StandardContext) c1).getServletContext().getInitParameter("priority"); String priority2 = ((StandardContext) c2).getServletContext().getInitParameter("priority"); if ("null".equals(priority1) || priority1 == null) priority1 = "0"; if ("null".equals(priority2) || priority2 == null) priority2 = "0"; int p1 = Integer.parseInt(priority1); int p2 = Integer.parseInt(priority2); if (p1 > p2) return 1; else return -1; }; }); return unsortedContainers.toArray(new Container[containers.length]); } and in TC6ServletContainerContext.registerHost(Host host) //Container[] childrenContainers = host.findChildren(); Container[] childrenContainers = sortChildren(host); And of course, in each war project of DMS, i put new context param <context-param> <param-name>priority</param-name> <param-value>1</param-value> </context-param> and in WCM <context-param> <param-name>priority</param-name> <param-value>2</param-value> </context-param> This fix will assure the deployment order ALWAYS is : PORTAL > DMS > WCM was: I'm working on eXo WCM, which based on eXo DMS, and of course, based on GateIn Portal. This is the application's order when run eXo WCM with GateIn: ||Application||Portal||DMS||WCM|| |dms-extension| . | x | . | |ecm| . | x | . | |exoadmin| x | . | . | |eXoGadgets| x | . | . | |portal| x | . | . | |presentation| . | . | x | |formgenerator| . | . | x | |eXoDMSGadgets| . | x | . | |starter| x | . | . | |searches| . | . | x | |integration| x | . | . | |rest| x | . | . | |eXoGadgetServer| x | . | . | |newsletter| . | . | x | |eXoDMSResources| . | x | . | |eXoWCMResources| . | . | x | |dashboard| x | . | . | |web| x | . | . | |eXoResources| x | . | . | |ecm-wcm-extension| . | . | x | This made a blocker bug in eXo WCM: almost javascript is ignored because eXo object (which is initialized in eXo.js, belong to eXoResources) is not exist when other object which need it is initialized. For example: in dms-extension, there is an object which call eXo, but at that time, eXo object is not exist, so the javascript in dms-extension is died. What we need is make sure all portal's component is deploy first, then DMS, then WCM, like this ||Application||Portal||DMS||WCM|| |exoadmin| x | . | . | |eXoGadgets| x | . | . | |portal| x | . | . | |starter| x | . | . | |integration| x | . | . | |rest| x | . | . | |eXoGadgetServer| x | . | . | |dashboard| x | . | . | |web| x | . | . | |eXoResources| x | . | . | |dms-extension| . | x | . | |ecm| . | x | . | |eXoDMSGadgets| . | x | . | |eXoDMSResources| . | x | . | |searches| . | . | x | |presentation| . | . | x | |formgenerator| . | . | x | |newsletter| . | . | x | |eXoWCMResources| . | . | x | |ecm-wcm-extension| . | . | x | So i added a new method in TC6ServletContainerContext: {code:title=Bar.java|borderStyle=solid} private Container[] sortChildren(Host host) { Container[] containers = host.findChildren(); List<Container> unsortedContainers = Arrays.asList(containers); Collections.sort(unsortedContainers, new Comparator<Container>() { public int compare(Container c1, Container c2) { String priority1 = ((StandardContext) c1).getServletContext().getInitParameter("priority"); String priority2 = ((StandardContext) c2).getServletContext().getInitParameter("priority"); if ("null".equals(priority1) || priority1 == null) priority1 = "0"; if ("null".equals(priority2) || priority2 == null) priority2 = "0"; int p1 = Integer.parseInt(priority1); int p2 = Integer.parseInt(priority2); if (p1 > p2) return 1; else return -1; }; }); return unsortedContainers.toArray(new Container[containers.length]); } {code} and in TC6ServletContainerContext.registerHost(Host host) {panel:title=TC6ServletContainerContext.registerHost(Host host)| borderStyle=dashed| borderColor=#ccc| titleBGColor=#F7D6C1| bgColor=#FFFFCE} //Container[] childrenContainers = host.findChildren(); Container[] childrenContainers = sortChildren(host); {code} -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/GTNWCI-11?page=com.atlassian.jira.plug... ] Julien Viet commented on GTNWCI-11: ----------------------------------- Agreed with Matt, this should not be addressed by WCI layer. Is this javascript deployment performed by GateIn resource deployer ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/GTNWCI-11?page=com.atlassian.jira.plug... ] Phan Chuong commented on GTNWCI-11: ----------------------------------- When i work with GateIn, i also got another problem, i raised a bug here GTNPORTAL-505, can you explain more for me ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/GTNWCI-11?page=com.atlassian.jira.plug... ] Julien Viet commented on GTNWCI-11: ----------------------------------- We should try to depend the less we can on deployment ordering, can you describe the issue you have because of wrong deployment ordering ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira