[
https://issues.jboss.org/browse/GTNPORTAL-2751?page=com.atlassian.jira.pl...
]
Peter Palaga commented on GTNPORTAL-2751:
-----------------------------------------
bq. The proposal B makes more sense to me, BUT it would mean a change in behavior.
I also see B as the most natural way of how it should work and yes, {{<priority>}}
values which were ignored so far, will not be ignored anymore. I believe that the change
will not be that harmful for portal owners because it can be detected quite easily where
it matters (it can be seen at the first sight). They should be aware of it if we document
it properly.
<priority> in navigation.xml files ignored for merge importMode
----------------------------------------------------------------
Key: GTNPORTAL-2751
URL:
https://issues.jboss.org/browse/GTNPORTAL-2751
Project: GateIn Portal
Issue Type: Task
Security Level: Public(Everyone can see)
Reporter: Peter Palaga
Assignee: Hai Nguyen
Original Estimate: 4 hours
Time Spent: 3 hours
Remaining Estimate: 7 hours
Steps to reproduce:
Clone the Portal Extension Quickstart and deploy it changing the {{<priority>}}
value in
{{war/src/main/webapp/WEB-INF/conf/sample-ext/portal/group/platform/administrators/navigation.xml}}.
NOT OK: The changes have no effect, because priority is ignored in
{{org.exoplatform.portal.mop.importer.NavigationImporter.perform()}} with {{importMode}}
{{merge}}.
h3. Solution Proposal A
* Make {{<priority>}} optional in {{gatein_objects}} XSD and
{{NavigationMarshaller.unmarshalNavigation(StaxNavigator<Element>)}}
* Explicitly state in the documentation [1] that {{<priority>}} is considered only
if not already set (first wins).
h3. Solution Proposal B
* Make {{<priority>}} optional in {{gatein_objects}} XSD and
{{NavigationMarshaller.unmarshalNavigation(StaxNavigator<Element>)}}
* Change the behavior of
{{NavigationMarshaller.unmarshalNavigation(StaxNavigator<Element>)}} to the effect
that {{<priority>}} is handled in the same way as navigation nodes: it is used or
ignored according to the chosen {{importMode}}. Esp. for {{importMode}} {{merge}} the last
read {{<priority>}} should win.
* Document it in [1]
For both A and B the most or all occutences of {{<priority>}} should be removed
from Portal Extension Quickstart.
[1] [
https://docs.jboss.org/author/display/GTNPORTAL35/Portal+Navigation+Confi...]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:
http://www.atlassian.com/software/jira